Skip to content

Commit f1d95c2

Browse files
committed
Fix test
The previous additional test messed up partest in that file Types.scala was copied twice into the partest-generated directory and then the pos/core tests would compile both copies. This gave a double definition which manifested itself under -Yno-double-bindings as an assertion error. Ideally, partest generation would guard against this situation. For now I avoid the problem by compiling the whole of core without -Ycheck, not jst Types.scala.
1 parent c29e975 commit f1d95c2

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/dotc/tests.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,8 +156,8 @@ class tests extends CompilerTest {
156156

157157
@Test def dotc_ast = compileDir(dotcDir, "ast")
158158
@Test def dotc_config = compileDir(dotcDir, "config")
159-
@Test def dotc_core = compileDir(dotcDir, "core")("-Yno-double-bindings" :: allowDeepSubtypes)// twice omitted to make tests run faster
160-
@Test def dotc_core_Types = compileFile(dotcDir, "core/Types")(noCheckOptions)
159+
@Test def dotc_core = compileDir(dotcDir, "core")(allowDeepSubtypes)// twice omitted to make tests run faster
160+
@Test def dotc_core_nocheck = compileDir(dotcDir, "core")(noCheckOptions)
161161

162162
// This directory doesn't exist anymore
163163
// @Test def dotc_core_pickling = compileDir(coreDir, "pickling")(allowDeepSubtypes)// twice omitted to make tests run faster

0 commit comments

Comments
 (0)