The big pending/pos test triage

Author: odersky

tests/pending/pos/IterableSelfRec.scala renamed to tests/invalid/pos/IterableSelfRec.scala

@@ -1,3 +1,4 @@
+// This does not currently work because it mixes higher-kinded types and raw type constructors.
 package dotty.collection
 package immutable
 

tests/pending/pos/contrib701.scala renamed to tests/invalid/pos/contrib701.scala

@@ -1,3 +1,4 @@
+// Type arguments on infix operators are not supported by the syntax
 class A {
   def fn1 = List apply 1
   def fn2 = List apply[Int] 2

tests/pending/pos/cycle-jsoup.flags renamed to tests/invalid/pos/cycle-jsoup.flags

@@ -1,3 +1,4 @@
+// This relies on the naming of the transformed classes which will have to change in the new stdlib.
 import scala.collection._
 
 trait Foo[+A,
@@ -6,12 +7,12 @@ trait Foo[+A,
 extends Seq[A] with SeqLike[A, This] with IterableView[A, Coll] with IterableViewLike[A, Coll, This] {
 self =>
 
-  trait Transformed[+B] extends SeqView[B, Coll] with super.Transformed[B] {
+  trait TransformedFoo[+B] extends SeqView[B, Coll] with super.Transformed[B] {
     def length: Int
     def apply(idx: Int): B
     override def toString = viewToString
   }
-  trait Reversed extends Transformed[A] {
+  trait Reversed extends TransformedFoo[A] {
     override def iterator: Iterator[A] = createReversedIterator
     def length: Int = self.length
     def apply(idx: Int): A = self.apply(length - 1 - idx)

tests/pending/pos/cycle-jsoup.scala renamed to tests/invalid/pos/cycle-jsoup.scala

@@ -5,6 +5,9 @@ case class C2(checks: Check[_]*);
 object C {
   def m(x : C2): Any = (null: Any) match {
     case C2(_, rest : _*) => {
+    // Invalid: Vararg pattern cannot be split between normal and :_* patterns.
+    // This split also does not work for vararg arguments, so there's no
+    // good argument it should work for patterns
       rest.map(_.value)
     }
   }

tests/pending/pos/depexists.scala renamed to tests/invalid/pos/depexists.scala

@@ -0,0 +1,16 @@
+case class C[T](x: T)
+
+case class CS(xs: C[_]*)
+
+// t3856
+object Test {
+  val x = CS(C(5), C("abc")) match { case CS(C(5), xs : _*) => xs }
+    // Invalid: Vararg pattern cannot be split between normal and :_* patterns.
+    // This split also does not work for vararg arguments, so there's no
+    // good argument it should work for patterns
+  println(x)
+
+  def foo(xs: Int*) = ()
+  val xs = List(1, 2, 3)
+  foo(1, xs:_*)
+}

tests/pending/pos/dotless-targs.scala renamed to tests/invalid/pos/dotless-targs.scala

@@ -1,3 +1,5 @@
+// Invalid because syntax has changed;
+// template statements cannot be lambdas.
 object t4202_1 {
   () => {
     trait T {

tests/pending/pos/five-dot-f.flags renamed to tests/invalid/pos/five-dot-f.flags

@@ -1,3 +1,4 @@
+// Invalid because structural types are not supported.
 class A {
   (new { def field = 0; def field_=(i: Int) = () }).field = 5 // compiles as expected
   (new { def field(implicit i: Int) = 0; def field_=(i: Int) = () }).field = 5 // compiles even with implicit params on getter

tests/pending/pos/five-dot-f.scala renamed to tests/invalid/pos/five-dot-f.scala

@@ -1,3 +1,4 @@
+// Invalid because lambdas can no longer be tenmplate statements.
 object Test {
   trait Suite { def bar() = () }
 

tests/pending/pos/functions.scala renamed to tests/invalid/pos/functions.scala

@@ -1,3 +1,4 @@
+// Invalid because it relies on internal traits of views that will change their names.
 import scala.collection._
 
 trait SeqViewLike[+A,

tests/pending/pos/generic-sigs.scala renamed to tests/invalid/pos/generic-sigs.scala

@@ -1,3 +1,4 @@
+// Invalid because hk type parameters may not appear in lower bounds
 trait VectorLike[+T, +V[A] <: Vector[A]] {
   def +[S, VResult[S] >: V[S]](v: VResult[S]): Unit
 }

tests/pending/pos/patmat.scala renamed to tests/invalid/pos/patmat.scala

@@ -1,3 +1,4 @@
+// Invalid because nested hk type parameters are no longer allowed
 import language._
 
 

tests/pending/pos/pos-bug1241.scala renamed to tests/invalid/pos/pos-bug1241.scala

@@ -1,3 +1,4 @@
+// Invalid because nested hk type parameters are no longer allowed
 import language.higherKinds
 
 trait P  [N1, +E1[X <: N1]]

tests/pending/pos/specializes-sym-crash.scala renamed to tests/invalid/pos/specializes-sym-crash.scala

@@ -1,5 +1,5 @@
 class A {
   PartialFunction.condOpt(Nil) {
-    case items@List(_*) if true =>
+    case items@List(_: _*) if true =>
   }
 }