Use non-virtual files in dottydoc tests

To avoid the trying to load virtual files based on their pickled names.

Author: nicolasstucki

doc-tool/test/dotty/tools/dottydoc/ConstructorTest.scala

@@ -14,8 +14,7 @@ class ConstructorsFromTastyTest extends ConstructorsBase with CheckFromTasty
 
 abstract class ConstructorsBase extends DottyDocTest {
   @Test def singleClassConstructor = {
-    val source = new SourceFile (
-      "Class.scala",
+    val source = SourceUtil.makeTemp(
       """
       |package scala
       |
@@ -38,8 +37,7 @@ abstract class ConstructorsBase extends DottyDocTest {
   }
 
   @Test def constructorPlusImplicitArgList = {
-    val source = new SourceFile (
-      "Class.scala",
+    val source = SourceUtil.makeTemp(
       """
       |package scala
       |
@@ -65,8 +63,7 @@ abstract class ConstructorsBase extends DottyDocTest {
   }
 
   @Test def multipleArgumentListsForConstructor = {
-    val source = new SourceFile (
-      "Class.scala",
+    val source = SourceUtil.makeTemp(
       """
       |package scala
       |
@@ -93,8 +90,7 @@ abstract class ConstructorsBase extends DottyDocTest {
   }
 
   @Test def multipleConstructors = {
-    val source = new SourceFile (
-      "Class.scala",
+    val source = SourceUtil.makeTemp(
       """
       |package scala
       |
@@ -133,8 +129,7 @@ abstract class ConstructorsBase extends DottyDocTest {
   }
 
   @Test def multipleConstructorsCC = {
-    val source = new SourceFile (
-      "Class.scala",
+    val source = SourceUtil.makeTemp(
       """
       |package scala
       |
@@ -174,8 +169,7 @@ abstract class ConstructorsBase extends DottyDocTest {
   }
 
   @Test def traitParameters = {
-    val source = new SourceFile (
-      "Trait.scala",
+    val source = SourceUtil.makeTemp(
       """
       |package scala
       |

doc-tool/test/dotty/tools/dottydoc/PackageStructure.scala

@@ -13,8 +13,7 @@ class PackageStructureFromTastyTest extends PackageStructureBase with CheckFromT
 abstract class PackageStructureBase extends DottyDocTest {
 
   @Test def sourceFileAnnotIsStripped = {
-    val source = new SourceFile(
-      "A.scala",
+    val source = SourceUtil.makeTemp(
       """package scala
         |
         |/** Some doc */
@@ -33,17 +32,15 @@ abstract class PackageStructureBase extends DottyDocTest {
   }
 
   @Test def multipleCompilationUnits = {
-    val source1 = new SourceFile(
-      "TraitA.scala",
+    val source1 = SourceUtil.makeTemp(
       """
       |package scala
       |
       |trait A
       """.stripMargin
     )
 
-    val source2 = new SourceFile(
-      "TraitB.scala",
+    val source2 = SourceUtil.makeTemp(
       """
       |package scala
       |
@@ -67,17 +64,15 @@ abstract class PackageStructureBase extends DottyDocTest {
 
 
   @Test def multiplePackages = {
-    val source1 = new SourceFile(
-      "TraitA.scala",
+    val source1 = SourceUtil.makeTemp(
       """
       |package scala
       |package collection
       |
       |trait A
       """.stripMargin)
 
-    val source2 = new SourceFile(
-      "TraitB.scala",
+    val source2 = SourceUtil.makeTemp(
       """
       |package scala
       |package collection

doc-tool/test/dotty/tools/dottydoc/SimpleComments.scala

@@ -3,6 +3,7 @@ package dottydoc
 
 import model.internal._
 import dotc.util.SourceFile
+import dotty.tools.io._
 
 import org.junit.Test
 import org.junit.Assert._
@@ -35,8 +36,7 @@ abstract class SimpleCommentsBase extends DottyDocTest {
   }
 
   @Test def simpleComment = {
-    val source = new SourceFile(
-      "HelloWorld.scala",
+    val source = SourceUtil.makeTemp(
       """
       |package scala
       |
@@ -45,6 +45,7 @@ abstract class SimpleCommentsBase extends DottyDocTest {
       """.stripMargin
     )
 
+
     val className = "scala.HelloWorld"
 
     check(className :: Nil, source :: Nil) { (ctx, packages) =>

doc-tool/test/dotty/tools/dottydoc/SourceUtil.scala

@@ -0,0 +1,18 @@
+package dotty.tools.dottydoc
+
+import dotty.tools.dotc.util.SourceFile
+import dotty.tools.io.{Path, PlainFile}
+
+object SourceUtil {
+
+  /** Create a temporary `.scala` source file with the given content */
+  def makeTemp(content: String): SourceFile = {
+    val tempFile = java.io.File.createTempFile("dottydoc-test-", ".scala")
+    tempFile.deleteOnExit()
+    val file = new PlainFile(Path(tempFile.toPath))
+    val out = file.output
+    out.write(content.getBytes)
+    new SourceFile(file, scala.io.Codec.UTF8)
+  }
+
+}

doc-tool/test/dotty/tools/dottydoc/UsecaseTest.scala

@@ -15,8 +15,7 @@ class UsecaseFromTastyTest extends UsecaseBase with CheckFromTasty
 
 abstract class UsecaseBase extends DottyDocTest {
   @Test def simpleUsecase = {
-    val source = new SourceFile(
-      "DefWithUseCase.scala",
+    val source = SourceUtil.makeTemp(
       """
       |package scala
       |
@@ -61,8 +60,7 @@ abstract class UsecaseBase extends DottyDocTest {
   }
 
   @Test def simpleUsecaseAddedArg = {
-    val source = new SourceFile(
-      "DefWithUseCase.scala",
+    val source = SourceUtil.makeTemp(
       """
       |package scala
       |
@@ -108,8 +106,7 @@ abstract class UsecaseBase extends DottyDocTest {
   }
 
   @Test def simpleTparamUsecase = {
-    val source = new SourceFile(
-      "DefWithUseCase.scala",
+    val source = SourceUtil.makeTemp(
       """
       |package scala
       |
@@ -154,8 +151,7 @@ abstract class UsecaseBase extends DottyDocTest {
   }
 
   @Test def expandColl = {
-    val source = new SourceFile(
-      "ExpandColl.scala",
+    val source = SourceUtil.makeTemp(
       """
       |package scala
       |
@@ -199,8 +195,7 @@ abstract class UsecaseBase extends DottyDocTest {
   }
 
   @Test def checkStripping = {
-    val source = new SourceFile(
-      "CheckStripping.scala",
+    val source = SourceUtil.makeTemp(
       """
       |package scala
       |
@@ -236,8 +231,7 @@ abstract class UsecaseBase extends DottyDocTest {
   }
 
   @Test def multipleUseCases: Unit = {
-    val source = new SourceFile(
-      name = "MultipleUseCases.scala",
+    val source = SourceUtil.makeTemp(
       """
         |package scala
         |