defaultParams returns a List of pairs

Update tests

Author: anatoliykmetyuk

compiler/src/dotty/tools/dotc/tastyreflect/ReflectionCompilerInterface.scala

@@ -1779,7 +1779,7 @@ class ReflectionCompilerInterface(val rootContext: core.Contexts.Context) extend
       case sym if sym.is(Flags.CaseAccessor) => sym.asTerm
     }
 
-  def Symbol_defaultParams(self: Symbol)(using ctx: Context): Map[String, Symbol] =
+  def Symbol_defaultParams(self: Symbol)(using ctx: Context): List[(String, Symbol)] =
     assert(self.isClass && self.flags.is(Flags.Case))
     val comp: Symbol = self.companionClass
     val names: List[String] =
@@ -1792,7 +1792,7 @@ class ReflectionCompilerInterface(val rootContext: core.Contexts.Context) extend
       if name.toString.startsWith("$lessinit$greater$default")
       yield deff.symbol
     assert(names.size == idents.size)
-    names.zip(idents).toMap
+    names.zip(idents)
   end Symbol_defaultParams
 
   def Symbol_children(self: Symbol)(using ctx: Context): List[Symbol] =

library/src/scala/tasty/Reflection.scala

@@ -2284,12 +2284,12 @@ class Reflection(private[scala] val internal: CompilerInterface) { self =>
     def caseFields(using ctx: Context): List[Symbol] =
       internal.Symbol_caseFields(sym)
 
-    /** Default parameters of a case class. Keys are names of the parameters and values –
-     *  symbols of the definitions sites of the default values.
+    /** Default parameters of a case class. The first elements of the pairs are names of
+     *  the parameters and values – symbols of the definitions sites of the default values.
      *  Implementation restriction: only the default parameters in the first parameter group
      *  are returned.
      */
-    def defaultParams(using ctx: Context): Map[String, Symbol] =
+    def defaultParams(using ctx: Context): List[(String, Symbol)] =
       internal.Symbol_defaultParams(sym)
 
     def isTypeParam(using ctx: Context): Boolean =

library/src/scala/tasty/reflect/CompilerInterface.scala

@@ -1332,12 +1332,12 @@ trait CompilerInterface {
   /** Fields of a case class type -- only the ones declared in primary constructor */
   def Symbol_caseFields(self: Symbol)(using ctx: Context): List[Symbol]
 
-  /** Default parameters of a case class. Keys are names of the parameters and values –
-   *  symbols of the definitions sites of the default values.
+  /** Default parameters of a case class. The first elements of the pairs are names of
+   *  the parameters and values – symbols of the definitions sites of the default values.
    *  Implementation restriction: only the default parameters in the first parameter group
    *  are returned.
    */
-  def Symbol_defaultParams(self: Symbol)(using ctx: Context): Map[String, Symbol]
+  def Symbol_defaultParams(self: Symbol)(using ctx: Context): List[(String, Symbol)]
 
   def Symbol_of(fullName: String)(using ctx: Context): Symbol
 

tests/run-macros/reflect-defaultParams.check

@@ -1 +1 @@
-Map(address -> Home, age -> 1)
+List((address,Home), (age,1))

tests/run-macros/reflect-defaultParams/Macro_1.scala

@@ -1,12 +1,14 @@
 import scala.quoted._
 
-inline def defaultParams[T]: Map[String, Any] = ${ defaultParamsImpl[T] }
+inline def defaultParams[T]: List[(String, Any)] = ${ defaultParamsImpl[T] }
 private def defaultParamsImpl[T](
-  using tpe: Type[T], qctx: QuoteContext): Expr[Map[String, Any]] =
+  using tpe: Type[T], qctx: QuoteContext): Expr[List[(String, Any)]] =
   import qctx.tasty._
   val sym = tpe.unseal.symbol
-  val exprs: Map[String, Expr[Any]] =
-    sym.defaultParams.view.mapValues(sym =>
-      Ref(sym).seal.cast[Any]).toMap
-  Expr.ofMapValues(exprs)
+  val defaultParams = sym.defaultParams
+  val values: List[Expr[Any]] =
+    defaultParams.map { case (k, v) => Ref(v).seal }
+  val names: List[Expr[String]] =
+    defaultParams.map { case (k, v) => Expr(k) }
+  '{ ${ Expr.ofList(names) }.zip(${ Expr.ofList(values) }) }
 end defaultParamsImpl

tests/run-macros/reflect-defaultParams/Test_2.scala

@@ -1,5 +1,4 @@
-case class Cat(name: String, address: String = "Home",
-  age: Int = 1)(a: Int = age, b: String = address + age)
+case class Cat(name: String, address: String = "Home", age: Int = 1)(a: Int = age, b: String = address + age)
 
 @main def Test =
-  println(defaultParams[Cat].toList.sortBy(_._1))
+  println(defaultParams[Cat])