Skip to content

Commit d0b7b85

Browse files
committed
Review changes
1 parent bc7a1f0 commit d0b7b85

File tree

4 files changed

+4
-8
lines changed

4 files changed

+4
-8
lines changed

scaladoc/src/dotty/tools/scaladoc/api.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ enum Kind(val name: String){
6969
extends Kind("given") with ImplicitConversionProvider
7070
case Implicit(kind: Kind.Def | Kind.Val.type, conversion: Option[ImplicitConversion])
7171
extends Kind(kind.name) with ImplicitConversionProvider
72-
case SelfType(selfName: String) extends Kind("self")
7372
case Unknown extends Kind("Unknown")
7473
}
7574

scaladoc/src/dotty/tools/scaladoc/renderers/MemberRenderer.scala

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -351,11 +351,8 @@ class MemberRenderer(signatureRenderer: SignatureRenderer)(using DocContext) ext
351351

352352
def selfTypeList(list: List[LinkToType]): Seq[AppliedTag] =
353353
if list.isEmpty then Nil
354-
else Seq(div(cls := "symbol monospace") { list.map {
355-
case link if link.kind.isInstanceOf[Kind.SelfType] =>
356-
div(link.kind.asInstanceOf[Kind.SelfType].selfName, ": ", link.signature.map(renderElement))
357-
case link =>
358-
div("self: ", link.signature.map(renderElement))
354+
else Seq(div(cls := "symbol monospace") { list.map { link =>
355+
div(link.signature.map(renderElement))
359356
}})
360357

361358
val supertypes = signatureList(m.parents)

scaladoc/src/dotty/tools/scaladoc/tasty/ClassLikeSupport.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ trait ClassLikeSupport:
8585
val selfType = classDef.self.map { (valdef: ValDef) =>
8686
val symbol = valdef.symbol
8787
val tpe = valdef.tpt.tpe
88-
LinkToType(tpe.asSignature, symbol.dri, Kind.SelfType(valdef.name))
88+
LinkToType(tpe.asSignature, symbol.dri, Kind.Type(false, false, Seq.empty))
8989
}
9090
val selfSignature: DSignature = typeForClass(classDef).asSignature
9191

scaladoc/src/dotty/tools/scaladoc/translators/ScalaSignatureProvider.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ object ScalaSignatureProvider:
3838
builder.text("package ").name(documentable.name, documentable.dri)
3939
case Kind.RootPackage =>
4040
builder
41-
case Kind.Unknown | _: Kind.SelfType =>
41+
case Kind.Unknown =>
4242
???
4343

4444
private def enumEntrySignature(member: Member, cls: Kind.Class, bdr: SignatureBuilder): SignatureBuilder =

0 commit comments

Comments
 (0)