Revert "Allow forcing traces"

This reverts commit 83e6ad4.

Also, optimize trace further to be zero overhead

Author: odersky

compiler/src/dotty/tools/dotc/core/SymbolLoaders.scala

@@ -339,12 +339,9 @@ abstract class SymbolLoader extends LazyType { self =>
     }
     try {
       val start = System.currentTimeMillis
-      if (Config.tracingEnabled && ctx.settings.YdebugTrace.value)
-        trace(s">>>> loading ${root.debugString}", _ => s"<<<< loaded ${root.debugString}") {
-          doComplete(root)
-        }
-      else
+      trace.onDebug("loading") {
         doComplete(root)
+      }
       report.informTime("loaded " + description, start)
     }
     catch {

compiler/src/dotty/tools/dotc/reporting/trace.scala

@@ -7,31 +7,28 @@ import config.Config
 import config.Printers
 import core.Mode
 
-abstract class TraceSyntax {
-  val isForced: Boolean
+/** This module is carefully optimized to give zero overhead if Config.tracingEnabled
+ *  is false. The `trace` operation is called in various hotspots, so every tiny bit
+ *  of overhead is unacceptable: boxing, closures, additional method calls are all out.
+ */
+object trace:
 
   inline def onDebug[TD](inline question: String)(inline op: TD)(using Context): TD =
     conditionally(ctx.settings.YdebugTrace.value, question, false)(op)
 
-  inline def conditionally[TC](inline cond: Boolean, inline question: String, inline show: Boolean)(op: => TC)(using Context): TC =
-    inline if (isForced || Config.tracingEnabled) {
-      if (cond) apply[TC](question, Printers.default, show)(op)
-      else op
-    }
+  inline def conditionally[TC](inline cond: Boolean, inline question: String, inline show: Boolean)(inline op: TC)(using Context): TC =
+    if Config.tracingEnabled then
+      apply(question, if cond then Printers.default else Printers.noPrinter, show)(op)
     else op
 
-  inline def apply[T](inline question: String, inline printer: Printers.Printer, inline showOp: Any => String)(op: => T)(using Context): T =
-    inline if (isForced || Config.tracingEnabled) {
-      if (!isForced && printer.eq(config.Printers.noPrinter)) op
-      else doTrace[T](question, printer, showOp)(op)
-    }
+  inline def apply[T](inline question: String, inline printer: Printers.Printer, inline showOp: Any => String)(inline op: T)(using Context): T =
+    if Config.tracingEnabled then
+      doTrace[T](question, printer, showOp)(op)
     else op
 
-  inline def apply[T](inline question: String, inline printer: Printers.Printer, inline show: Boolean)(op: => T)(using Context): T =
-    inline if (isForced || Config.tracingEnabled) {
-      if (!isForced && printer.eq(config.Printers.noPrinter)) op
-      else doTrace[T](question, printer, if (show) showShowable(_) else alwaysToString)(op)
-    }
+  inline def apply[T](inline question: String, inline printer: Printers.Printer, inline show: Boolean)(inline op: T)(using Context): T =
+    if Config.tracingEnabled then
+      doTrace[T](question, printer, if show then showShowable(_) else alwaysToString)(op)
     else op
 
   inline def apply[T](inline question: String, inline printer: Printers.Printer)(inline op: T)(using Context): T =
@@ -41,62 +38,41 @@ abstract class TraceSyntax {
     apply[T](question, Printers.default, show)(op)
 
   inline def apply[T](inline question: String)(inline op: T)(using Context): T =
-    apply[T](question, Printers.default, false)(op)
+    apply[T](question, false)(op)
 
-  private def showShowable(x: Any)(using Context) = x match {
+  private def showShowable(x: Any)(using Context) = x match
     case x: printing.Showable => x.show
     case _ => String.valueOf(x)
-  }
 
   private val alwaysToString = (x: Any) => String.valueOf(x)
 
   private def doTrace[T](question: => String,
                          printer: Printers.Printer = Printers.default,
                          showOp: Any => String = alwaysToString)
-                        (op: => T)(using Context): T = {
-    // Avoid evaluating question multiple time, since each evaluation
-    // may cause some extra logging output.
-    lazy val q: String = question
-    apply[T](s"==> $q?", (res: Any) => s"<== $q = ${showOp(res)}")(op)
-  }
-
-  def apply[T](leading: => String, trailing: Any => String)(op: => T)(using Context): T = {
-    val log: String => Unit = if (isForced) Console.println else {
-      var logctx = ctx
-      while (logctx.reporter.isInstanceOf[StoreReporter]) logctx = logctx.outer
-      report.log(_)(using logctx)
-    }
-    doApply(leading, trailing, log)(op)
-  }
-
-  def doApply[T](leading: => String, trailing: Any => String, log: String => Unit)(op: => T)(using Context): T =
-    if (ctx.mode.is(Mode.Printing)) op
-    else {
+                        (op: => T)(using Context): T =
+    if ctx.mode.is(Mode.Printing) || (printer eq Printers.noPrinter) then op
+    else
+      // Avoid evaluating question multiple time, since each evaluation
+      // may cause some extra logging output.
+      val q = question
+      val leading = s"==> $q?"
+      val trailing = (res: Any) => s"<== $q = ${showOp(res)}"
       var finalized = false
+      var logctx = ctx
+      while logctx.reporter.isInstanceOf[StoreReporter] do logctx = logctx.outer
+      def margin = ctx.base.indentTab * ctx.base.indent
       def finalize(result: Any, note: String) =
-        if (!finalized) {
+        if !finalized then
           ctx.base.indent -= 1
-          log(s"${ctx.base.indentTab * ctx.base.indent}${trailing(result)}$note")
+          report.log(s"$margin${trailing(result)}$note")
           finalized = true
-        }
-      try {
-        log(s"${ctx.base.indentTab * ctx.base.indent}$leading")
+      try
+        report.log(s"$margin$leading")
         ctx.base.indent += 1
         val res = op
         finalize(res, "")
         res
-      }
-      catch {
-        case ex: Throwable =>
-          finalize("<missing>", s" (with exception $ex)")
-          throw ex
-      }
-    }
-}
-
-object trace extends TraceSyntax {
-  final val isForced = false
-  object force extends TraceSyntax {
-    final val isForced = true
-  }
-}
+      catch case ex: Throwable =>
+        finalize("<missing>", s" (with exception $ex)")
+        throw ex
+end trace