Skip to content

Commit c5251ea

Browse files
committed
Fix #6324: Emit error when pattern splice prototype is not fully defined
Previously it was an assertion which crashed the compilation
1 parent 51e5aa8 commit c5251ea

File tree

2 files changed

+16
-6
lines changed

2 files changed

+16
-6
lines changed

compiler/src/dotty/tools/dotc/typer/Typer.scala

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2011,12 +2011,16 @@ class Typer extends Namer
20112011
typed(innerExpr, pt)
20122012
case expr =>
20132013
if (ctx.mode.is(Mode.QuotedPattern) && level == 1) {
2014-
fullyDefinedType(pt, "quoted pattern selector", tree.span)
2015-
def spliceOwner(ctx: Context): Symbol =
2016-
if (ctx.mode.is(Mode.QuotedPattern)) spliceOwner(ctx.outer) else ctx.owner
2017-
val pat = typedPattern(expr, defn.QuotedExprType.appliedTo(pt))(
2018-
spliceContext.retractMode(Mode.QuotedPattern).withOwner(spliceOwner(ctx)))
2019-
Splice(pat)
2014+
if (isFullyDefined(pt, ForceDegree.all)) {
2015+
def spliceOwner(ctx: Context): Symbol =
2016+
if (ctx.mode.is(Mode.QuotedPattern)) spliceOwner(ctx.outer) else ctx.owner
2017+
val pat = typedPattern(expr, defn.QuotedExprType.appliedTo(pt))(
2018+
spliceContext.retractMode(Mode.QuotedPattern).withOwner(spliceOwner(ctx)))
2019+
Splice(pat)
2020+
} else {
2021+
ctx.error(i"Type must be fully defined.\nConsider annotating the splice using a type ascription:\n ($tree: XYZ).", expr.sourcePos)
2022+
tree.withType(UnspecifiedErrorType)
2023+
}
20202024
}
20212025
else
20222026
typedApply(untpd.Apply(untpd.ref(defn.InternalQuoted_exprSpliceR), tree.expr), pt)(spliceContext).withSpan(tree.span)

tests/neg/i6324.scala

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
class Test {
2+
def res(x: quoted.Expr[Int]) given tasty.Reflection: quoted.Expr[Int] = x match {
3+
case '{ 1 + $b } => // error: Type must be fully defined. Consider annotating the splice using a type ascription: (${b}: XYZ).
4+
b // error: Not found: b
5+
}
6+
}

0 commit comments

Comments
 (0)