Skip to content

Commit c1d551f

Browse files
committed
IDE: Make telemetry dialog modal
VSCode 1.29 made information dialog hide themselves after a few students, so students are likely to miss the dialog, the only way to avoid the timeout is to make the dialog modal.
1 parent 7343e23 commit c1d551f

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

vscode-dotty/src/tracer.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -101,9 +101,11 @@ export class Tracer {
101101
'the content of every Scala file in your project and ' +
102102
'every interaction with Scala files in the IDE, including keystrokes. ' +
103103
'This data will be stored anonymously (we won\'t know your name) on servers at EPFL in Switzerland.',
104-
'Allow', 'Deny',
105-
).then((value: string | undefined) => {
106-
if (value === 'Allow' || value === 'Deny') this.tracingConsent.set(value)
104+
{ 'modal': true },
105+
{ title: 'Allow' },
106+
{ title: 'Deny', isCloseAffordance: true }
107+
).then(value => {
108+
if (value !== undefined && (value.title === 'Allow' || value.title === 'Deny')) this.tracingConsent.set(value.title)
107109
})
108110
}
109111

0 commit comments

Comments
 (0)