Run most phases in second group at group end

Only exception is RefChecks which produces errors when run
at end of group. Probably because it clashes with ExtensionMethods.

Author: odersky

compiler/src/dotty/tools/dotc/transform/ByNameClosures.scala

@@ -29,6 +29,9 @@ class ByNameClosures extends TransformByNameApply with IdentityDenotTransformer
 
   override def phaseName: String = "byNameClosures"
 
+  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
+    groupEndPhase
+
   override def mkByNameClosure(arg: Tree, argType: Type)(implicit ctx: Context): Tree = {
     val meth = ctx.newSymbol(
       ctx.owner, nme.ANON_FUN, Synthetic | Method, MethodType(Nil, Nil, argType))

compiler/src/dotty/tools/dotc/transform/CheckStatic.scala

@@ -39,6 +39,9 @@ class CheckStatic extends MiniPhaseTransform { thisTransformer =>
 
   override def phaseName = "checkStatic"
 
+  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
+    groupEndPhase
+
   override def transformTemplate(tree: tpd.Template)(implicit ctx: Context, info: TransformerInfo): tpd.Tree = {
     val defns = tree.body.collect{case t: ValOrDefDef => t}
     var hadNonStaticField = false

compiler/src/dotty/tools/dotc/transform/ElimRepeated.scala

@@ -30,6 +30,10 @@ class ElimRepeated extends MiniPhaseTransform with InfoTransformer { thisTransfo
 
   override def phaseName = "elimRepeated"
 
+  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
+    groupEndPhase
+
+
   override def changesMembers = true // the phase adds vararg bridges
 
   def transformInfo(tp: Type, sym: Symbol)(implicit ctx: Context): Type =

compiler/src/dotty/tools/dotc/transform/ExpandSAMs.scala

@@ -24,6 +24,9 @@ import dotty.tools.dotc.util.Positions.Position
 class ExpandSAMs extends MiniPhaseTransform { thisTransformer =>
   override def phaseName = "expandSAMs"
 
+  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
+    groupEndPhase
+
   import ast.tpd._
 
   /** Is the SAMType `cls` also a SAM under the rules of the platform? */

compiler/src/dotty/tools/dotc/transform/ExtensionMethods.scala

@@ -42,6 +42,9 @@ class ExtensionMethods extends MiniPhaseTransform with DenotTransformer with Ful
   import tpd._
   import ExtensionMethods._
 
+  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
+    groupEndPhase
+
   /** the following two members override abstract members in Transform */
   override def phaseName: String = "extmethods"
 

compiler/src/dotty/tools/dotc/transform/HoistSuperArgs.scala

@@ -42,6 +42,9 @@ class HoistSuperArgs extends MiniPhaseTransform with IdentityDenotTransformer {
 
   def phaseName = "hoistSuperArgs"
 
+  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
+    groupEndPhase
+
   override def runsAfter = Set(classOf[ByNameClosures])
     // By name closures need to be introduced first in order to be hoisted out here.
     // There's an interaction with by name closures in that the <cbn-arg> marker

compiler/src/dotty/tools/dotc/transform/LiftTry.scala

@@ -32,6 +32,9 @@ class LiftTry extends MiniPhase with IdentityDenotTransformer { thisTransform =>
   class Transform(needLift: Boolean) extends TreeTransform {
     def phase = thisTransform
 
+    override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
+      groupEndPhase
+
     override def prepareForApply(tree: Apply)(implicit ctx: Context) =
       if (tree.fun.symbol.is(Label)) this
       else liftingTransform

compiler/src/dotty/tools/dotc/transform/NormalizeFlags.scala

@@ -6,7 +6,7 @@ import DenotTransformers.SymTransformer
 import Phases.Phase
 import Contexts.Context
 import SymDenotations.SymDenotation
-import TreeTransforms.MiniPhaseTransform
+import TreeTransforms.{MiniPhaseTransform, TransformerInfo}
 import Flags._, Symbols._
 
 /** 1. Widens all private[this] and protected[this] qualifiers to just private/protected
@@ -17,6 +17,9 @@ import Flags._, Symbols._
 class NormalizeFlags extends MiniPhaseTransform with SymTransformer { thisTransformer =>
   override def phaseName = "normalizeFlags"
 
+  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
+    groupEndPhase
+
   def transformSym(ref: SymDenotation)(implicit ctx: Context) = {
     var newFlags = ref.flags &~ Local
     if (newFlags != ref.flags) ref.copySymDenotation(initFlags = newFlags)

compiler/src/dotty/tools/dotc/transform/TailRec.scala

@@ -71,6 +71,9 @@ class TailRec extends MiniPhaseTransform with DenotTransformer with FullParamete
 
   override def phaseName: String = "tailrec"
 
+  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
+    groupEndPhase
+
   final val labelFlags = Flags.Synthetic | Flags.Label
 
   /** Symbols of methods that have @tailrec annotatios inside */

compiler/src/dotty/tools/dotc/typer/RefChecks.scala

@@ -806,6 +806,10 @@ class RefChecks extends MiniPhase { thisTransformer =>
   class Transform(currentLevel: RefChecks.OptLevelInfo = RefChecks.NoLevelInfo) extends TreeTransform {
     def phase = thisTransformer
 
+    // Errors when run at end of group
+    //override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
+    //  groupEndPhase
+
     override def prepareForStats(trees: List[Tree])(implicit ctx: Context) = {
       // println(i"preparing for $trees%; %, owner = ${ctx.owner}")
       if (ctx.owner.isTerm) new Transform(new LevelInfo(currentLevel.levelAndIndex, trees))