Add FIXMEs regarding TypeVar#resetInst breaking all our assumptions

I'm afraid we'll have to get rid of it if we want our caches to be correct, but
I don't have the time to look into it right now.

Author: smarter

compiler/src/dotty/tools/dotc/core/TypeErasure.scala

@@ -894,6 +894,8 @@ class TypeErasure(sourceLanguage: SourceLanguage, semiEraseVCs: Boolean, isConst
    *  `tpnme.Uninstantiated` which is used to signal an underdefined signature
    *  is used.
    *
+   *  FIXME: This does not account for instantiations being retracted by `TypeVar#resetInst`.
+   *
    *  Note: Need to ensure correspondence with erasure!
    */
   private def sigName(tp: Type | Null)(using Context): TypeName = try

compiler/src/dotty/tools/dotc/core/Types.scala

@@ -109,6 +109,8 @@ object Types {
     /** Is this type still provisional? This is the case if the type contains, or depends on,
      *  uninstantiated type variables or type symbols that have the Provisional flag set.
      *  This is an antimonotonic property - once a type is not provisional, it stays so forever.
+     *
+     *  FIXME: The semantics of this flag are broken by the existence of `TypeVar#resetInst`.
      */
     def isProvisional(using Context): Boolean = mightBeProvisional && testProvisional
 
@@ -4739,6 +4741,10 @@ object Types {
    *  is different from the variable's creation state (meaning unrolls are possible)
    *  in the current typer state.
    *
+   *  FIXME: the "once" in the statement above is not true anymore now that `resetInst`
+   *         exists, this is problematic for caching
+   *         (see `Type#isProvisional`, `TypeErasure#sigName`).
+   *
    *  @param  origin           the parameter that's tracked by the type variable.
    *  @param  creatorState     the typer state in which the variable was created.
    *  @param  initNestingLevel the initial nesting level of the type variable. (c.f. nestingLevel)