fix completions to properly contain public fields if they were shadowed by private ones

Author: rochala

compiler/src/dotty/tools/dotc/interactive/Completion.scala

@@ -481,7 +481,11 @@ object Completion {
     private def accessibleMembers(site: Type)(using Context): Seq[SingleDenotation] = {
       def appendMemberSyms(name: Name, buf: mutable.Buffer[SingleDenotation]): Unit =
         try
-          buf ++= site.member(name).alternatives
+          val member = site.member(name)
+          if member.symbol.isAccessibleFrom(site) then
+            buf ++= member.alternatives
+          else
+            buf ++= site.nonPrivateMember(name).alternatives
         catch
           case ex: TypeError =>
 

language-server/test/dotty/tools/languageserver/CompletionTest.scala

@@ -1275,4 +1275,13 @@ class CompletionTest {
       .noCompletions()
   }
 
+  @Test def singleDenotNoCompletions: Unit = {
+    val expected = Set(("symbol", Field, "Int"))
+    code"""class Test(val symbol: Int)
+          |class BetterTest(symbol: Int) extends Test(symbol)
+          |object O:
+          |  def t(test: BetterTest) = test.symb$m1"""
+      .completion(m1, expected)
+  }
+
 }