Move Mode to core

Mode is used from a lot of low-level code, does not just reflect Typer info.
So it makes more sense top to place it in the core package.

Author: odersky

src/dotty/tools/dotc/Compiler.scala

@@ -7,7 +7,7 @@ import Periods._
 import Symbols._
 import Types._
 import Scopes._
-import typer.{FrontEnd, Typer, Mode, ImportInfo, RefChecks}
+import typer.{FrontEnd, Typer, ImportInfo, RefChecks}
 import reporting.{Reporter, ConsoleReporter}
 import Phases.Phase
 import transform._

src/dotty/tools/dotc/ast/Desugar.scala

@@ -9,7 +9,6 @@ import Decorators._
 import language.higherKinds
 import collection.mutable.ListBuffer
 import config.Printers._
-import typer.Mode
 
 object desugar {
 

src/dotty/tools/dotc/ast/tpd.scala

@@ -10,7 +10,6 @@ import util.Positions._, Types._, Contexts._, Constants._, Names._, Flags._
 import SymDenotations._, Symbols._, StdNames._, Annotations._, Trees._, Symbols._
 import Denotations._, Decorators._, DenotTransformers._
 import config.Printers._
-import typer.Mode
 import collection.mutable
 import typer.ErrorReporting._
 

src/dotty/tools/dotc/core/Annotations.scala

@@ -5,7 +5,6 @@ import Symbols._, Types._, util.Positions._, Contexts._, Constants._, ast.tpd._
 import config.ScalaVersion
 import StdNames._
 import dotty.tools.dotc.ast.{tpd, untpd}
-import dotty.tools.dotc.typer.ProtoTypes.FunProtoTyped
 
 object Annotations {
 

src/dotty/tools/dotc/core/Contexts.scala

@@ -18,7 +18,7 @@ import util.Positions._
 import ast.Trees._
 import ast.untpd
 import util.{FreshNameCreator, SimpleMap, SourceFile, NoSource}
-import typer._
+import typer.{Implicits, ImplicitRunInfo, ImportInfo, NamerContextOps, SearchHistory, TypeAssigner, Typer}
 import Implicits.ContextualImplicits
 import config.Settings._
 import config.Config

src/dotty/tools/dotc/core/Decorators.scala

@@ -7,7 +7,6 @@ import Contexts._, Names._, Phases._, printing.Texts._, printing.Printer, printi
 import util.Positions.Position, util.SourcePosition
 import collection.mutable.ListBuffer
 import dotty.tools.dotc.transform.TreeTransforms._
-import typer.Mode
 import scala.language.implicitConversions
 
 /** This object provides useful implicit decorators for types defined elsewhere */

src/dotty/tools/dotc/core/Denotations.scala

@@ -18,7 +18,6 @@ import printing.Texts._
 import printing.Printer
 import io.AbstractFile
 import config.Config
-import typer.Mode
 import util.common._
 import collection.mutable.ListBuffer
 import Decorators.SymbolIteratorDecorator

src/dotty/tools/dotc/typer/Mode.scala renamed to src/dotty/tools/dotc/core/Mode.scala

@@ -1,7 +1,6 @@
-package dotty.tools.dotc.typer
-
-import collection.mutable
+package dotty.tools.dotc.core
 
+/** A collection of mode bits that are part of a context */
 case class Mode(val bits: Int) extends AnyVal {
   import Mode._
   def | (that: Mode) = Mode(bits | that.bits)

src/dotty/tools/dotc/core/SymDenotations.scala

@@ -13,7 +13,6 @@ import Decorators.SymbolIteratorDecorator
 import ast._
 import annotation.tailrec
 import CheckRealizable._
-import typer.Mode
 import util.SimpleMap
 import util.Stats
 import config.Config

src/dotty/tools/dotc/core/TypeApplications.scala

@@ -12,7 +12,6 @@ import Names._
 import NameOps._
 import Flags._
 import StdNames.tpnme
-import typer.Mode
 import util.Positions.Position
 import config.Printers._
 import collection.mutable

src/dotty/tools/dotc/core/TypeComparer.scala

@@ -3,7 +3,6 @@ package dotc
 package core
 
 import Types._, Contexts._, Symbols._, Flags._, Names._, NameOps._, Denotations._
-import typer.Mode
 import Decorators._
 import StdNames.{nme, tpnme}
 import collection.mutable

src/dotty/tools/dotc/core/TypeErasure.scala

@@ -6,7 +6,6 @@ import Symbols._, Types._, Contexts._, Flags._, Names._, StdNames._, Decorators.
 import Uniques.unique
 import dotc.transform.ExplicitOuter._
 import dotc.transform.ValueClasses._
-import typer.Mode
 import util.DotClass
 
 /** Erased types are:

src/dotty/tools/dotc/core/Types.scala

@@ -31,7 +31,6 @@ import config.Config
 import config.Printers._
 import annotation.tailrec
 import Flags.FlagSet
-import typer.Mode
 import language.implicitConversions
 import scala.util.hashing.{ MurmurHash3 => hashing }
 
@@ -3446,7 +3445,7 @@ object Types {
   object CyclicReference {
     def apply(denot: SymDenotation)(implicit ctx: Context): CyclicReference = {
       val ex = new CyclicReference(denot)
-      if (!(ctx.mode is typer.Mode.CheckCyclic)) {
+      if (!(ctx.mode is Mode.CheckCyclic)) {
         cyclicErrors.println(ex.getMessage)
         for (elem <- ex.getStackTrace take 200)
           cyclicErrors.println(elem.toString)

src/dotty/tools/dotc/core/classfile/ClassfileParser.scala

@@ -12,7 +12,6 @@ import scala.collection.{ mutable, immutable }
 import scala.collection.mutable.{ ListBuffer, ArrayBuffer }
 import scala.annotation.switch
 import typer.Checking.checkNonCyclic
-import typer.Mode
 import io.AbstractFile
 import scala.util.control.NonFatal
 

src/dotty/tools/dotc/core/tasty/TreeUnpickler.scala

@@ -13,7 +13,6 @@ import TastyUnpickler._, TastyBuffer._, PositionPickler._
 import scala.annotation.{tailrec, switch}
 import scala.collection.mutable.ListBuffer
 import scala.collection.{ mutable, immutable }
-import typer.Mode
 import config.Printers.pickling
 
 /** Unpickler for typed trees

src/dotty/tools/dotc/core/unpickleScala2/Scala2Unpickler.scala

@@ -17,7 +17,6 @@ import printing.Printer
 import io.AbstractFile
 import util.common._
 import typer.Checking.checkNonCyclic
-import typer.Mode
 import PickleBuffer._
 import scala.reflect.internal.pickling.PickleFormat._
 import Decorators._

src/dotty/tools/dotc/printing/PlainPrinter.scala

@@ -8,7 +8,6 @@ import StdNames.{nme, tpnme}
 import ast.Trees._, ast._
 import java.lang.Integer.toOctalString
 import config.Config.summarizeDepth
-import typer.Mode
 import scala.annotation.switch
 
 class PlainPrinter(_ctx: Context) extends Printer {

src/dotty/tools/dotc/reporting/Reporter.scala

@@ -10,7 +10,7 @@ import collection.mutable
 import config.Settings.Setting
 import config.Printers
 import java.lang.System.currentTimeMillis
-import typer.Mode
+import core.Mode
 import interfaces.Diagnostic.{ERROR, WARNING, INFO}
 
 object Reporter {

src/dotty/tools/dotc/transform/Erasure.scala

@@ -25,7 +25,7 @@ import dotty.tools.dotc.core.Flags
 import ValueClasses._
 import TypeUtils._
 import ExplicitOuter._
-import typer.Mode
+import core.Mode
 
 class Erasure extends Phase with DenotTransformer { thisTransformer =>
 

src/dotty/tools/dotc/transform/LazyVals.scala

@@ -3,7 +3,6 @@ package transform
 
 import dotty.tools.dotc.core.Annotations.Annotation
 import dotty.tools.dotc.core.Phases.NeedsCompanions
-import dotty.tools.dotc.typer.Mode
 
 import scala.collection.mutable
 import core._

src/dotty/tools/dotc/transform/PatternMatcher.scala

@@ -21,7 +21,7 @@ import ast.Trees._
 import Applications._
 import TypeApplications._
 import SymUtils._, core.NameOps._
-import typer.Mode
+import core.Mode
 
 import dotty.tools.dotc.util.Positions.Position
 import dotty.tools.dotc.core.Decorators._

src/dotty/tools/dotc/transform/RestoreScopes.scala

@@ -11,7 +11,6 @@ import TreeTransforms.MiniPhaseTransform
 import SymDenotations._
 import ast.Trees._
 import NameOps._
-import typer.Mode
 import TreeTransforms.TransformerInfo
 import StdNames._
 

src/dotty/tools/dotc/transform/TreeChecker.scala

@@ -15,6 +15,7 @@ import core.StdNames._
 import core.Decorators._
 import core.TypeErasure.isErasedType
 import core.Phases.Phase
+import core.Mode
 import typer._
 import typer.ErrorReporting._
 import reporting.ThrowingReporter

src/dotty/tools/dotc/transform/TreeTransform.scala

@@ -11,7 +11,7 @@ import dotty.tools.dotc.core.Phases.Phase
 import dotty.tools.dotc.core.SymDenotations.SymDenotation
 import dotty.tools.dotc.core.Symbols.Symbol
 import dotty.tools.dotc.core.Flags.PackageVal
-import dotty.tools.dotc.typer.Mode
+import dotty.tools.dotc.core.Mode
 import dotty.tools.dotc.ast.Trees._
 import dotty.tools.dotc.core.Decorators._
 import dotty.tools.dotc.util.DotClass

test/test/DeSugarTest.scala

@@ -9,7 +9,7 @@ import dotty.tools.dotc._
 import ast.Trees._
 import ast.desugar
 import ast.desugar._
-import typer.Mode
+import core.Mode
 import Contexts.Context
 
 import scala.collection.mutable.ListBuffer

test/test/showTree.scala

@@ -3,7 +3,7 @@ import dotty.tools.dotc._
 import ast.Trees._
 import ast.desugar
 import ast.desugar._
-import typer.Mode
+import core.Mode
 
 object showTree extends DeSugarTest {