Merge pull request #5991 from dotty-staging/ide/harden-pos

IDE: Guard against out of bounds positions in requests

Author: smarter

compiler/src/dotty/tools/dotc/util/SourceFile.scala

@@ -115,6 +115,13 @@ class SourceFile(val file: AbstractFile, computeContent: => Array[Char]) extends
   /** Map line to offset of first character in line */
   def lineToOffset(index: Int): Int = lineIndices(index)
 
+  /** Like `lineToOffset`, but doesn't crash if the index is out of bounds. */
+  def lineToOffsetOpt(index: Int): Option[Int] =
+    if (index < 0 || index >= lineIndices.length)
+      None
+    else
+      Some(lineToOffset(index))
+
   /** A cache to speed up offsetToLine searches to similar lines */
   private[this] var lastLine = 0
 

language-server/src/dotty/tools/languageserver/DottyLanguageServer.scala

@@ -651,10 +651,15 @@ object DottyLanguageServer {
       if (isWorksheet(uri)) toWrappedPosition(pos)
       else pos
     val source = driver.openedFiles(uri)
-    if (source.exists) {
-      val p = Spans.Span(source.lineToOffset(actualPosition.getLine) + actualPosition.getCharacter)
-      new SourcePosition(source, p)
-    }
+    if (source.exists)
+      source.lineToOffsetOpt(actualPosition.getLine).map(_ + actualPosition.getCharacter) match {
+        // `<=` to allow an offset to point to the end of the file
+        case Some(offset) if offset <= source.content().length =>
+          val p = Spans.Span(offset)
+          new SourcePosition(source, p)
+        case _ =>
+          NoSourcePosition
+      }
     else NoSourcePosition
   }