Don't exit with StaleSymbol errors when testing pickling.

odersky · odersky · commit aecbb4c86ff8 · 2019-08-07T15:08:39.000+02:00
Stale symbol errors can happen when inspecting symbols while comparing
the trees before and after pickling.
diff --git a/compiler/src/dotty/tools/dotc/core/SymDenotations.scala b/compiler/src/dotty/tools/dotc/core/SymDenotations.scala
@@ -102,8 +102,12 @@ trait SymDenotations { this: Context =>
     }
   }
 
-  /** Configurable: Accept stale symbol with warning if in IDE */
-  def staleOK: Boolean = Config.ignoreStaleInIDE && mode.is(Mode.Interactive)
+  /** Configurable: Accept stale symbol with warning if in IDE
+   *  Always accept stale symbols when testing pickling.
+   */
+  def staleOK: Boolean =
+    Config.ignoreStaleInIDE && mode.is(Mode.Interactive) ||
+    settings.YtestPickler.value
 
   /** Possibly accept stale symbol with warning if in IDE */
   def acceptStale(denot: SingleDenotation): Boolean =

Original file line number	Diff line number	Diff line change
`@@ -102,8 +102,12 @@ trait SymDenotations { this: Context =>`
`102`	`102`	`}`
`103`	`103`	`}`
`104`	`104`
`105`		`- /** Configurable: Accept stale symbol with warning if in IDE */`
`106`		`- def staleOK: Boolean = Config.ignoreStaleInIDE && mode.is(Mode.Interactive)`
	`105`	`+ /** Configurable: Accept stale symbol with warning if in IDE`
	`106`	`+ * Always accept stale symbols when testing pickling.`
	`107`	`+ */`
	`108`	`+ def staleOK: Boolean =`
	`109`	`+ Config.ignoreStaleInIDE && mode.is(Mode.Interactive) \|\|`
	`110`	`+ settings.YtestPickler.value`
`107`	`111`
`108`	`112`	`/** Possibly accept stale symbol with warning if in IDE */`
`109`	`113`	`def acceptStale(denot: SingleDenotation): Boolean =`