Rename stillValid to isValidInRun, add quickpath to it

Author: DarkDimius

src/dotty/tools/dotc/core/Denotations.scala

@@ -486,7 +486,7 @@ object Denotations {
      *  if denotation is no longer valid.
      */
     private def bringForward()(implicit ctx: Context): SingleDenotation = this match {
-      case denot: SymDenotation if ctx.stillValid(denot) =>
+      case denot: SymDenotation if ctx.isValidInRun(denot) =>
         if (denot.exists) assert(ctx.runId > validFor.runId, s"denotation $denot invalid in run ${ctx.runId}. ValidFor: $validFor")
         var d: SingleDenotation = denot
         do {

src/dotty/tools/dotc/core/SymDenotations.scala

@@ -38,17 +38,18 @@ trait SymDenotations { this: Context =>
     result
   }
 
-  def stillValid(denot: SymDenotation): Boolean =
-    if (denot is ValidForever) true
+  def isValidInRun(denot: SymDenotation): Boolean =
+    if(denot.validFor.runId == this.runId) true
+    else if (denot is ValidForever) true
     else try {
       val owner = denot.owner.denot
       def isSelfSym = owner.infoOrCompleter match {
         case ClassInfo(_, _, _, _, selfInfo) => selfInfo == denot.symbol
         case _ => false
       }
-      stillValid(owner) && owner.isClass && (
-           (owner.decls.lookupAll(denot.name) contains denot.symbol)
-        || isSelfSym
+      isValidInRun(owner) && owner.isClass && (
+        (owner.decls.lookupAll(denot.name) contains denot.symbol)
+          || isSelfSym
         )
     } catch {
       case ex: StaleSymbol => false

src/dotty/tools/dotc/core/Types.scala

@@ -1028,7 +1028,7 @@ object Types {
           val sym = lastSymbol
           if (sym == null) loadDenot else denotOfSym(sym)
         case d: SymDenotation =>
-          if (d.validFor.runId == ctx.runId || ctx.stillValid(d)) d.current
+          if (ctx.isValidInRun(d)) d.current
           else {
             val newd = loadDenot
             if (newd.exists) newd else d.staleSymbolError