Scala.js: Consider js.| as a JS type.

Author: sjrd

compiler/src/dotty/tools/backend/sjs/JSDefinitions.scala

@@ -47,6 +47,9 @@ final class JSDefinitions()(using Context) {
   @threadUnsafe lazy val JSBaseThisFunctionType: TypeRef = requiredClassRef("scala.scalajs.js.ThisFunction")
   def JSBaseThisFunctionClass(using Context) = JSBaseThisFunctionType.symbol.asClass
 
+  @threadUnsafe lazy val PseudoUnionType: TypeRef = requiredClassRef("scala.scalajs.js.|")
+  def PseudoUnionClass(using Context) = PseudoUnionType.symbol.asClass
+
   @threadUnsafe lazy val JSArrayType: TypeRef = requiredClassRef("scala.scalajs.js.Array")
   def JSArrayClass(using Context) = JSArrayType.symbol.asClass
 

compiler/src/dotty/tools/backend/sjs/JSInterop.scala

@@ -16,9 +16,8 @@ object JSInterop {
 
   /** Is this symbol a JavaScript type? */
   def isJSType(sym: Symbol)(using Context): Boolean = {
-    //sym.hasAnnotation(jsdefn.RawJSTypeAnnot)
     atPhase(erasurePhase) {
-      sym.derivesFrom(jsdefn.JSAnyClass)
+      sym.derivesFrom(jsdefn.JSAnyClass) || sym == jsdefn.PseudoUnionClass
     }
   }
 

project/Build.scala

@@ -1075,15 +1075,13 @@ object Build {
           ++ (dir / "js/src/test/scala/org/scalajs/testsuite/javalib" ** (("*.scala": FileFilter)
             -- "FormatterJSTest.scala" // compile error with the f"" interpolator
             -- "ObjectJSTest.scala" // non-native JS classes
-            -- "StringBufferJSTest.scala" // IR checking errors
             -- "ThrowableJSTest.scala" // test fails ("java.lang.Error: stub")
             )).get
 
           ++ (dir / "js/src/test/scala/org/scalajs/testsuite/jsinterop" ** (("*.scala": FileFilter)
             -- "AsyncTest.scala" // needs PromiseMock.scala
             -- "DynamicTest.scala" // one test requires JS exports, all other tests pass
             -- "ExportsTest.scala" // JS exports
-            -- "FunctionTest.scala" // IR checking errors
             -- "IterableTest.scala" // non-native JS classes
             -- "JSExportStaticTest.scala" // JS exports
             -- "JSNativeInPackage.scala" // IR checking errors
@@ -1095,8 +1093,6 @@ object Build {
             -- "NonNativeJSTypeTest.scala" // non-native JS classes
             -- "PromiseMock.scala" // non-native JS classes
             -- "SpecialTest.scala" // not yet implemented JS-specific primitive
-            -- "SymbolTest.scala" // IR checking errors
-            -- "UndefOrTest.scala" // StackOverflow in the compiler
             )).get
 
           ++ (dir / "js/src/test/scala/org/scalajs/testsuite/junit" ** (("*.scala": FileFilter)
@@ -1112,7 +1108,6 @@ object Build {
             -- "ObjectTest.scala" // compile errors
             -- "StackTraceTest.scala" // would require `npm install source-map-support`
             -- "UnionTypeTest.scala" // requires a Scala 2 macro + StackOverflow in the compiler
-            -- "WrappedDictionaryTest.scala" // IR checking errors
             )).get
 
           ++ (dir / "js/src/test/scala/org/scalajs/testsuite/niobuffer" ** "*.scala").get
@@ -1128,9 +1123,7 @@ object Build {
             -- "SAMJSTest.scala" // non-native JS classes
             )).get
 
-          ++ (dir / "js/src/test/scala-new-collections" ** (("*.scala": FileFilter)
-            -- "WrappedDictionaryToTest.scala" // IR checking errors
-            )).get
+          ++ (dir / "js/src/test/scala-new-collections" ** "*.scala").get
         )
       }
     )