add comment explaining why checkValue skips Java compilation units

olhotak · olhotak · commit a7bd75f3910a · 2014-10-10T20:47:53.000+02:00
diff --git a/src/dotty/tools/dotc/typer/Checking.scala b/src/dotty/tools/dotc/typer/Checking.scala
@@ -27,6 +27,8 @@ trait Checking {
   def checkValue(tree: Tree, proto: Type)(implicit ctx: Context): tree.type = {
     if (!proto.isInstanceOf[SelectionProto]) {
       val sym = tree.tpe.termSymbol
+      // The check is avoided inside Java compilation units because it always fails
+      // on the singleton type Module.type.
       if ((sym is Package) || ((sym is JavaModule) && !ctx.compilationUnit.isJava)) ctx.error(d"$sym is not a value", tree.pos)
     }
     tree

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,8 @@ trait Checking {`
`27`	`27`	`def checkValue(tree: Tree, proto: Type)(implicit ctx: Context): tree.type = {`
`28`	`28`	`if (!proto.isInstanceOf[SelectionProto]) {`
`29`	`29`	`val sym = tree.tpe.termSymbol`
	`30`	`+ // The check is avoided inside Java compilation units because it always fails`
	`31`	`+ // on the singleton type Module.type.`
`30`	`32`	`if ((sym is Package) \|\| ((sym is JavaModule) && !ctx.compilationUnit.isJava)) ctx.error(d"$sym is not a value", tree.pos)`
`31`	`33`	`}`
`32`	`34`	`tree`