Tweak isReferencedSymbolically

The exception previously made for Scala2 innner classes causes the benchmark
library project to fail with in the tree type map FullParameterization when
called from LinkScala2Impl. It's not necessary to make the special case there
because the Scalq2Unpickler will create anyway symbolic references to such
inner classes.

Author: odersky

compiler/src/dotty/tools/dotc/core/Symbols.scala

@@ -445,11 +445,7 @@ object Symbols {
 
     final def isReferencedSymbolically(implicit ctx: Context) = {
       val d = lastDenot
-      d != null && (
-           (d is NonMember)
-        || d.isClass && d.is(Scala2x) && !d.owner.is(Package)
-        || d.isTerm && ctx.phase.symbolicRefs
-        )
+      d != null && (d.is(NonMember) || d.isTerm && ctx.phase.symbolicRefs)
     }
 
     /** The symbol's signature if it is completed or a method, NotAMethod otherwise. */

compiler/src/dotty/tools/dotc/core/unpickleScala2/Scala2Unpickler.scala

@@ -734,7 +734,7 @@ class Scala2Unpickler(bytes: Array[Byte], classRoot: ClassDenotation, moduleClas
         }
         val tycon =
           if (sym.isClass && sym.is(Scala2x) && !sym.owner.is(Package))
-            // used fixed sym for Scala 2 inner classes, because they might be shadowed
+            // use fixed sym for Scala 2 inner classes, because they might be shadowed
             TypeRef(pre, sym.asType)
           else if (isLocal(sym) || pre == NoPrefix) {
             val pre1 = if ((pre eq NoPrefix) && (sym is TypeParam)) sym.owner.thisType else pre