Refine previous fix

We cannot pull the try that catches the type error over both parts of
`tryExtensionOrConversion` since a failed extension should still cause
a conversion to be tried. We need to try both parts separately instead.

Author: odersky

compiler/src/dotty/tools/dotc/typer/Typer.scala

@@ -3055,6 +3055,10 @@ class Typer extends Namer
         case _ =>
           EmptyTree
 
+    def nestedFailure(ex: TypeError) =
+      rememberSearchFailure(qual,
+        SearchFailure(qual.withType(NestedFailure(ex.toMessage, selectionProto))))
+
     // try an extension method in scope
     try
       val nestedCtx = ctx.fresh.setNewTyperState()
@@ -3065,9 +3069,11 @@ class Typer extends Namer
       for err <- nestedCtx.reporter.allErrors.take(1) do
         rememberSearchFailure(qual,
           SearchFailure(app.withType(FailedExtension(app, selectionProto, err.msg))))
+    catch case ex: TypeError => nestedFailure(ex)
 
-      // try an implicit conversion or given extension
-      if ctx.mode.is(Mode.ImplicitsEnabled) && !tree.name.isConstructorName && qual.tpe.isValueType then
+    // try an implicit conversion or given extension
+    if ctx.mode.is(Mode.ImplicitsEnabled) && !tree.name.isConstructorName && qual.tpe.isValueType then
+      try
         trace(i"try insert impl on qualifier $tree $pt") {
           val selProto = selectionProto
           inferView(qual, selProto) match
@@ -3086,9 +3092,8 @@ class Typer extends Namer
                 )
               rememberSearchFailure(qual, failure)
         }
-    catch case ex: TypeError =>
-      rememberSearchFailure(qual,
-        SearchFailure(qual.withType(NestedFailure(ex.toMessage, selectionProto))))
+      catch case ex: TypeError => nestedFailure(ex)
+
     EmptyTree
   end tryExtensionOrConversion
 

tests/pos/i11994.scala

@@ -0,0 +1,6 @@
+class WeirdNumber(v: Double) extends java.lang.Number {
+  override def doubleValue = v
+  override def intValue    = v.intValue
+  override def longValue   = v.longValue
+  override def floatValue  = v.floatValue
+}