Merge pull request #3473 from maseev/iss1589-sealed-class-extension-violation

Add an error message class for sealed classes

Author: OlivierBlanvillain

compiler/src/dotty/tools/dotc/reporting/diagnostic/ErrorMessageID.java

@@ -117,6 +117,7 @@ public enum ErrorMessageID {
     UnapplyInvalidNumberOfArgumentsID,
     StaticFieldsOnlyAllowedInObjectsID,
     CyclicInheritanceID,
+    UnableToExtendSealedClassID,
     ;
 
     public int errorNumber() {

compiler/src/dotty/tools/dotc/reporting/diagnostic/messages.scala

@@ -1966,4 +1966,10 @@ object messages {
           |impossible to instantiate an object of this class"""
     }
   }
+
+  case class UnableToExtendSealedClass(pclazz: Symbol)(implicit ctx: Context) extends Message(UnableToExtendSealedClassID) {
+    val kind = "Syntax"
+    val msg = hl"Cannot extend ${"sealed"} $pclazz in a different source file"
+    val explanation = "A sealed class or trait can only be extended in the same file as its declaration"
+  }
 }

compiler/src/dotty/tools/dotc/typer/Namer.scala

@@ -877,7 +877,7 @@ class Namer { typer: Typer =>
             if (pclazz.is(Final))
               ctx.error(ExtendFinalClass(cls, pclazz), cls.pos)
             if (pclazz.is(Sealed) && pclazz.associatedFile != cls.associatedFile)
-              ctx.error(em"cannot extend sealed $pclazz in different compilation unit", cls.pos)
+              ctx.error(UnableToExtendSealedClass(pclazz), cls.pos)
             pt
           }
         }