Fix scala.math.BigDecimal.underlying

Author: nicolasstucki

project/MiMaFilters.scala

@@ -118,7 +118,6 @@ object MiMaFilters {
         "scala.concurrent.duration.Deadline.apply", "scala.concurrent.duration.Deadline.copy", "scala.concurrent.duration.Deadline.copy$default$1", "scala.concurrent.duration.FiniteDuration.unary_-",
         "scala.Enumeration#ValueOrdering.this",
         "scala.io.Source#RelaxedPosition.this",
-        "scala.math.BigDecimal.underlying",
         "scala.PartialFunction#OrElse.andThen", "scala.PartialFunction#OrElse.orElse",
         "scala.runtime.Rich*.num", "scala.runtime.Rich*.ord",
         "scala.ScalaReflectionException.andThen", "scala.ScalaReflectionException.compose",

project/TastyMiMaFilters.scala

@@ -111,8 +111,10 @@ object TastyMiMaFilters {
     // Problem: Case class with varargs
     ProblemMatcher.make(ProblemKind.IncompatibleTypeChange, "scala.StringContext.parts"),
 
-    // Problem: Inferred result type of non-private member differs
+    // Problem: ???
     ProblemMatcher.make(ProblemKind.MissingTermMember, "scala.math.Big*.underlying"),
+
+    // Problem: Inferred result type of non-private member differs
     ProblemMatcher.make(ProblemKind.IncompatibleTypeChange, "scala.collection.immutable.TreeSet.sortedIterableFactory"),
     ProblemMatcher.make(ProblemKind.IncompatibleTypeChange, "scala.collection.View.*PartitionMapped.iterator"),
     ProblemMatcher.make(ProblemKind.IncompatibleTypeChange, "scala.concurrent.duration.FiniteDuration.unary_-"),

stdlib-bootstrapped/src/scala/math/BigDecimal.scala

@@ -466,7 +466,7 @@ extends ScalaNumber with ScalaNumericConversions with Serializable with Ordered[
 
   def isWhole = scale <= 0 || bigDecimal.stripTrailingZeros.scale <= 0
 
-  def underlying = bigDecimal
+  def underlying: java.math.BigDecimal = bigDecimal
 
 
   /** Compares this BigDecimal with the specified BigDecimal for equality.