Skip to content

Commit 9349cd6

Browse files
committed
Fix spelling of includeOverridden
1 parent 052764b commit 9349cd6

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

compiler/src/dotty/tools/dotc/interactive/Interactive.scala

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -125,14 +125,14 @@ object Interactive {
125125
* source code.
126126
*
127127
* @param includeReferences If true, include references and not just definitions
128-
* @param includeOverriden If true, include trees whose symbol is overriden by `sym`
128+
* @param includeOverridden If true, include trees whose symbol is overriden by `sym`
129129
*/
130-
def namedTrees(trees: List[SourceTree], includeReferences: Boolean, includeOverriden: Boolean, sym: Symbol)
130+
def namedTrees(trees: List[SourceTree], includeReferences: Boolean, includeOverridden: Boolean, sym: Symbol)
131131
(implicit ctx: Context): List[SourceTree] =
132132
if (!sym.exists)
133133
Nil
134134
else
135-
namedTrees(trees, includeReferences, matchSymbol(_, sym, includeOverriden))
135+
namedTrees(trees, includeReferences, matchSymbol(_, sym, includeOverridden))
136136

137137
/** Find named trees with a non-empty position whose name contains `nameSubstring` in `trees`.
138138
*
@@ -184,10 +184,10 @@ object Interactive {
184184
* The reason for (2) is that if a symbol comes from a SourcefileLoader it is
185185
* different from the symbol that was referred to, until the next run is started.
186186
*/
187-
def matchSymbol(tree: Tree, sym: Symbol, includeOverriden: Boolean)(implicit ctx: Context): Boolean =
187+
def matchSymbol(tree: Tree, sym: Symbol, includeOverridden: Boolean)(implicit ctx: Context): Boolean =
188188
(sym == tree.symbol) ||
189189
sym.name == tree.symbol.name && sym.owner.isClass && sym.owner == tree.symbol.owner ||
190-
(includeOverriden && tree.symbol.allOverriddenSymbols.contains(sym))
190+
(includeOverridden && tree.symbol.allOverriddenSymbols.contains(sym))
191191

192192

193193
/** The reverse path to the node that closest encloses position `pos`,

compiler/src/dotty/tools/dotc/interactive/SourceTree.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ object SourceTree {
4848
def sourceTreeOfClass(tree: tpd.Tree): Option[SourceTree] = tree match {
4949
case PackageDef(_, stats) =>
5050
stats.flatMap(sourceTreeOfClass).headOption
51-
case tree: tpd.TypeDef if matchSymbol(tree, sym, includeOverriden = false) =>
51+
case tree: tpd.TypeDef if matchSymbol(tree, sym, includeOverridden = false) =>
5252
val sourceFile = new SourceFile(sym.sourceFile, Codec.UTF8)
5353
Some(SourceTree(tree, sourceFile))
5454
case _ => None

language-server/src/dotty/tools/languageserver/DottyLanguageServer.scala

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ class DottyLanguageServer extends LanguageServer
224224
// behave with respect to overriding and overriden definitions, ideally
225225
// this should be part of the LSP protocol.
226226
val trees = SourceTree.fromSymbol(sym.topLevelClass.asClass).toList
227-
val defs = Interactive.namedTrees(trees, includeReferences = false, includeOverriden = true, sym)
227+
val defs = Interactive.namedTrees(trees, includeReferences = false, includeOverridden = true, sym)
228228
defs.map(d => location(d.namePos)).asJava
229229
}
230230
}
@@ -246,7 +246,7 @@ class DottyLanguageServer extends LanguageServer
246246
val trees = driver.allTreesContaining(sym.name.toString)
247247
val refs = Interactive.namedTrees(trees, includeReferences = true, (tree: tpd.NameTree) =>
248248
(includeDeclaration || !Interactive.isDefinition(tree))
249-
&& Interactive.matchSymbol(tree, sym, includeOverriden = true))
249+
&& Interactive.matchSymbol(tree, sym, includeOverridden = true))
250250

251251
refs.map(ref => location(ref.namePos)).asJava
252252
}
@@ -267,8 +267,8 @@ class DottyLanguageServer extends LanguageServer
267267
val newName = params.getNewName
268268

269269
val refs = Interactive.namedTrees(trees, includeReferences = true, tree =>
270-
(Interactive.matchSymbol(tree, sym, includeOverriden = true)
271-
|| (linkedSym != NoSymbol && Interactive.matchSymbol(tree, linkedSym, includeOverriden = true))))
270+
(Interactive.matchSymbol(tree, sym, includeOverridden = true)
271+
|| (linkedSym != NoSymbol && Interactive.matchSymbol(tree, linkedSym, includeOverridden = true))))
272272

273273
val changes = refs.groupBy(ref => toUri(ref.source).toString).mapValues(_.map(ref => new TextEdit(range(ref.namePos), newName)).asJava)
274274

@@ -287,7 +287,7 @@ class DottyLanguageServer extends LanguageServer
287287

288288
if (sym == NoSymbol) Nil.asJava
289289
else {
290-
val refs = Interactive.namedTrees(uriTrees, includeReferences = true, includeOverriden = true, sym)
290+
val refs = Interactive.namedTrees(uriTrees, includeReferences = true, includeOverridden = true, sym)
291291
refs.map(ref => new DocumentHighlight(range(ref.namePos), DocumentHighlightKind.Read)).asJava
292292
}
293293
}

0 commit comments

Comments
 (0)