Better static method heuristic

KacperFKorban · KacperFKorban · commit 8fd69bdf42ca · 2021-09-02T13:32:21.000+02:00
diff --git a/scaladoc/src/dotty/tools/scaladoc/tasty/InkuireSupport.scala b/scaladoc/src/dotty/tools/scaladoc/tasty/InkuireSupport.scala
@@ -152,8 +152,7 @@ trait InkuireSupport:
   }
 
   private def nameAndOwnerName(classDef: ClassDef, symbol: Symbol): (String, String) =
-    if classDef.symbol.flags.is(Flags.Module)
-      && (classDef.symbol.companionClass != Symbol.noSymbol || (Seq("apply", "unapply").contains(symbol.name))) then
+    if classDef.symbol.flags.is(Flags.Module) || Seq("apply", "unapply").contains(symbol.name) then
       (
         symbol.maybeOwner.normalizedName + "." + symbol.name,
         ownerNameChain(classDef.symbol.maybeOwner).mkString(".")

Original file line number	Diff line number	Diff line change
`@@ -152,8 +152,7 @@ trait InkuireSupport:`
`152`	`152`	`}`
`153`	`153`
`154`	`154`	`private def nameAndOwnerName(classDef: ClassDef, symbol: Symbol): (String, String) =`
`155`		`- if classDef.symbol.flags.is(Flags.Module)`
`156`		`- && (classDef.symbol.companionClass != Symbol.noSymbol \|\| (Seq("apply", "unapply").contains(symbol.name))) then`
	`155`	`+ if classDef.symbol.flags.is(Flags.Module) \|\| Seq("apply", "unapply").contains(symbol.name) then`
`157`	`156`	`(`
`158`	`157`	`symbol.maybeOwner.normalizedName + "." + symbol.name,`
`159`	`158`	`ownerNameChain(classDef.symbol.maybeOwner).mkString(".")`