add comment explaining why checkValue skips Java compilation units

olhotak · olhotak · commit 8e2c11f41425 · 2014-10-29T17:04:28.000+01:00
diff --git a/src/dotty/tools/dotc/typer/Checking.scala b/src/dotty/tools/dotc/typer/Checking.scala
@@ -179,6 +179,8 @@ trait Checking {
   def checkValue(tree: Tree, proto: Type)(implicit ctx: Context): tree.type = {
     if (!proto.isInstanceOf[SelectionProto]) {
       val sym = tree.tpe.termSymbol
+      // The check is avoided inside Java compilation units because it always fails
+      // on the singleton type Module.type.
       if ((sym is Package) || ((sym is JavaModule) && !ctx.compilationUnit.isJava)) ctx.error(d"$sym is not a value", tree.pos)
     }
     tree

Original file line number	Diff line number	Diff line change
`@@ -179,6 +179,8 @@ trait Checking {`
`179`	`179`	`def checkValue(tree: Tree, proto: Type)(implicit ctx: Context): tree.type = {`
`180`	`180`	`if (!proto.isInstanceOf[SelectionProto]) {`
`181`	`181`	`val sym = tree.tpe.termSymbol`
	`182`	`+ // The check is avoided inside Java compilation units because it always fails`
	`183`	`+ // on the singleton type Module.type.`
`182`	`184`	`if ((sym is Package) \|\| ((sym is JavaModule) && !ctx.compilationUnit.isJava)) ctx.error(d"$sym is not a value", tree.pos)`
`183`	`185`	`}`
`184`	`186`	`tree`