Do not Ycheck inlined positions for macro annotated definitions

In macro annotation definitions, as part of the macro expansion, users
can mess with `Inlined` nodes, which can break YCheckPositions checks.
Similarly to how it is done for macro methods, we now skip checking
definitions with a macro annotation.

Author: jchyb

compiler/src/dotty/tools/dotc/transform/YCheckPositions.scala

@@ -38,6 +38,8 @@ class YCheckPositions extends Phase {
             // Recursivlely check children while keeping track of current source
             reporting.trace(i"check pos ${tree.getClass} ${tree.source} ${sources.head} $tree") {
               tree match {
+                case _ if isMacroAnnotatedDefinition(tree) =>
+                  () // FIXME macro annotated definitions can drop Inlined nodes. As with macro defs, they should be reinserted after macro expansion
                 case tree @ Inlined(_, bindings, expansion) if tree.inlinedFromOuterScope =>
                   assert(bindings.isEmpty)
                   val old = sources
@@ -59,6 +61,12 @@ class YCheckPositions extends Phase {
       case _ =>
     }
 
+  private def isMacroAnnotatedDefinition(tree: tpd.Tree)(using Context) =
+    tree match
+      case tree: TypeDef => tree.isClassDef && MacroAnnotations.hasMacroAnnotation(tree.symbol)
+      case tree: ValOrDefDef => MacroAnnotations.hasMacroAnnotation(tree.symbol)
+      case _ => false
+
   private def isMacro(call: Tree)(using Context) =
     call.symbol.is(Macro) ||
     (call.symbol.isClass && call.tpe.derivesFrom(defn.MacroAnnotationClass)) ||

tests/pos-macros/i17007/Macro_1.scala

@@ -0,0 +1,28 @@
+//> using option "-Ycheck:all"
+import scala.annotation.MacroAnnotation
+import scala.quoted.*
+
+class annotation extends MacroAnnotation:
+  def transform(using Quotes)(tree: quotes.reflect.Definition) =
+    import quotes.reflect.*
+
+    tree match
+      case tree: ClassDef =>
+        val List(DefDef(name, paramss, tpt, Some(body))) = tree.body: @unchecked
+        val rhs = body match
+          case Inlined(_, _, Block(List(Apply(_ /* `locally` */, List(rhs))), _)) => rhs
+        val method = DefDef.copy(tree.body.head)(name, paramss, tpt, Some(rhs.changeOwner(tree.body.head.symbol)))
+        List(ClassDef.copy(tree)(tree.name, tree.constructor, tree.parents, tree.self, List(method)))
+      case tree: DefDef =>
+        val DefDef(name, paramss, tpt, Some(body)) = tree: @unchecked
+        val rhs = body match
+          case Inlined(_, _, Block(List(Apply(_ /* `locally` */, List(rhs))), _)) => rhs
+        val defdef = DefDef.copy(tree)(name, paramss, tpt, Some(rhs.changeOwner(tree.symbol)))
+        List(defdef)
+      case tree: ValDef =>
+        val ValDef(name, tpt, Some(body)) = tree: @unchecked
+        val rhs = body match
+          case Inlined(_, _, Block(List(Apply(_ /* `locally` */, List(rhs))), _)) => rhs
+        val valdef = ValDef.copy(tree)(name, tpt, Some(rhs.changeOwner(tree.symbol)))
+        List(valdef)
+

tests/pos-macros/i17007/Test_2.scala

@@ -0,0 +1,12 @@
+//> using option "-Ycheck:all"
+transparent inline def inlineMethod(v: Int) =
+  locally(v)
+  0
+
+@annotation
+class Test1:
+  def method = inlineMethod(42)
+
+object Test2:
+  @annotation val valdef = inlineMethod(42)
+  @annotation def defdef = inlineMethod(42)