Make dark-mode footer actually dark. Improve contrast/accessibility.

Used the "poor man's dark mode" approach to deal with the images in the
footer in dark mode, i.e. invert and hue rotate (without the hue rotate,
the red scala3doc logo becomes blue)

Also fix an issue where if you click "back to top" and then refresh the
page, the "container" element gains the "expand" class, which causes
the main signature (i.e. `class List[A] ...`) to become 'inline' instead
of a block, and it also triggers the 6.5em left-margin that's intended
for method signatures when they get expanded.

Also consolidated the `footer` styles, since they were spread all over.

Author: dylemma

scaladoc/resources/dotty_res/scripts/ux.js

@@ -39,9 +39,14 @@ window.addEventListener("DOMContentLoaded", () => {
   })
 
   if (location.hash) {
-    var selected = document.getElementById(location.hash.substring(1));
-    if (selected){
-      selected.classList.toggle("expand");
+    var target = location.hash.substring(1);
+    // setting the 'expand' class on the top-level container causes undesireable styles
+    // to apply to the top-level docs, so we avoid this logic for that element.
+    if (target != 'container') {
+      var selected = document.getElementById(location.hash.substring(1));
+      if (selected) {
+        selected.classList.toggle("expand");
+      }
     }
   }
 

scaladoc/resources/dotty_res/styles/scalastyle.css

@@ -25,8 +25,7 @@
   --link-fg: #00607D;
   --link-hover-fg: #00A0D0;
 
-  --link-sig-fd: #2da0d1;
-  --link-sig-hover-fd: #7c99a5;
+  --link-sig-fg: var(--link-fg);
 
   --leftbar-bg: hsl(200, 65%, 75%);
   --leftbar-fg: #333;
@@ -35,6 +34,8 @@
   --leftbar-hover-bg: hsl(200, 65%, 65%);
   --leftbar-hover-fg: #333;
 
+  --footer-bg: #FFF;
+
   --icon-color: #00485E;
   --selected-fg: #00303E;
   --selected-bg: #BFE7F3;
@@ -73,16 +74,18 @@
   --link-fg: hsl(200, 100%, 70%);
   --link-hover-fg: #00A0D0;
 
-  --link-sig-fd: #2da0d1;
-  --link-sig-hover-fd: #7c99a5;
+  --link-sig-fg: #2da0d1;
 
   --leftbar-bg: hsl(200, 100%, 14%);
   --leftbar-fg: #CCC;
   --leftbar-current-bg: hsl(200, 100%, 35%);
-  --leftbar-current-fg: #CCC;
+  --leftbar-current-fg: #FFF;
   --leftbar-hover-bg: hsl(200, 80%, 25%);
   --leftbar-hover-fg: #CCC;
 
+  --footer-bg: var(--body-bg);
+  --footer-fg: var(--body-fg);
+
   --icon-color: #00485E;
   --selected-fg: #00303E;
   --selected-bg: #BFE7F3;
@@ -318,6 +321,7 @@ th {
 
 #sideMenu2 a.selected {
   background: var(--leftbar-current-bg);
+  color: var(--leftbar-current-fg);
   font-weight: bold;
 }
 
@@ -533,6 +537,8 @@ Same solution is already used in Dokka.
 
 /* Footer */
 footer {
+  background: var(--footer-bg);
+  color: var(--footer-fg);
   display: flex;
   bottom: 0px;
   align-items: center;
@@ -543,8 +549,12 @@ footer {
   min-height: var(--footer-height);
   border-top: 1px solid var(--border-light);
 }
-footer span.go-to-top-icon {
-  background-color: white;
+.theme-dark footer img {
+  /* "Poor man's dark mode" for images.
+   * This works great with black images,
+   * and just-okay with colored images.
+   */
+  filter: invert(100%) hue-rotate(180deg);
 }
 footer > span:first-child {
   margin-left: 24px;
@@ -609,9 +619,7 @@ footer .pull-right {
   -webkit-transition: 0.4s;
   transition: 0.4s;
   box-shadow: 0 0px 15px #2020203d;
-
-  background-repeat: no-repeat;
-  background-position: center;
+  background: #555;
 }
 .switch input:checked + .slider {
   background-color: hsl(200, 80%, 65%); /* --active-bg, but not affected by the theme */
@@ -653,7 +661,7 @@ footer .pull-right {
 }
 
 .other-modifiers a, .other-modifiers a:visited, .other-modifiers span[data-unresolved-link] {
-  color: var(--link-sig-fd);
+  color: var(--link-sig-fg);
 }
 
 .documentableElement.expand .modifiers {
@@ -668,7 +676,7 @@ footer .pull-right {
 }
 
 .signature a, .signature a:visited, .signature span[data-unresolved-link] {
-  color: var(--link-sig-fd);
+  color: var(--link-sig-fg);
 }
 
 .expand .signature {
@@ -866,10 +874,6 @@ footer .pull-right {
   margin-right: 5%;
 }
 
-footer {
-  color: grey;
-}
-
 footer .socials {
   margin-left: 10px;
   margin-right: 10px;
@@ -973,7 +977,3 @@ footer .socials {
     display: none;
   }
 }
-
-footer {
-  background-color: white;
-}