Add Symbol.isSuperAccessor to reflection API (#13388)

Author: nicolasstucki

compiler/src/scala/quoted/runtime/impl/QuotesImpl.scala

@@ -2689,6 +2689,7 @@ class QuotesImpl private (using val ctx: Context) extends Quotes, QuoteUnpickler
         def isAnonymousFunction: Boolean = self.denot.isAnonymousFunction
         def isAbstractType: Boolean = self.denot.isAbstractType
         def isClassConstructor: Boolean = self.denot.isClassConstructor
+        def isSuperAccessor = self.name.is(dotc.core.NameKinds.SuperAccessorName)
         def isType: Boolean = self.isType
         def isTerm: Boolean = self.isTerm
         def isPackageDef: Boolean = self.is(dotc.core.Flags.Package)

library/src/scala/quoted/Quotes.scala

@@ -4031,6 +4031,10 @@ trait Quotes { self: runtime.QuoteUnpickler & runtime.QuoteMatching =>
         /** Is this the constructor of a class? */
         def isClassConstructor: Boolean
 
+        /** Is this the super accessor? */
+        @experimental // TODO when stable, remove `dotty.tools.scaladoc.tasty.ClassLikeSupport.isSuperBridgeMethod` and use this method
+        def isSuperAccessor: Boolean
+
         /** Is this the definition of a type? */
         def isType: Boolean
 

scaladoc/src/dotty/tools/scaladoc/tasty/SyntheticSupport.scala

@@ -10,6 +10,7 @@ object SyntheticsSupport:
       import reflect._
       s.flags.is(Flags.Synthetic) || s.flags.is(Flags.FieldAccessor) || s.isDefaultHelperMethod
 
+    // TODO remove and use `SymbolMethods.isSuperAccessor`
     def isSuperBridgeMethod: Boolean = s.name.contains("$super$")
 
     def isDefaultHelperMethod: Boolean = ".*\\$default\\$\\d+$".r.matches(s.name)

tests/run-tasty-inspector/isSuperAccessor.check

@@ -0,0 +1 @@
+method SyncIterator$$super$next

tests/run-tasty-inspector/isSuperAccessor.scala

@@ -0,0 +1,39 @@
+import scala.quoted.*
+import scala.tasty.inspector.*
+
+@main def Test = {
+  // Artefact of the current test infrastructure
+  // TODO improve infrastructure to avoid needing this code on each test
+  val classpath = dotty.tools.dotc.util.ClasspathFromClassloader(this.getClass.getClassLoader).split(java.io.File.pathSeparator).find(_.contains("runWithCompiler")).get
+  val allTastyFiles = dotty.tools.io.Path(classpath).walkFilter(_.extension == "tasty").map(_.toString).toList
+  val tastyFiles = allTastyFiles.filter(_.contains("SyncIterator"))
+
+  TastyInspector.inspectTastyFiles(tastyFiles)(new MyInspector)
+}
+
+class MyInspector extends Inspector:
+
+  override def inspect(using Quotes)(tastys: List[Tasty[quotes.type]]): Unit =
+    import quotes.reflect.*
+    class Traverser extends TreeTraverser:
+      override def traverseTree(tree: Tree)(owner: Symbol) =
+        tree match
+          case tree: DefDef if tree.symbol.isSuperAccessor =>
+            println(tree.symbol)
+          case _ =>
+            super.traverseTree(tree)(owner)
+    end Traverser
+
+    val traverser = new Traverser
+    tastys.foreach { tasty =>
+      traverser.traverseTree(tasty.ast)(tasty.ast.symbol)
+    }
+
+
+trait IntIterator {
+  def next: Int
+  def drop(n: Int): Unit
+}
+trait SyncIterator extends IntIterator {
+  abstract override def next: Int = super.next
+}

tests/run-tasty-inspector/stdlibExperimentalDefinitions.scala

@@ -51,7 +51,9 @@ val experimentalDefinitionInLibrary = Set(
   "scala.annotation.init$.region",
 
    //// New APIs: Quotes
-  // Can be stabilized in 3.4.0 (unsure) or later
+  // Can be stabilized in 3.5.0 or later
+  "scala.quoted.Quotes.reflectModule.SymbolMethods.isSuperAccessor",
+  // Can be stabilized in 3.5.0 (unsure) or later
   "scala.quoted.Quotes.reflectModule.CompilationInfoModule.XmacroSettings",
   // Cant be stabilized yet.
   // Need newClass variant that can add constructor parameters.