Fix #3614: Do not allow the SyntaxFormatter to recolor code

nicolasstucki · nicolasstucki · commit 76702235ecb6 · 2017-12-07T16:45:30.000+01:00
diff --git a/compiler/src/dotty/tools/dotc/printing/Formatting.scala b/compiler/src/dotty/tools/dotc/printing/Formatting.scala
@@ -86,7 +86,8 @@ object Formatting {
         case hb: HighlightBuffer =>
           hb.toString
         case str: String if ctx.settings.color.value != "never" =>
-          new String(SyntaxHighlighting(str).toArray)
+          if (str.matches(".*\u001b\\[.*?m.*")) str // was already colored by some other printer
+          else new String(SyntaxHighlighting(str).toArray)
         case _ => super.showArg(arg)
       }
   }

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,8 @@ object Formatting {`
`86`	`86`	`case hb: HighlightBuffer =>`
`87`	`87`	`hb.toString`
`88`	`88`	`case str: String if ctx.settings.color.value != "never" =>`
`89`		`- new String(SyntaxHighlighting(str).toArray)`
	`89`	`+ if (str.matches(".\u001b\\[.?m.*")) str // was already colored by some other printer`
	`90`	`+ else new String(SyntaxHighlighting(str).toArray)`
`90`	`91`	`case _ => super.showArg(arg)`
`91`	`92`	`}`
`92`	`93`	`}`