Skip to content

Commit 7510c7f

Browse files
authored
Merge pull request #1390 from felixmulder/topic/fix#1352
Correct typo in IsInstanceOfEvalautor, fixes #1352
2 parents bef40b4 + 45fae35 commit 7510c7f

File tree

2 files changed

+17
-2
lines changed

2 files changed

+17
-2
lines changed

src/dotty/tools/dotc/transform/IsInstanceOfEvaluator.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,8 +124,8 @@ class IsInstanceOfEvaluator extends MiniPhaseTransform { thisTransformer =>
124124
!(selector.typeSymbol is Trait) &&
125125
!(selector.typeSymbol is Module)
126126

127-
val selClassNonFinal = scClass && !(selector.typeSymbol is Final)
128-
val selFinalClass = scClass && (selector.typeSymbol is Final)
127+
val selClassNonFinal = selClass && !(selector.typeSymbol is Final)
128+
val selFinalClass = selClass && (selector.typeSymbol is Final)
129129

130130
// Cases ---------------------------------
131131
val valueClassesOrAny =

tests/pos/i1352.scala

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
object Test {
2+
trait A
3+
trait B
4+
abstract sealed class Parent
5+
class Foo extends Parent with A
6+
class Bar extends Parent with B
7+
8+
(null: Parent) match {
9+
case (_: A) | (_: B) =>
10+
/*
11+
* This case would incorrectly be reported as an error,
12+
* due to a typo in IsInstanceOfEvaluator
13+
*/
14+
}
15+
}

0 commit comments

Comments
 (0)