Fix leak in encapsulated type

nicolasstucki · nicolasstucki · commit 6a3bdb781ad2 · 2017-12-20T17:32:10.000+01:00
diff --git a/compiler/src/dotty/tools/dotc/interpreter/PickledQuotes.scala b/compiler/src/dotty/tools/dotc/interpreter/PickledQuotes.scala
@@ -42,7 +42,8 @@ object PickledQuotes {
    *    `package _root_ { def '(hole$1: String, hole$2: String): String = "foo" + hole$1 + "bar" + hole$2 }`
    */
   private def encapsulateQuote(tree: Tree)(implicit ctx: Context): Tree = {
-    val quotedVal = SyntheticValDef("'".toTermName, tree)
+    val sym = ctx.newSymbol(ctx.owner, "'".toTermName, Synthetic, defn.AnyType, coord = tree.pos)
+    val quotedVal = ValDef(sym, tree)
     PackageDef(ref(defn.RootPackage).asInstanceOf[Ident], quotedVal :: Nil)
   }
 
diff --git a/tests/pos/quote-1.scala b/tests/pos/quote-1.scala
@@ -11,6 +11,5 @@ object Test {
    f('{ true })('[Boolean])
 
   def g(es: Expr[String], t: Type[String]) =
-    ??? // FIXME
-//    f('{ (~es + "!") :: Nil })('[List[~t]])
+    f('{ (~es + "!") :: Nil })('[List[~t]])
 }

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,8 @@ object PickledQuotes {`
`42`	`42`	* `package _root_ { def '(hole$1: String, hole$2: String): String = "foo" + hole$1 + "bar" + hole$2 }`
`43`	`43`	`*/`
`44`	`44`	`private def encapsulateQuote(tree: Tree)(implicit ctx: Context): Tree = {`
`45`		`- val quotedVal = SyntheticValDef("'".toTermName, tree)`
	`45`	`+ val sym = ctx.newSymbol(ctx.owner, "'".toTermName, Synthetic, defn.AnyType, coord = tree.pos)`
	`46`	`+ val quotedVal = ValDef(sym, tree)`
`46`	`47`	`PackageDef(ref(defn.RootPackage).asInstanceOf[Ident], quotedVal :: Nil)`
`47`	`48`	`}`
`48`	`49`
Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,5 @@ object Test {`
`11`	`11`	`f('{ true })('[Boolean])`
`12`	`12`
`13`	`13`	`def g(es: Expr[String], t: Type[String]) =`
`14`		`- ??? // FIXME`
`15`		`-// f('{ (~es + "!") :: Nil })('[List[~t]])`
	`14`	`+ f('{ (~es + "!") :: Nil })('[List[~t]])`
`16`	`15`	`}`