Fix settings having uninitialized values

Author: felixmulder

compiler/test/dotc/comptest.scala

@@ -2,8 +2,13 @@ package dotc
 
 import dotty.tools.dotc.vulpix.ParallelTesting
 
+import scala.concurrent.duration._
+
 object comptest extends ParallelTesting {
 
+  def maxDuration = 3.seconds
+  def numberOfSlaves = 5
+  def safeMode = false
   def isInteractive = true
   def testFilter = None
 

compiler/test/dotty/tools/dotc/CompilationTests.scala

@@ -6,15 +6,20 @@ import org.junit.Test
 import org.junit.experimental.categories.Category
 
 import scala.util.matching.Regex
+import scala.concurrent.duration._
 import vulpix.{ ParallelTesting, SummaryReport }
 
 @Category(Array(classOf[ParallelTesting]))
 class CompilationTests extends SummaryReport with ParallelTesting {
   import CompilationTests._
 
-  def isInteractive: Boolean = SummaryReport.isInteractive
+  // Test suite configuration --------------------------------------------------
 
-  def testFilter: Option[Regex] = sys.props.get("dotty.partest.filter").map(r => new Regex(r))
+  def maxDuration = 3.seconds
+  def numberOfSlaves = 5
+  def safeMode = sys.env.get("SAFEMODE").isDefined
+  def isInteractive = SummaryReport.isInteractive
+  def testFilter = sys.props.get("dotty.partest.filter").map(r => new Regex(r))
 
   // Positive tests ------------------------------------------------------------
 

compiler/test/dotty/tools/dotc/vulpix/RunnerOrchestration.scala

@@ -1,6 +1,4 @@
-package dotty
-package tools
-package dotc
+package dotty.tools.dotc
 package vulpix
 
 import java.io.{
@@ -18,15 +16,15 @@ import scala.collection.mutable
 trait RunnerOrchestration {
 
   /** The maximum amount of active runners, which contain a child JVM */
-  val numberOfSlaves: Int
+  def numberOfSlaves: Int
 
   /** The maximum duration the child process is allowed to consume before
    *  getting destroyed
    */
-  val maxDuration: Duration
+  def maxDuration: Duration
 
   /** Destroy and respawn process after each test */
-  val safeMode: Boolean
+  def safeMode: Boolean
 
   /** Running a `Test` class's main method from the specified `dir` */
   def runMain(dir: JFile): Status = monitor.runMain(dir)

compiler/test/dotty/tools/dotc/vulpix/VulpixTests.scala

@@ -6,11 +6,15 @@ package vulpix
 import org.junit.Assert._
 import org.junit.Test
 
+import scala.concurrent.duration._
 import scala.util.control.NonFatal
 
 class VulpixTests extends ParallelTesting {
   import CompilationTests._
 
+  def maxDuration = 3.seconds
+  def numberOfSlaves = 5
+  def safeMode = sys.env.get("SAFEMODE").isDefined
   def isInteractive = !sys.env.contains("DRONE")
   def testFilter = None