Avoid re-parse and change errors messages

Author: Dedelweiss

scaladoc/src/dotty/tools/scaladoc/site/SidebarParser.scala

@@ -32,17 +32,6 @@ object Sidebar:
 
   private object RawInputTypeRef extends TypeReference[RawInput]
 
-  private def pageWithNoTitle(content: String | java.io.File): String =
-    val fileContent = content match {
-    case file: java.io.File => Source.fromFile(file).getLines().mkString("\n")
-    case str: String => str
-    }
-    val lines = fileContent.split("\n")
-    lines.zipWithIndex
-    .find { case (line, i) => line.trim.startsWith("page:") && !lines(i - 1).contains("- title:") }
-    .map(_._1.trim.stripPrefix("page:"))
-    .getOrElse("")
-
   private def toSidebar(r: RawInput, content: String | java.io.File)(using CompilerContext): Sidebar = r match
     case RawInput(title, page, index, subsection, dir, hidden) if page.nonEmpty && index.isEmpty && subsection.isEmpty() =>
       val sidebarPath = content match
@@ -57,14 +46,13 @@ object Sidebar:
       Sidebar.Category(Option.when(title.nonEmpty)(title), Option.when(index.nonEmpty)(index), subsection.asScala.map(toSidebar(_, content)).toList, Option.when(dir.nonEmpty)(dir))
     case RawInput(title, page, index, subsection, dir, hidden) =>
       if title.isEmpty() && index.isEmpty() then
-        val page = pageWithNoTitle(content).trim()
-        val msg = s"Error parsing YAML configuration file: 'title' is not provided for page '$page'."
+        val msg = "`title` property is missing for some page."
         report.error(s"$msg\n$schemaMessage")
       else if title.nonEmpty && (page.isEmpty() || index.isEmpty()) then
         val msg = s"Error parsing YAML configuration file: 'index' or 'page' path is missing for title '$title'."
         report.error(s"$msg\n$schemaMessage")
       else
-        val msg = s"Error parsing YAML configuration file."
+        val msg = "Problem when parsing YAML configuration file."
         report.warning(s"$msg\n$schemaMessage")
       Sidebar.Page(None, page, hidden)
 

scaladoc/test/dotty/tools/scaladoc/site/SidebarParserTest.scala

@@ -91,7 +91,7 @@ class SidebarParserTest:
       |          - page: my-page6/my-page6/my-page6.md
       """.stripMargin
 
-  private val msgNoTitle = "Error parsing YAML configuration file: 'title' is not provided for page 'my-page7/my-page7.md'."
+  private val msgNoTitle = "`title` property is missing for some page."
   private val msgNoPage = "Error parsing YAML configuration file: 'index' or 'page' path is missing for title 'My title'."
 
   private def schemaMessage: String = Sidebar.schemaMessage