Fix templating of properties

Author: BarkingBad

docs/docs/reference/contextual/import-implied.md

@@ -1 +1,6 @@
+---
+layout: doc-page
+title: "Import Implied"
+---
+
 The contents of this page have [moved](./given-imports.md).

docs/docs/reference/contextual/inferable-by-name-parameters.md

@@ -1 +1,6 @@
+---
+layout: doc-page
+title: "Inferable-By-Name Parameters"
+---
+
 The contents of this page have [moved](./by-name-context-parameters.md).

docs/docs/reference/contextual/inferable-params.md

@@ -1 +1,6 @@
+---
+layout: doc-page
+title: "Inferable Params"
+---
+
 The contents of this page have [moved](./using-clauses.md).

docs/docs/reference/contextual/instance-defs.md

@@ -1 +1,6 @@
+---
+layout: doc-page
+title: "Givens"
+---
+
 The contents of this page have [moved](./givens.md).

docs/docs/reference/contextual/query-types-spec.md

@@ -1 +1,6 @@
+---
+layout: doc-page
+title: "Query Types Spec"
+---
+
 The contents of this page have [moved](./context-functions-spec.md).

docs/docs/reference/contextual/query-types.md

@@ -1 +1,6 @@
+---
+layout: doc-page
+title: "Query Types"
+---
+
 The contents of this page have [moved](./context-functions.md).

scala3doc/src/dotty/dokka/site/StaticPageNode.scala

@@ -22,8 +22,8 @@ case class StaticPageNode(
                          ) extends ContentPage:
   override def getDocumentable: Documentable = null
 
-  def title(): String = template.title()
-  def hasFrame(): Boolean = template.hasFrame()
+  def title(): String = template.title
+  def hasFrame(): Boolean = template.hasFrame
 
   override def modified(
     name: String,
@@ -38,4 +38,4 @@ case class StaticPageNode(
 
   def resources(): List[String] = getContent match
     case p: PartiallyRenderedContent => p.resolved.resources
-    case _ => Nil
+    case _ => Nil

scala3doc/src/dotty/dokka/site/StaticSiteContext.scala

@@ -32,7 +32,7 @@ class StaticSiteContext(val root: File, sourceSets: Set[SourceSetWrapper]):
   lazy val layouts: Map[String, TemplateFile] =
     val layoutRoot = new File(root, "_layouts")
     val dirs: Array[File] = Option(layoutRoot.listFiles()).getOrElse(Array())
-    dirs.map { it => loadTemplateFile(it) }.map { it => it.name() -> it }.toMap
+    dirs.map { it => loadTemplateFile(it) }.map { it => it.name -> it }.toMap
 
   lazy val sideBarConfig =
     val sidebarFile = root.toPath.resolve("sidebar.yml")
@@ -111,7 +111,7 @@ class StaticSiteContext(val root: File, sourceSets: Set[SourceSetWrapper]):
       val path = if isBlog then "blog" else url.stripSuffix(".html") + ".md"
       val file = root.toPath.resolve(path) // Add support for .html files!
       val LoadedTemplate(template, children, tFile) = loadTemplate(file.toFile, isBlog).get // Add proper logging if file does not exisits
-      LoadedTemplate(template.copy(settings = template.settings + ("title" -> List(title))), children, tFile)
+      LoadedTemplate(template.copy(settings = template.settings + ("title" -> title)), children, tFile) 
     case Sidebar.Category(title, nested) =>
       // Add support for index.html/index.md files!
       val fakeFile = new File(root, title)
@@ -141,9 +141,9 @@ class StaticSiteContext(val root: File, sourceSets: Set[SourceSetWrapper]):
     )
     StaticPageNode(
       myTemplate.templateFile,
-      myTemplate.templateFile.title(),
+      myTemplate.templateFile.title,
       content,
       JSet(dri),
       JList(),
       (myTemplate.children.map(templateToPage)).asJava
-    )
+    )

scala3doc/src/dotty/dokka/site/common.scala

@@ -40,7 +40,12 @@ val defaultMarkdownOptions: DataHolder =
       "https://github.global.ssl.fastly.net/images/icons/emoji/"
     )
 
-def emptyTemplate(file: File): TemplateFile = TemplateFile(file, isHtml = true, "", Map())
+def emptyTemplate(file: File): TemplateFile = TemplateFile(
+  file = file,
+  isHtml = true,
+  rawCode = "",
+  settings = Map.empty
+)
 
 final val ConfigSeparator = "---"
 final val LineSeparator = "\n"
@@ -61,11 +66,19 @@ def loadTemplateFile(file: File): TemplateFile = {
   val yamlCollector = new AbstractYamlFrontMatterVisitor()
   yamlCollector.visit(configParsed)
 
+  extension (v: java.util.List[String]) def getSettingValue: String | List[String] =
+    if v.size == 1 then v.get(0) else v.asScala.toList
+
+  val globalKeys = Set("extraJS", "extraCSS", "layout", "hasFrame")
+  val (global, inner) = yamlCollector.getData.asScala.toMap.transform((_, v) => v.getSettingValue)
+    .partition((k,_) => globalKeys.contains(k))
+  val settings = global ++ Map("page" -> inner)
+ 
   TemplateFile(
     file = file,
-    file.getName.endsWith(".html"),
+    isHtml = file.getName.endsWith(".html"),
     rawCode = content.mkString(LineSeparator),
-    settings = yamlCollector.getData.asScala.toMap.transform((_, v) => v.asScala.toList)
+    settings = settings,
   )
 }
 

scala3doc/src/dotty/dokka/site/processors.scala

@@ -44,7 +44,7 @@ class SiteResourceManager(ctx: Option[StaticSiteContext]) extends BaseStaticSite
     val modified = input.transformContentPagesTree {
       case it: StaticPageNode =>
         it.copy(getEmbeddedResources =
-          if it.template.hasFrame() then it.getEmbeddedResources ++ it.resources().asJava
+          if it.template.hasFrame then it.getEmbeddedResources ++ it.resources().asJava
           else it.resources().asJava
         )
       case it => it

scala3doc/src/dotty/dokka/site/templates.scala

@@ -15,16 +15,17 @@ import com.vladsch.flexmark.parser.{Parser, ParserEmulationProfile}
 import com.vladsch.flexmark.util.options.{DataHolder, MutableDataSet}
 import com.vladsch.flexmark.html.HtmlRenderer
 import liqp.Template
+import java.util.{ Map => JMap, HashMap => HMap, ArrayList, Collection }
 
 import scala.collection.JavaConverters._
 import scala.io.Source
 
 case class RenderingContext(
-                             properties: Map[String, Object],
-                             layouts: Map[String, TemplateFile] = Map(),
-                             resolving: Set[String] = Set(),
-                             resources: List[String] = Nil
-                           ):
+  properties: Map[String, Element],
+  layouts: Map[String, TemplateFile] = Map(),
+  resolving: Set[String] = Set(),
+  resources: List[String] = Nil
+):
 
   def nest(code: String, file: File, resources: List[String]) =
     copy(
@@ -33,8 +34,8 @@ case class RenderingContext(
       resources = this.resources ++ resources
     )
 
-case class ResolvedPage(val code: String, val resources: List[String] = Nil)
-
+case class ResolvedPage(code: String, resources: List[String] = Nil)
+type Element = String | List[String] | Object // Object represents Map[String, Element] since it is not possible to get circullar dependency
 /**
  * case class for the template files.
  * Template file is a file `.md` or `.html` handling settings.
@@ -44,53 +45,76 @@ case class ResolvedPage(val code: String, val resources: List[String] = Nil)
  * @param settings The config defined in the begging of the file, between the pair of `---` (e.g. layout: basic).
  */
 case class TemplateFile(
-                         val file: File,
-                         val isHtml: Boolean,
-                         val rawCode: String,
-                         val settings: Map[String, List[String]]
-                       ):
-
-  private def stringSetting(name: String): Option[String] =
-    settings.get(name) map {
-      case List(single) => single.stripPrefix("\"").stripSuffix("\"")
-      case nonSingle =>
-        throw new RuntimeException(s"Setting $name is a not a singlel-ement list but $nonSingle")
-    }
-
-
-  private def listSetting(name: String): List[String] = settings.getOrElse(name, Nil)
-
-  def name(): String = stringSetting("name").getOrElse(file.getName.stripSuffix(if (isHtml) ".html" else ".md"))
-
-  def title(): String = stringSetting("title").getOrElse(name())
-
-  def layout(): Option[String] = stringSetting("layout")
-
-  def hasFrame(): Boolean = !stringSetting("hasFrame").contains("false")
-
+  file: File,
+  isHtml: Boolean,
+  rawCode: String,
+  settings: Map[String, Element],
+  name: String,
+  title: String,
+  hasFrame: Boolean,
+  resources: List[String],
+  layout: Option[String],
+):
   def isIndexPage() = file.isFile && (file.getName == "index.md" || file.getName == "index.html")
 
-  def resolveToHtml(ctx: StaticSiteContext): ResolvedPage =
-    val props = Map("page" -> JMap("title" -> title()))
-    resolveInner(RenderingContext(props, ctx.layouts))
+  def resolveToHtml(ctx: StaticSiteContext): ResolvedPage = resolveInner(RenderingContext(settings, ctx.layouts))
 
   private[site] def resolveInner(ctx: RenderingContext): ResolvedPage =
     if (ctx.resolving.contains(file.getAbsolutePath))
       throw new RuntimeException(s"Cycle in templates involving $file: ${ctx.resolving}")
 
-    val layoutTemplate = layout().map(name =>
+    val layoutTemplate = layout.map(name =>
       ctx.layouts.getOrElse(name, throw new RuntimeException(s"No layouts named $name in ${ctx.layouts}")))
 
+    def toJava(m: Any): Any = m match 
+      case sm: Map[_, _] => sm.map(kv => (kv._1, toJava(kv._2))).asJava
+      case sl: Iterable[_] => new ArrayList(sl.map( toJava ).asJava.asInstanceOf[Collection[_]])
+      case _ => m
+
     // Library requires mutable maps..
-    val mutableProperties = new java.util.HashMap[String, Object](ctx.properties.asJava)
+    val mutableProperties = new HMap[String, Object](toJava(ctx.properties).asInstanceOf[JMap[String, Object]])
     val rendered = Template.parse(this.rawCode).render(mutableProperties)
     // We want to render markdown only if next template is html
     val code = if (isHtml || layoutTemplate.exists(!_.isHtml)) rendered else
       val parser: Parser = Parser.builder().build()
       HtmlRenderer.builder(defaultMarkdownOptions).build().render(parser.parse(rendered))
 
-    val resources = listSetting("extraCSS") ++ listSetting("extraJS")
     layoutTemplate match
       case None => ResolvedPage(code, resources ++ ctx.resources)
       case Some(layoutTemplate) =>
         layoutTemplate.resolveInner(ctx.nest(code, file, resources))
+
+object TemplateFile:
+  extension (settings: Map[String, Element]):
+    private def stringSetting(name: String): Option[String] = settings.getOrElse(name, null).match {
+      case List(elem: String) => Some(elem)
+      case elem: String => Some(elem)
+      case _ => None
+    }.map(_.stripPrefix("\"").stripSuffix("\""))
+    
+    private def listSetting(name: String): Option[List[String]] = settings.getOrElse(name, null).match {
+      case elem: List[_] => Some(elem.asInstanceOf[List[String]])
+      case elem: String => Some(List(elem))
+      case _ => None
+    }
+
+  def apply(
+    file: File,
+    isHtml: Boolean,
+    rawCode: String,
+    settings: Map[String, Element],
+  ): TemplateFile = {
+    val name = settings.stringSetting("name").getOrElse(file.getName.stripSuffix(if (isHtml) ".html" else ".md"))
+
+    TemplateFile(
+      file = file,
+      isHtml,
+      rawCode = rawCode,
+      settings = settings,
+      name = name,
+      title = settings.getOrElse("page", settings).asInstanceOf[Map[String, Object]].stringSetting("title").getOrElse(name),
+      hasFrame = !settings.stringSetting("hasFrame").contains("false"),
+      resources = (settings.listSetting("extraCSS") ++ settings.listSetting("extraJS")).flatten.toList,
+      layout = settings.stringSetting("layout")
+    )
+  }

scala3doc/src/dotty/renderers/ScalaHtmlRenderer.scala

@@ -256,7 +256,7 @@ class ScalaHtmlRenderer(ctx: DokkaContext) extends HtmlRenderer(ctx) {
   override def buildHtml(page: PageNode, resources: JList[String], kotlinxContent: FlowContentConsumer): String =
     val (pageTitle, noFrame) = page match
       case static: StaticPageNode =>
-        (static.template.title(), !static.hasFrame())
+        (static.template.title, !static.hasFrame())
       case _ =>
         (page.getName, false)