Fix "types differ" error by moving bridge generation to the next phase

Author: TheElectronWill

compiler/src/dotty/tools/dotc/transform/ElimRepeated.scala

@@ -183,18 +183,7 @@ class ElimRepeated extends MiniPhase with InfoTransformer { thisPhase =>
         // non-overrides cannot be synthetic otherwise javac refuses to call them
         flags = if javaOverride then flags | Artifact else flags,
         info = toJavaVarArgs(ddef.symbol.info)
-      ).enteredAfter(thisPhase).asTerm
-
-    val bridgeDef = polyDefDef(bridge, trefs => vrefss => {
-      val init :+ (last :+ vararg) = vrefss
-      // Can't call `.argTypes` here because the underlying array type is of the
-      // form `Array[? <: SomeType]`, so we need `.argInfos` to get the `TypeBounds`.
-      val elemtp = vararg.tpe.widen.argInfos.head
-      ref(original.termRef)
-        .appliedToTypes(trefs)
-        .appliedToArgss(init)
-        .appliedToArgs(last :+ tpd.wrapArray(vararg, elemtp))
-    })
+      ).asTerm
 
     val bridgeDenot = bridge.denot
     currentClass.info.member(bridge.name).alternatives.find { s =>
@@ -205,7 +194,19 @@ class ElimRepeated extends MiniPhase with InfoTransformer { thisPhase =>
         ctx.error(s"@varargs produces a forwarder method that conflicts with ${conflict.showDcl}", ddef.sourcePos)
         EmptyTree
       case None =>
-        Thicket(ddef, bridgeDef)
+        ctx.atNextPhase {
+          val bridgeDef = polyDefDef(bridge, trefs => vrefss => {
+          val init :+ (last :+ vararg) = vrefss
+          // Can't call `.argTypes` here because the underlying array type is of the
+          // form `Array[? <: SomeType]`, so we need `.argInfos` to get the `TypeBounds`.
+          val elemtp = vararg.tpe.widen.argInfos.head
+          ref(original.termRef)
+            .appliedToTypes(trefs)
+            .appliedToArgss(init)
+            .appliedToArgs(last :+ tpd.wrapArray(vararg, elemtp))
+          })
+          Thicket(ddef, bridgeDef)
+        }
 
   /** Convert type from Scala to Java varargs method */
   private def toJavaVarArgs(tp: Type)(using Context): Type = tp match

tests/neg/varargs-annot.scala

@@ -7,7 +7,7 @@ object Test {
     def v1(a: Int, b: Array[String]) = a
   }
 
-  trait B extends A { // error (could we get rid of that one?)
+  trait B extends A {
     @varargs def v1(a: Int, b: String*) = a + b.length // error
   }