Address review

Author: OlivierBlanvillain

compiler/src/dotty/tools/dotc/core/TyperState.scala

@@ -72,7 +72,7 @@ class TyperState(previous: TyperState /* | Null */) {
     new TyperState(this).setReporter(new StoreReporter(reporter)).setCommittable(isCommittable)
 
   /** The uninstantiated variables */
-  def uninstVars: Seq[Types.TypeVar] = constraint.uninstVars
+  def uninstVars: Seq[TypeVar] = constraint.uninstVars
 
   /** The set of uninstantiated type variables which have this state as their owning state */
   private[this] var myOwnedVars: TypeVars = SimpleIdentitySet.empty

compiler/src/dotty/tools/dotc/core/Types.scala

@@ -3412,7 +3412,7 @@ object Types {
   abstract case class TermParamRef(binder: TermLambda, paramNum: Int) extends ParamRef with SingletonType {
     type BT = TermLambda
     def kindString: String = "Term"
-    def copyBoundType(bt: BT): bt.ParamRefType = bt.paramRefs(paramNum)
+    def copyBoundType(bt: BT): Type = bt.paramRefs(paramNum)
   }
 
   private final class TermParamRefImpl(binder: TermLambda, paramNum: Int) extends TermParamRef(binder, paramNum)
@@ -3423,7 +3423,7 @@ object Types {
   abstract case class TypeParamRef(binder: TypeLambda, paramNum: Int) extends ParamRef {
     type BT = TypeLambda
     def kindString: String = "Type"
-    def copyBoundType(bt: BT): bt.ParamRefType = bt.paramRefs(paramNum)
+    def copyBoundType(bt: BT): Type = bt.paramRefs(paramNum)
 
     /** Optimized version of occursIn, avoid quadratic blowup when solving
      *  constraints over large ground types.
@@ -4875,7 +4875,7 @@ object Types {
 
   @sharable var debugTrace: Boolean = false
 
-  val watchList: List[Names.TypeName] = List[String](
+  val watchList: List[TypeName] = List[String](
   ) map (_.toTypeName)
 
   def isWatched(tp: Type)(implicit ctx: Context): Boolean = tp match {

compiler/src/dotty/tools/dotc/core/classfile/ClassfileParser.scala

@@ -68,7 +68,7 @@ class ClassfileParser(
   protected var pool: ConstantPool = _              // the classfile's constant pool
 
   protected var currentClassName: SimpleName = _      // JVM name of the current class
-  protected var classTParams: Map[Name, Symbol] = Map[Name, Symbol]()
+  protected var classTParams: Map[Name, Symbol] = Map()
 
   private[this] var Scala2UnpicklingMode = Mode.Scala2Unpickling
 

compiler/src/dotty/tools/dotc/core/tasty/PositionUnpickler.scala

@@ -4,14 +4,14 @@ package core
 package tasty
 
 import util.Positions._
-import collection.mutable
+import collection.{mutable, Map}
 import TastyBuffer.Addr
 
 /** Unpickler for tree positions */
 class PositionUnpickler(reader: TastyReader) {
   import reader._
 
-  private[tasty] lazy val positions: mutable.HashMap[Addr, Position] = {
+  private[tasty] lazy val positions: Map[Addr, Position] = {
     val positions = new mutable.HashMap[Addr, Position]
     var curIndex = 0
     var curStart = 0

compiler/src/dotty/tools/dotc/core/tasty/TastyBuffer.scala

@@ -22,7 +22,7 @@ object TastyBuffer {
     def relativeTo(base: Addr): Addr = this - base.index - AddrWidth
   }
 
-  val NoAddr: TastyBuffer.Addr = Addr(-1)
+  val NoAddr: Addr = Addr(-1)
 
   /** The maximal number of address bytes.
    *  Since addresses are written as base-128 natural numbers,
@@ -41,7 +41,7 @@ import TastyBuffer._
 class TastyBuffer(initialSize: Int) {
 
   /** The current byte array, will be expanded as needed */
-  var bytes: Array[Byte] = new Array[Byte](initialSize)
+  var bytes: Array[Byte] = new Array(initialSize)
 
   /** The number of bytes written */
   var length: Int = 0
@@ -155,7 +155,7 @@ class TastyBuffer(initialSize: Int) {
   }
 
   /** The address (represented as a natural number) at address `at` */
-  def getAddr(at: Addr): TastyBuffer.Addr = Addr(getNat(at))
+  def getAddr(at: Addr): Addr = Addr(getNat(at))
 
   /** The smallest address equal to or following `at` which points to a non-zero byte */
   final def skipZeroes(at: Addr): Addr =

compiler/src/dotty/tools/dotc/core/tasty/TastyPickler.scala

@@ -16,7 +16,7 @@ class TastyPickler(val rootCls: ClassSymbol) {
 
   val nameBuffer: NameBuffer = new NameBuffer
 
-  def newSection(name: String, buf: TastyBuffer): mutable.ArrayBuffer[(NameRef, TastyBuffer)] =
+  def newSection(name: String, buf: TastyBuffer): Unit =
     sections += ((nameBuffer.nameIndex(name.toTermName), buf))
 
   def assembleParts(): Array[Byte] = {

compiler/src/dotty/tools/dotc/core/tasty/TastyReader.scala

@@ -20,7 +20,7 @@ class TastyReader(val bytes: Array[Byte], start: Int, end: Int, val base: Int =
 
   private[this] var bp: Int = start
 
-  def addr(idx: Int): TastyBuffer.Addr = Addr(idx - base)
+  def addr(idx: Int): Addr = Addr(idx - base)
   def index(addr: Addr): Int = addr.index + base
 
   /** The address of the first byte to read, respectively byte that was read */
@@ -105,10 +105,10 @@ class TastyReader(val bytes: Array[Byte], start: Int, end: Int, val base: Int =
   }
 
   /** Read a natural number and return as a NameRef */
-  def readNameRef(): TastyBuffer.NameRef = NameRef(readNat())
+  def readNameRef(): NameRef = NameRef(readNat())
 
   /** Read a natural number and return as an address */
-  def readAddr(): TastyBuffer.Addr = Addr(readNat())
+  def readAddr(): Addr = Addr(readNat())
 
   /** Read a length number and return the absolute end address implied by it,
    *  given as <address following length field> + <length-value-read>.

compiler/src/dotty/tools/dotc/core/unpickleScala2/Scala2Unpickler.scala

@@ -243,7 +243,7 @@ class Scala2Unpickler(bytes: Array[Byte], classRoot: ClassDenotation, moduleClas
   }
 
   /** The `decls` scope associated with given symbol */
-  protected def symScope(sym: Symbol): Scopes.Scope = symScopes.getOrElseUpdate(sym, newScope)
+  protected def symScope(sym: Symbol): Scope = symScopes.getOrElseUpdate(sym, newScope)
 
   /** Does entry represent an (internal) symbol */
   protected def isSymbolEntry(i: Int)(implicit ctx: Context): Boolean = {
@@ -611,7 +611,7 @@ class Scala2Unpickler(bytes: Array[Byte], classRoot: ClassDenotation, moduleClas
       loadTypeParams
   }
 
-  def rootClassUnpickler(start: Coord, cls: Symbol, module: Symbol, infoRef: Int): ClassUnpickler with SymbolLoaders.SecondCompleter =
+  def rootClassUnpickler(start: Coord, cls: Symbol, module: Symbol, infoRef: Int): ClassUnpickler =
     (new ClassUnpickler(infoRef) with SymbolLoaders.SecondCompleter {
       override def startCoord(denot: SymDenotation): Coord = start
     }) withDecls symScope(cls) withSourceModule (_ => module)

compiler/src/dotty/tools/dotc/interactive/InteractiveDriver.scala

@@ -265,6 +265,6 @@ class InteractiveDriver(val settings: List[String]) extends Driver {
 }
 
 object InteractiveDriver {
-  def toUri(source: SourceFile): java.net.URI = Paths.get(source.file.path).toUri
+  def toUri(source: SourceFile): URI = Paths.get(source.file.path).toUri
 }
 

compiler/src/dotty/tools/dotc/parsing/JavaScanners.scala

@@ -534,5 +534,5 @@ object JavaScanners {
     nextToken()
   }
 
-  val ((lastKeywordStart: Int), (kwArray: Array[Int])) = buildKeywordArray(keywords)
+  private val ((lastKeywordStart: Int), (kwArray: Array[Int])) = buildKeywordArray(keywords)
 }

compiler/src/dotty/tools/dotc/parsing/Parsers.scala

@@ -299,7 +299,7 @@ object Parsers {
       case _                  => accept(SEMI)
     }
 
-    def acceptStatSepUnlessAtEnd(altEnd: Token = EOF): AnyVal =
+    def acceptStatSepUnlessAtEnd(altEnd: Token = EOF): Unit =
       if (!isStatSeqEnd)
         in.token match {
           case EOF =>

compiler/src/dotty/tools/dotc/parsing/Scanners.scala

@@ -82,7 +82,7 @@ object Scanners {
 
     /** A character buffer for literals
       */
-    val litBuf: mutable.StringBuilder = new StringBuilder
+    protected val litBuf: mutable.StringBuilder = new StringBuilder
 
     /** append Unicode character to "litBuf" buffer
       */
@@ -194,7 +194,7 @@ object Scanners {
     def getDocComment(pos: Int): Option[Comment] = docstringMap.get(pos)
 
     /** A buffer for comments */
-    val commentBuf: mutable.StringBuilder = new StringBuilder
+    private[this] val commentBuf: mutable.StringBuilder = new StringBuilder
 
     private def handleMigration(keyword: Token): Token =
       if (!isScala2Mode) keyword

compiler/src/dotty/tools/dotc/parsing/xml/MarkupParsers.scala

@@ -58,7 +58,7 @@ object MarkupParsers {
 
     def mkAttributes(name: String, other: NamespaceType): AttributesType = xAttributes
 
-    val eof: Boolean = false
+    def eof: Boolean = false
 
     def truncatedError(msg: String): Nothing = throw TruncatedXMLControl
     def xHandleError(that: Char, msg: String): Unit =

compiler/src/dotty/tools/dotc/printing/Highlighting.scala

@@ -31,7 +31,7 @@ object Highlighting {
   }
 
   case class HighlightBuffer(hl: Highlight)(implicit ctx: Context) {
-    val buffer: mutable.ListBuffer[String] = new mutable.ListBuffer[String]
+    private[this] val buffer: mutable.ListBuffer[String] = new mutable.ListBuffer[String]
 
     buffer += hl.show
 

compiler/src/dotty/tools/dotc/printing/package.scala

@@ -19,7 +19,7 @@ package object printing {
    *
    *  -Xprint will print `sym.name` instead of `sym.originalName`
    */
-  val XprintMode: Key[Unit] = new Key[Unit]
+  val XprintMode: Key[Unit] = new Key
 
   /** @pre `nel` is non-empty list */
   private[printing] implicit class ListOps[A](val nel: List[A]) extends AnyVal {

compiler/src/dotty/tools/dotc/profile/Profiler.scala

@@ -1,7 +1,7 @@
 package dotty.tools.dotc.profile
 
 import java.io.{FileWriter, PrintWriter}
-import java.lang.management.{ManagementFactory, GarbageCollectorMXBean}
+import java.lang.management.{ManagementFactory, GarbageCollectorMXBean, RuntimeMXBean, MemoryMXBean, ClassLoadingMXBean, CompilationMXBean}
 import java.util.concurrent.TimeUnit
 import java.util.concurrent.atomic.AtomicInteger
 import javax.management.openmbean.CompositeData
@@ -81,11 +81,11 @@ private [profile] object NoOpProfiler extends Profiler {
 }
 private [profile] object RealProfiler {
   import scala.collection.JavaConverters._
-  val runtimeMx: management.RuntimeMXBean = ManagementFactory.getRuntimeMXBean
-  val memoryMx: management.MemoryMXBean = ManagementFactory.getMemoryMXBean
+  val runtimeMx: RuntimeMXBean = ManagementFactory.getRuntimeMXBean
+  val memoryMx: MemoryMXBean = ManagementFactory.getMemoryMXBean
   val gcMx: List[GarbageCollectorMXBean] = ManagementFactory.getGarbageCollectorMXBeans.asScala.toList
-  val classLoaderMx: management.ClassLoadingMXBean = ManagementFactory.getClassLoadingMXBean
-  val compileMx: management.CompilationMXBean = ManagementFactory.getCompilationMXBean
+  val classLoaderMx: ClassLoadingMXBean = ManagementFactory.getClassLoadingMXBean
+  val compileMx: CompilationMXBean = ManagementFactory.getCompilationMXBean
   val threadMx: ExtendedThreadMxBean = ExtendedThreadMxBean.proxy
   if (threadMx.isThreadCpuTimeSupported) threadMx.setThreadCpuTimeEnabled(true)
   private val idGen = new AtomicInteger()

compiler/src/dotty/tools/dotc/sbt/ExtractAPI.scala

@@ -164,9 +164,9 @@ private class ExtractAPICollector(implicit val ctx: Context) extends ThunkHolder
     api.Annotated.of(tp, Array(marker))
   private def marker(name: String) =
     api.Annotation.of(api.Constant.of(Constants.emptyType, name), Array())
-  val orMarker: xsbti.api.Annotation = marker("Or")
-  val byNameMarker: xsbti.api.Annotation = marker("ByName")
-  val matchMarker: xsbti.api.Annotation = marker("Match")
+  private val orMarker = marker("Or")
+  private val byNameMarker = marker("ByName")
+  private val matchMarker = marker("Match")
 
   /** Extract the API representation of a source file */
   def apiSource(tree: Tree): Seq[api.ClassLike] = {

compiler/src/dotty/tools/dotc/transform/Erasure.scala

@@ -90,7 +90,7 @@ class Erasure extends Phase with DenotTransformer {
       ref.derivedSingleDenotation(ref.symbol, transformInfo(ref.symbol, ref.symbol.info))
   }
 
-  val eraser: Erasure.Typer = new Erasure.Typer(this)
+  private val eraser: Erasure.Typer = new Erasure.Typer(this)
 
   def run(implicit ctx: Context): Unit = {
     val unit = ctx.compilationUnit

compiler/src/dotty/tools/dotc/transform/FunctionalInterfaces.scala

@@ -23,8 +23,8 @@ class FunctionalInterfaces extends MiniPhase {
 
   def phaseName: String = FunctionalInterfaces.name
 
-  val functionName: TermName = "JFunction".toTermName
-  val functionPackage: TermName = "scala.compat.java8.".toTermName
+  private val functionName: TermName = "JFunction".toTermName
+  private val functionPackage: TermName = "scala.compat.java8.".toTermName
 
   override def transformClosure(tree: Closure)(implicit ctx: Context): Tree = {
     val cls = tree.tpe.widen.classSymbol.asClass

compiler/src/dotty/tools/dotc/transform/HoistSuperArgs.scala

@@ -55,7 +55,7 @@ class HoistSuperArgs extends MiniPhase with IdentityDenotTransformer { thisPhase
    *  Hoisted superarg methods are collected in `superArgDefs`
    */
   class Hoister(cls: Symbol)(implicit ctx: Context) {
-    val superArgDefs: mutable.ListBuffer[DefDef] = new mutable.ListBuffer[DefDef]
+    val superArgDefs: mutable.ListBuffer[DefDef] = new mutable.ListBuffer
 
     /** If argument is complex, hoist it out into its own method and refer to the
      *  method instead.