Skip to content

Commit 5093809

Browse files
Minor spacing & formating
1 parent b7cab2e commit 5093809

File tree

2 files changed

+18
-17
lines changed

2 files changed

+18
-17
lines changed

compiler/src/dotty/tools/dotc/ast/Desugar.scala

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -106,22 +106,23 @@ object desugar {
106106
def valDef(vdef: ValDef)(implicit ctx: Context): Tree = {
107107
val ValDef(name, tpt, rhs) = vdef
108108
val mods = vdef.mods
109-
def setterNeeded =
109+
val setterNeeded =
110110
(mods is Mutable) && ctx.owner.isClass && (!(mods is PrivateLocal) || (ctx.owner is Trait))
111111
if (setterNeeded) {
112-
// todo: copy of vdef as getter needed?
113-
// val getter = ValDef(mods, name, tpt, rhs) withPos vdef.pos ?
112+
// TODO: copy of vdef as getter needed?
113+
// val getter = ValDef(mods, name, tpt, rhs) withPos vdef.pos?
114114
// right now vdef maps via expandedTree to a thicket which concerns itself.
115115
// I don't see a problem with that but if there is one we can avoid it by making a copy here.
116116
val setterParam = makeSyntheticParameter(tpt = (new SetterParamTree).watching(vdef))
117+
// The rhs gets filled in later, when field is generated and getter has parameters (see Memoize miniphase)
117118
val setterRhs = if (vdef.rhs.isEmpty) EmptyTree else unitLiteral
118119
val setter = cpy.DefDef(vdef)(
119-
name = name.setterName,
120-
tparams = Nil,
120+
name = name.setterName,
121+
tparams = Nil,
121122
vparamss = (setterParam :: Nil) :: Nil,
122-
tpt = TypeTree(defn.UnitType),
123-
rhs = setterRhs
124-
).withMods((mods | Accessor) &~ CaseAccessor) // rhs gets filled in later, when field is generated and getter has parameters
123+
tpt = TypeTree(defn.UnitType),
124+
rhs = setterRhs
125+
).withMods((mods | Accessor) &~ CaseAccessor)
125126
Thicket(vdef, setter)
126127
}
127128
else vdef

compiler/src/dotty/tools/dotc/transform/Memoize.scala

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ import Decorators._
5050
if !ddef.symbol.is(Deferred) &&
5151
!ddef.symbol.isConstructor && // constructors bodies are added later at phase Constructors
5252
ddef.rhs == EmptyTree =>
53-
errorLackImplementation(ddef)
53+
errorLackImplementation(ddef)
5454
case tdef: TypeDef
5555
if tdef.symbol.isClass && !tdef.symbol.is(Deferred) && tdef.rhs == EmptyTree =>
5656
errorLackImplementation(tdef)
@@ -76,12 +76,12 @@ import Decorators._
7676

7777
ctx.newSymbol(
7878
owner = ctx.owner,
79-
name = sym.name.asTermName.fieldName,
79+
name = sym.name.asTermName.fieldName,
8080
flags = Private | (if (sym is Stable) EmptyFlags else Mutable),
81-
info = fieldType,
82-
coord = tree.pos)
83-
.withAnnotationsCarrying(sym, defn.FieldMetaAnnot)
84-
.enteredAfter(thisTransform)
81+
info = fieldType,
82+
coord = tree.pos
83+
).withAnnotationsCarrying(sym, defn.FieldMetaAnnot)
84+
.enteredAfter(thisTransform)
8585
}
8686

8787
/** Can be used to filter annotations on getters and setters; not used yet */
@@ -93,7 +93,7 @@ import Decorators._
9393

9494
lazy val field = sym.field.orElse(newField).asTerm
9595

96-
def adaptToField(tree: Tree) =
96+
def adaptToField(tree: Tree): Tree =
9797
if (tree.isEmpty) tree else tree.ensureConforms(field.info.widen)
9898

9999
val NoFieldNeeded = Lazy | Deferred | JavaDefined | (if (ctx.settings.YnoInline.value) EmptyFlags else Inline)
@@ -127,8 +127,8 @@ import Decorators._
127127
val getterDef = cpy.DefDef(tree)(rhs = getterRhs)
128128
Thicket(fieldDef, getterDef)
129129
} else if (sym.isSetter) {
130-
if (!sym.is(ParamAccessor)) { val Literal(Constant(())) = tree.rhs } // this is intended as an assertion
131-
field.setFlag(Mutable) // necessary for vals mixed in from Scala2 traits
130+
if (!sym.is(ParamAccessor)) { val Literal(Constant(())) = tree.rhs } // This is intended as an assertion
131+
field.setFlag(Mutable) // Necessary for vals mixed in from Scala2 traits
132132
if (isErasableBottomField(tree.vparamss.head.head.tpt.tpe.classSymbol)) tree
133133
else {
134134
val initializer = Assign(ref(field), adaptToField(ref(tree.vparamss.head.head.symbol)))

0 commit comments

Comments
 (0)