Better disambiguation to avoid MergeErrors

If there's a MergeError we now disambiguate following symbol preference. This is needed
to make new collections compile. Also, better error messages for those cases where a
MergeError is still emitted.

Author: odersky

compiler/src/dotty/tools/dotc/core/Denotations.scala

@@ -332,14 +332,20 @@ object Denotations {
     }
 
     /** Handle merge conflict by throwing a `MergeError` exception */
-    private def mergeConflict(tp1: Type, tp2: Type)(implicit ctx: Context): Type = {
+    private def mergeConflict(tp1: Type, tp2: Type, that: Denotation)(implicit ctx: Context): Type = {
+      def showSymbol(sym: Symbol): String = if (sym.exists) sym.showLocated else "[unknown]"
       def showType(tp: Type) = tp match {
         case ClassInfo(_, cls, _, _, _) => cls.showLocated
         case bounds: TypeBounds => i"type bounds $bounds"
         case _ => tp.show
       }
-      if (true) throw new MergeError(s"cannot merge ${showType(tp1)} with ${showType(tp2)}", tp1, tp2)
-      else throw new Error(s"cannot merge ${showType(tp1)} with ${showType(tp2)}") // flip condition for debugging
+      val msg =
+        s"""cannot merge
+           |  ${showSymbol(this.symbol)} of type ${showType(tp1)}  and
+           |  ${showSymbol(that.symbol)} of type ${showType(tp2)}
+           """
+      if (true) throw new MergeError(msg, tp1, tp2)
+      else throw new Error(msg) // flip condition for debugging
     }
 
     /** Merge parameter names of lambda types. If names in corresponding positions match, keep them,
@@ -389,13 +395,13 @@ object Denotations {
             tp2 match {
               case tp2: TypeBounds => if (safeIntersection) tp1 safe_& tp2 else tp1 & tp2
               case tp2: ClassInfo if tp1 contains tp2 => tp2
-              case _ => mergeConflict(tp1, tp2)
+              case _ => mergeConflict(tp1, tp2, that)
             }
           case tp1: ClassInfo =>
             tp2 match {
               case tp2: ClassInfo if tp1.cls eq tp2.cls => tp1.derivedClassInfo(tp1.prefix & tp2.prefix)
               case tp2: TypeBounds if tp2 contains tp1 => tp1
-              case _ => mergeConflict(tp1, tp2)
+              case _ => mergeConflict(tp1, tp2, that)
             }
           case tp1: MethodOrPoly =>
             tp2 match {
@@ -420,9 +426,9 @@ object Denotations {
                   tp1.derivedLambdaType(
                     mergeParamNames(tp1, tp2), tp1.paramInfos,
                     infoMeet(tp1.resultType, tp2.resultType.subst(tp2, tp1)))
-                else mergeConflict(tp1, tp2)
+                else mergeConflict(tp1, tp2, that)
               case _ =>
-                mergeConflict(tp1, tp2)
+                mergeConflict(tp1, tp2, that)
             }
           case _ =>
             tp1 & tp2
@@ -523,7 +529,9 @@ object Denotations {
               try infoMeet(info1, info2)
               catch {
                 case ex: MergeError =>
-                  if (pre.widen.classSymbol.is(Scala2x) || ctx.scala2Mode)
+                  if (preferSym(sym2, sym1)) info2
+                  else if (preferSym(sym1, sym2)) info1
+                  else if (pre.widen.classSymbol.is(Scala2x) || ctx.scala2Mode)
                     info1 // follow Scala2 linearization -
                   // compare with way merge is performed in SymDenotation#computeMembersNamed
                   else
@@ -560,13 +568,13 @@ object Denotations {
           tp2 match {
             case tp2: TypeBounds => tp1 | tp2
             case tp2: ClassInfo if tp1 contains tp2 => tp1
-            case _ => mergeConflict(tp1, tp2)
+            case _ => mergeConflict(tp1, tp2, that)
           }
         case tp1: ClassInfo =>
           tp2 match {
             case tp2: ClassInfo if tp1.cls eq tp2.cls => tp1.derivedClassInfo(tp1.prefix | tp2.prefix)
             case tp2: TypeBounds if tp2 contains tp1 => tp2
-            case _ => mergeConflict(tp1, tp2)
+            case _ => mergeConflict(tp1, tp2, that)
           }
         case tp1: MethodOrPoly =>
           tp2 match {
@@ -577,7 +585,7 @@ object Denotations {
                 mergeParamNames(tp1, tp2), tp1.paramInfos,
                 tp1.resultType | tp2.resultType.subst(tp2, tp1))
             case _ =>
-              mergeConflict(tp1, tp2)
+              mergeConflict(tp1, tp2, that)
           }
         case _ =>
           tp1 | tp2

vscode-dotty/test/extension.test.ts

@@ -12,10 +12,10 @@ import * as vscode from 'vscode';
 import * as dotty from '../src/extension';
 
 // Defines a Mocha test suite to group tests of similar kind together
-suite("vscode-dotty tests", function () {
+//suite("vscode-dotty tests", function () {
 
     // Defines a Mocha unit test
-    test("dummy test", function() {
-        assert.equal(1, 1)
-    });
-});
+//    test("dummy test", function() {
+//        assert.equal(1, 1)
+//    });
+//});