Merge pull request #5049 from dotty-staging/avoid-fishy-string-ne

liufengyun · web-flow · commit 3a5460b43487 · 2018-08-28T13:22:07.000+02:00
Fix #5046: Avoid fishy reference equality on strings
diff --git a/compiler/src/dotty/tools/dotc/core/Decorators.scala b/compiler/src/dotty/tools/dotc/core/Decorators.scala
@@ -157,7 +157,7 @@ object Decorators {
         names exists { name =>
           name == "all" || {
             val strippedName = name.stripSuffix("+")
-            val logNextPhase = name ne strippedName
+            val logNextPhase = name != strippedName
             phase.phaseName.startsWith(strippedName) ||
               (logNextPhase && phase.prev.phaseName.startsWith(strippedName))
           }

Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,7 @@ object Decorators {`
`157`	`157`	`names exists { name =>`
`158`	`158`	`name == "all" \|\| {`
`159`	`159`	`val strippedName = name.stripSuffix("+")`
`160`		`- val logNextPhase = name ne strippedName`
	`160`	`+ val logNextPhase = name != strippedName`
`161`	`161`	`phase.phaseName.startsWith(strippedName) \|\|`
`162`	`162`	`(logNextPhase && phase.prev.phaseName.startsWith(strippedName))`
`163`	`163`	`}`