Adapt to new reporting outside of compiler

Author: odersky

bench/src/main/scala/Benchmarks.scala

@@ -102,7 +102,7 @@ class Worker extends Driver {
       }
       catch {
         case ex: FatalError  =>
-          ctx.error(ex.getMessage) // signals that we should fail compilation.
+          report.error(ex.getMessage) // signals that we should fail compilation.
           ctx.reporter
       }
     else ctx.reporter

compiler/src/dotty/tools/dotc/core/Phases.scala

@@ -16,12 +16,6 @@ import Periods._
 import typer.{FrontEnd, RefChecks}
 import ast.tpd
 
-trait Phases {
-  self: Context =>
-
-  import Phases._
-}
-
 object Phases {
 
   inline def phaseOf(id: PhaseId)(using Context): Phase =

docs/docs/reference/changed-features/compiler-plugins.md

@@ -81,7 +81,7 @@ class DivideZeroPhase extends PluginPhase {
     tree match {
       case Apply(Select(rcvr, nme.DIV), List(Literal(Constant(0))))
           if rcvr.tpe <:< defn.IntType =>
-        ctx.error("dividing by zero", tree.pos)
+        report.error("dividing by zero", tree.pos)
       case _ =>
         ()
     }
@@ -90,7 +90,7 @@ class DivideZeroPhase extends PluginPhase {
 }
 ```
 
-The plugin main class (`DivideZero`) must extend the trait `StandardPlugin` 
+The plugin main class (`DivideZero`) must extend the trait `StandardPlugin`
 and implement the method `init` that takes the plugin's options as argument
 and returns a list of `PluginPhase`s to be inserted into the compilation pipeline.
 

docs/docs/reference/changed-features/numeric-literals.md

@@ -226,8 +226,7 @@ strings `fromDigitsImpl(digits)` is simply `apply(digits)`, i.e. everything is
 evaluated at runtime in this case.
 
 The interesting part is the `catch` part of the case where `digits` is constant.
-If the `apply` method throws a `FromDigitsException`, the exception's message is issued as a compile time error
-in the `ctx.error(ex.getMessage)` call.
+If the `apply` method throws a `FromDigitsException`, the exception's message is issued as a compile time error in the `ctx.error(ex.getMessage)` call.
 
 With this new implementation, a definition like
 ```scala

sbt-dotty/sbt-test/sbt-dotty/analyzer-plugin/plugin/Analyzer.scala

@@ -34,7 +34,7 @@ class InitChecker extends PluginPhase {
 
   private def checkDef(tree: Tree)(implicit ctx: Context): Tree = {
     if (tree.symbol.defTree.isEmpty)
-      ctx.error("cannot get tree for " + tree.show, tree.sourcePos)
+      report.error("cannot get tree for " + tree.show, tree.sourcePos)
     tree
   }
 
@@ -51,17 +51,17 @@ class InitChecker extends PluginPhase {
 
       if (enclosingPkg == helloPkgSym) {  // source code
         checkDef(tree)
-        ctx.warning("tree: " + tree.symbol.defTree.show)
+        report.warning("tree: " + tree.symbol.defTree.show)
       }
       else if (enclosingPkg == libPkgSym) { // tasty from library
         checkDef(tree)
         // check that all sub-definitions have trees set properly
         // make sure that are no cycles in the code
         transformAllDeep(tree.symbol.defTree)
-        ctx.warning("tree: " + tree.symbol.defTree.show)
+        report.warning("tree: " + tree.symbol.defTree.show)
       }
       else {
-        ctx.warning(s"${tree.symbol} is neither in lib nor hello, owner = $enclosingPkg", tree.sourcePos)
+        report.warning(s"${tree.symbol} is neither in lib nor hello, owner = $enclosingPkg", tree.sourcePos)
       }
       tree
     }

sbt-dotty/sbt-test/sbt-dotty/compiler-plugin/plugin/DivideZero.scala

@@ -33,7 +33,7 @@ class DivideZero extends PluginPhase with StandardPlugin {
 
   override def transformApply(tree: tpd.Apply)(implicit ctx: Context): tpd.Tree = tree match {
     case tpd.Apply(fun, tpd.Literal(Constants.Constant(v)) :: Nil) if isNumericDivide(fun.symbol) && v == 0 =>
-      ctx.error("divide by zero", tree.sourcePos)
+      report.error("divide by zero", tree.sourcePos)
       tpd.Literal(Constant(0))
     case _ =>
       tree