Skip to content

Commit 261374b

Browse files
committed
Change implied -> implicit in comments and error messages
1 parent 2bf8579 commit 261374b

File tree

10 files changed

+21
-21
lines changed

10 files changed

+21
-21
lines changed

compiler/src/dotty/tools/dotc/core/tasty/TastyFormat.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ Standard-Section: "ASTs" TopLevelStat*
5757
Stat = Term
5858
ValOrDefDef
5959
TYPEDEF Length NameRef (type_Term | Template) Modifier* -- modifiers type name (= type | bounds) | moifiers class name template
60-
IMPORT Length [IMPLIED] qual_Term Selector* -- import implied? qual selectors
60+
IMPORT Length [IMPLIED] qual_Term Selector* -- import implicit? qual selectors
6161
ValOrDefDef = VALDEF Length NameRef type_Term rhs_Term? Modifier* -- modifiers val name : type (= rhs)?
6262
DEFDEF Length NameRef TypeParam* Params* returnType_Term rhs_Term?
6363
Modifier* -- modifiers def name [typeparams] paramss : returnType (= rhs)?

compiler/src/dotty/tools/dotc/interactive/Completion.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ object Completion {
121121
if (buffer.mode != Mode.None) {
122122
path match {
123123
case Select(qual, _) :: _ => buffer.addMemberCompletions(qual)
124-
case Import(_, expr, _) :: _ => buffer.addMemberCompletions(expr) // TODO: distinguish implied from non-implied
124+
case Import(_, expr, _) :: _ => buffer.addMemberCompletions(expr) // TODO: distinguish implicit from non-implicit
125125
case (_: Thicket) :: Import(_, expr, _) :: _ => buffer.addMemberCompletions(expr)
126126
case _ => buffer.addScopeCompletions
127127
}

compiler/src/dotty/tools/dotc/printing/RefinedPrinter.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -504,7 +504,7 @@ class RefinedPrinter(_ctx: Context) extends PlainPrinter(_ctx) {
504504
case id :: Nil => toText(id)
505505
case _ => "{" ~ Text(selectors map selectorText, ", ") ~ "}"
506506
}
507-
keywordText("import ") ~ (keywordText("implied ") provided importImplied) ~
507+
keywordText("import ") ~ (keywordText("implicit ") provided importImplied) ~
508508
toTextLocal(expr) ~ "." ~ selectorsText
509509
case packageDef: PackageDef =>
510510
packageDefText(packageDef)

compiler/src/dotty/tools/dotc/typer/Applications.scala

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1350,22 +1350,22 @@ trait Applications extends Compatibility { self: Typer with Dynamic =>
13501350
(flip(tp1) relaxed_<:< flip(tp2)) || viewExists(tp1, tp2)
13511351
}
13521352

1353-
/** Widen the result type of synthetic implied methods from the implementation class to the
1353+
/** Widen the result type of synthetic implicit methods from the implementation class to the
13541354
* type that's implemented. Example
13551355
*
1356-
* implied I[X] for T { ... }
1356+
* implicit I[X] for T { ... }
13571357
*
13581358
* This desugars to
13591359
*
13601360
* class I[X] extends T { ... }
1361-
* implied def I[X]: I[X] = new I[X]
1361+
* implicit def I[X]: I[X] = new I[X]
13621362
*
13631363
* To compare specificity we should compare with `T`, not with its implementation `I[X]`.
1364-
* No such widening is performed for implied aliases, which are not synthetic. E.g.
1364+
* No such widening is performed for implicit aliases, which are not synthetic. E.g.
13651365
*
1366-
* implied J[X] for T = rhs
1366+
* implicit J[X] for T = rhs
13671367
*
1368-
* already has the right result type `T`. Neither is widening performed for implied
1368+
* already has the right result type `T`. Neither is widening performed for implicit
13691369
* objects, since these are anyway taken to be more specific than methods
13701370
* (by condition 3a above).
13711371
*/

compiler/src/dotty/tools/dotc/typer/Deriving.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ trait Deriving { this: Typer =>
247247
}
248248

249249
/** If any of the instances has a companion with a `derived` member
250-
* that refers to `scala.reflect.Generic`, add an implied instance
250+
* that refers to `scala.reflect.Generic`, add an implicit instance
251251
* of `Generic`. Note: this is just an optimization to avoid possible
252252
* code duplication. Generic instances are created on the fly if they
253253
* are missing from the companion.

compiler/src/dotty/tools/dotc/typer/Implicits.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -918,7 +918,7 @@ trait Implicits { self: Typer =>
918918
case fail: SearchFailureType =>
919919

920920
def hiddenImplicitNote(s: SearchSuccess) =
921-
em"\n\nNote: implied instance ${s.ref.symbol.showLocated} was not considered because it was not imported with an `import implied`."
921+
em"\n\nNote: implicit instance ${s.ref.symbol.showLocated} was not considered because it was not imported with an `import implicit`."
922922

923923
def FindHiddenImplicitsCtx(ctx: Context): Context =
924924
if (ctx == NoContext) ctx

compiler/src/dotty/tools/dotc/typer/ImportInfo.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ object ImportInfo {
2626
* @param selectors The selector clauses
2727
* @param symNameOpt Optionally, the name of the import symbol. None for root imports.
2828
* Defined for all explicit imports from ident or select nodes.
29-
* @param importImplied true if this is an implied import
29+
* @param importImplied true if this is an implicit import
3030
* @param isRootImport true if this is one of the implicit imports of scala, java.lang,
3131
* scala.Predef or dotty.DottyPredef in the start context, false otherwise.
3232
*/

library/src/scala/Eql.scala

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ sealed trait Eql[-L, -R]
1212
* the compiler (see Implicits.synthesizedEq), so they are not included here.
1313
*/
1414
object Eql {
15-
/** A non-implied universal `Eql` instance. */
15+
/** A non-implicit universal `Eql` instance. */
1616
object derived extends Eql[Any, Any]
1717

1818
/** A fall-back instance to compare values of any types.
19-
* Even though this method is not declared implied, the compiler will
20-
* compute implied instances as solutions to `Eql[T, U]` queries if
19+
* Even though this method is not declared implicit, the compiler will
20+
* compute implicit instances as solutions to `Eql[T, U]` queries if
2121
* the rules of multiversal equality require it.
2222
*/
2323
def eqlAny[L, R]: Eql[L, R] = derived

library/src/scala/tasty/reflect/Printers.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -554,7 +554,7 @@ trait Printers
554554

555555
case Import(importImplied, expr, selectors) =>
556556
this += "import "
557-
if (importImplied) this += "implied "
557+
if (importImplied) this += "implied "// FIXME: change to "implicit "
558558
printTree(expr)
559559
this += "."
560560
printImportSelectors(selectors)

library/src/scalaShadowing/language.scala

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ object language {
107107
* }}}
108108
*
109109
* Implicit values of other types are not affected, and neither are implicit
110-
* classes. In particular, implied instances of the scala.Conversion class can be
110+
* classes. In particular, implicit instances of the scala.Conversion class can be
111111
* defined without having to import the language feature.
112112
*
113113
* The language import is also required to enable _uses_ of implicit conversions
@@ -119,13 +119,13 @@ object language {
119119
* class A
120120
* class B
121121
* object B {
122-
* implied a2b for Conversion[A, B] { ... }
122+
* implicit a2b for Conversion[A, B] { ... }
123123
* }
124124
* object C {
125-
* implied b2a for Conversion[B, A] { ... }
125+
* implicit b2a for Conversion[B, A] { ... }
126126
* }
127-
* import implied B._
128-
* import implied C._
127+
* import implicit B._
128+
* import implicit C._
129129
* val x: A = new B // language import required
130130
* val x: B = new A // no import necessary since a2b is co-defined with B
131131
* }}}

0 commit comments

Comments
 (0)