Skip to content

Commit 21a53da

Browse files
committed
Speed up LazyVals isCompanion needed
Brings time to compile stdlib down from 185s to 44s.
1 parent 0e21000 commit 21a53da

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/dotty/tools/dotc/core/Types.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -609,7 +609,7 @@ object Types {
609609
(name, buf) => buf ++= member(name).altsWith(x => !x.is(Method)))
610610
}
611611

612-
/** The set of members of this type having at least one of `requiredFlags` but none of `excludedFlags` set */
612+
/** The set of members of this type having at least one of `requiredFlags` but none of `excludedFlags` set */
613613
final def membersBasedOnFlags(requiredFlags: FlagSet, excludedFlags: FlagSet)(implicit ctx: Context): Seq[SingleDenotation] = track("implicitMembers") {
614614
memberDenots(takeAllFilter,
615615
(name, buf) => buf ++= member(name).altsWith(x => x.is(requiredFlags, butNot = excludedFlags)))

src/dotty/tools/dotc/transform/LazyVals.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ class LazyVals extends MiniPhaseTransform with IdentityDenotTransformer with Nee
4848
override def runsAfter = Set(classOf[Mixin])
4949

5050
def isCompanionNeeded(cls: ClassSymbol)(implicit ctx: Context): Boolean = {
51-
def hasLazyVal(x: ClassSymbol) = x.classInfo.membersBasedOnFlags(Flags.Lazy, excludedFlags = Flags.EmptyFlags).nonEmpty
51+
def hasLazyVal(cls: ClassSymbol) = cls.info.decls.exists(_.is(Flags.Lazy))
5252
hasLazyVal(cls) || cls.mixins.exists(hasLazyVal)
5353
}
5454

0 commit comments

Comments
 (0)