Simplify ClassfileParser#innerClasses#classSymbol

- Avoid redundant calls to get
- Fix indentation of getMember and add some brackets to make it clearer

Author: smarter

compiler/src/dotty/tools/dotc/core/classfile/ClassfileParser.scala

@@ -106,7 +106,7 @@ class ClassfileParser(
 
   /** Return the class symbol of the given name. */
   def classNameToSymbol(name: Name)(implicit ctx: Context): Symbol = innerClasses.get(name) match {
-    case Some(entry) => innerClasses.classSymbol(entry.externalName)
+    case Some(entry) => innerClasses.classSymbol(entry)
     case None => ctx.requiredClass(name)
   }
 
@@ -890,54 +890,42 @@ class ClassfileParser(
       classNameToSymbol(tlName)
     }
 
-    /** Return the class symbol for `externalName`. It looks it up in its outer class.
+    /** Return the class symbol for `entry`. It looks it up in its outer class.
      *  Forces all outer class symbols to be completed.
-     *
-     *  If the given name is not an inner class, it returns the symbol found in `defn`.
      */
-    def classSymbol(externalName: Name)(implicit ctx: Context): Symbol = {
-      /** Return the symbol of `innerName`, having the given `externalName`. */
-      def innerSymbol(externalName: Name, innerName: Name, static: Boolean): Symbol = {
-        def getMember(sym: Symbol, name: Name)(implicit ctx: Context): Symbol =
-          if (static)
-            if (sym == classRoot.symbol) staticScope.lookup(name)
-            else {
-              var module = sym.companionModule
-              if (!module.exists && sym.isAbsent)
-                module = sym.scalacLinkedClass
-              module.info.member(name).symbol
-            }
+    def classSymbol(entry: InnerClassEntry)(implicit ctx: Context): Symbol = {
+      def getMember(sym: Symbol, name: Name)(implicit ctx: Context): Symbol =
+        if (isStatic(entry.jflags)) {
+          if (sym == classRoot.symbol)
+            staticScope.lookup(name)
+          else {
+            var module = sym.companionModule
+            if (!module.exists && sym.isAbsent)
+              module = sym.scalacLinkedClass
+            module.info.member(name).symbol
+          }
+        }
+        else {
+          if (sym == classRoot.symbol)
+            instanceScope.lookup(name)
           else
-            if (sym == classRoot.symbol) instanceScope.lookup(name)
-            else sym.info.member(name).symbol
-
-        innerClasses.get(externalName) match {
-          case Some(entry) =>
-            val outerName = entry.outerName.stripModuleClassSuffix
-            val owner = classSymbol(outerName)
-            val result = ctx.atPhaseNotLaterThan(ctx.typerPhase) { implicit ctx =>
-              getMember(owner, innerName.toTypeName)
-            }
-            assert(result ne NoSymbol,
-              i"""failure to resolve inner class:
-                 |externalName = $externalName,
+            sym.info.member(name).symbol
+        }
+
+      val outerName = entry.outerName.stripModuleClassSuffix
+      val innerName = entry.originalName
+      val owner = classNameToSymbol(outerName)
+      val result = ctx.atPhaseNotLaterThan(ctx.typerPhase) { implicit ctx =>
+        getMember(owner, innerName.toTypeName)
+      }
+      assert(result ne NoSymbol,
+        i"""failure to resolve inner class:
+                 |externalName = ${entry.externalName},
                  |outerName = $outerName,
                  |innerName = $innerName
                  |owner.fullName = ${owner.showFullName}
                  |while parsing ${classfile}""")
-            result
-
-          case None =>
-            classNameToSymbol(externalName)
-        }
-      }
-
-      get(externalName) match {
-        case Some(entry) =>
-          innerSymbol(entry.externalName, entry.originalName, isStatic(entry.jflags))
-        case None =>
-          classNameToSymbol(externalName)
-      }
+      result
     }
   }