Made TypeVars uncahable keys

TypeVars can appear as keys in baseType caches. The problem is that
their base types depend on their instantiation, which is not always
know yet when the test is performed. So results of baseType on
type variables should never be cached.

Todo: check whether there are any other caching problems involving typevars.

Author: odersky

src/dotty/tools/dotc/core/SymDenotations.scala

@@ -1326,6 +1326,9 @@ object SymDenotations {
               case _ =>
                 baseTypeRefOf(tp.underlying)
             }
+          case tp: TypeVar =>
+            if (tp.inst.exists) computeBaseTypeRefOf(tp.inst)
+            else Uncachable(computeBaseTypeRefOf(tp.underlying))
           case tp: TypeProxy =>
             baseTypeRefOf(tp.underlying)
           case AndType(tp1, tp2) =>
@@ -1346,8 +1349,14 @@ object SymDenotations {
             var basetp = baseTypeRefCache get tp
             if (basetp == null) {
               baseTypeRefCache.put(tp, NoPrefix)
-              basetp = computeBaseTypeRefOf(tp)
-              baseTypeRefCache.put(tp, basetp)
+              basetp = computeBaseTypeRefOf(tp) match {
+                case Uncachable(basetp) =>
+                  baseTypeRefCache.remove(tp)
+                  basetp
+                case basetp =>
+                  baseTypeRefCache.put(tp, basetp)
+                  basetp
+              }
             } else if (basetp == NoPrefix) {
               throw CyclicReference(this)
             }
@@ -1427,7 +1436,9 @@ object SymDenotations {
           copySymDenotation(info = ClassInfo(pre, classSymbol, ps, decls.cloneScope, selfInfo))
             .installAfter(phase)
       }
-    }
+  }
+
+  private case class Uncachable(tp: Type) extends UncachedGroundType
 
   /** The denotation of a package class.
    *  It overrides ClassDenotation to take account of package objects when looking for members