Add missing Case flag on Scala 2 library unapply

Author: nicolasstucki

.github/workflows/ci.yaml

@@ -143,7 +143,7 @@ jobs:
           ./project/scripts/sbt ";sjsSandbox/run ;sjsSandbox/test ;sjsJUnitTests/test ;set sjsJUnitTests/scalaJSLinkerConfig ~= switchToESModules ;sjsJUnitTests/test ;sjsCompilerTests/test"
 
       - name: Test with Scala 2 library TASTy (fast)
-        run: ./project/scripts/sbt ";set ThisBuild/Build.useScala2LibraryTasty := true ;scala3-bootstrapped/testCompilation i5" # only test a subset of test to avoid doubling the CI execution time
+        run: ./project/scripts/sbt ";set ThisBuild/Build.useScala2LibraryTasty := true ;scala3-bootstrapped/testCompilation i5; scala3-bootstrapped/testCompilation tests/run/typelevel-peano.scala; scala3-bootstrapped/testOnly dotty.tools.backend.jvm.DottyBytecodeTests" # only test a subset of test to avoid doubling the CI execution time
 
 
   test_scala2_library_tasty:

compiler/src/dotty/tools/dotc/ast/Desugar.scala

@@ -805,13 +805,16 @@ object desugar {
             else if caseClassInScala2Library then scala2LibCompatUnapplyRhs(unapplyParam.name)
             else Ident(unapplyParam.name)
           val unapplyResTp = if (arity == 0) Literal(Constant(true)) else TypeTree()
+          val unapplyMods =
+            if ctx.settings.YcompileScala2Library.value then synthetic | Case
+            else synthetic
 
           DefDef(
             methName,
             joinParams(derivedTparams, (unapplyParam :: Nil) :: Nil),
             unapplyResTp,
             unapplyRHS
-          ).withMods(synthetic)
+          ).withMods(unapplyMods)
         }
         val toStringMeth =
           DefDef(nme.toString_, Nil, TypeTree(), Literal(Constant(className.toString))).withMods(Modifiers(Override | Synthetic))

compiler/test/dotty/tools/backend/jvm/DottyBytecodeTests.scala

@@ -1058,7 +1058,7 @@ class DottyBytecodeTests extends DottyBytecodeTest {
         TypeOp(CHECKCAST, "scala/collection/immutable/$colon$colon"),
         VarOp(ASTORE, 3),
         VarOp(ALOAD, 3),
-        Invoke(INVOKEVIRTUAL, "scala/collection/immutable/$colon$colon", "next$access$1", "()Lscala/collection/immutable/List;", false),
+        Invoke(INVOKEVIRTUAL, "scala/collection/immutable/$colon$colon", "next", "()Lscala/collection/immutable/List;", false),
         VarOp(ASTORE, 4),
         VarOp(ALOAD, 3),
         Invoke(INVOKEVIRTUAL, "scala/collection/immutable/$colon$colon", "head", "()Ljava/lang/Object;", false),
@@ -1112,7 +1112,7 @@ class DottyBytecodeTests extends DottyBytecodeTest {
         Invoke(INVOKESTATIC, "scala/runtime/BoxesRunTime", "unboxToInt", "(Ljava/lang/Object;)I", false),
         VarOp(ISTORE, 4),
         VarOp(ALOAD, 3),
-        Invoke(INVOKEVIRTUAL, "scala/collection/immutable/$colon$colon", "next$access$1", "()Lscala/collection/immutable/List;", false),
+        Invoke(INVOKEVIRTUAL, "scala/collection/immutable/$colon$colon", "next", "()Lscala/collection/immutable/List;", false),
         VarOp(ASTORE, 5),
         Op(ICONST_1),
         VarOp(ILOAD, 4),