Address review

Author: liufengyun

compiler/src/dotty/tools/dotc/tastyreflect/SymbolOpsImpl.scala

@@ -80,6 +80,9 @@ trait SymbolOpsImpl extends scala.tasty.reflect.SymbolOps with CoreImpl {
       symbol.topLevelClass.asClass.isDefinedInCurrentRun
     }
 
+    def isType(implicit ctx: Context): Boolean = symbol.isType
+
+    def isTerm(implicit ctx: Context): Boolean = symbol.isTerm
   }
 
   object IsPackageSymbol extends IsPackageSymbolModule {

library/src/scala/quoted/Toolbox.scala

@@ -33,7 +33,7 @@ object Toolbox {
   }
 
   /** Setting of the Toolbox instance. */
-  case class Settings private (val outDir: Option[String], val showRawTree: Boolean, val compilerArgs: List[String], val color: Boolean)
+  case class Settings private (outDir: Option[String], showRawTree: Boolean, compilerArgs: List[String], color: Boolean)
 
   object Settings {
 

library/src/scala/tasty/reflect/Printers.scala

@@ -1367,7 +1367,7 @@ trait Printers
             case tpe @ Type.SymRef(IsClassSymbol(sym), _) if sym.name.endsWith("$") =>
               printType(tpe)
               this += ".type"
-            case tpe @ Type.SymRef(sym, _) if !IsTypeSymbol.unapply(sym).nonEmpty =>
+            case tpe @ Type.SymRef(sym, _) if sym.isTerm =>
               printType(tpe)
               this += ".type"
             case tpe => printType(tpe)
@@ -1462,7 +1462,7 @@ trait Printers
         case Type.ConstantType(const) =>
           printConstant(const)
 
-        case Type.SymRef(sym, prefix) if IsTypeSymbol.unapply(sym).nonEmpty =>
+        case Type.SymRef(sym, prefix) if sym.isType =>
           prefix match {
             case Types.EmptyPrefix() =>
             case IsType(prefix @ Type.SymRef(IsClassSymbol(_), _)) =>
@@ -1474,7 +1474,7 @@ trait Printers
           }
           this += highlightTypeDef(sym.name.stripSuffix("$"), color)
 
-        case Type.SymRef(sym, prefix) if !IsTypeSymbol.unapply(sym).nonEmpty =>
+        case Type.SymRef(sym, prefix) if sym.isTerm =>
           prefix match {
             case Types.EmptyPrefix() =>
                 this += highlightTypeDef(sym.name, color)

library/src/scala/tasty/reflect/SymbolOps.scala

@@ -52,6 +52,10 @@ trait SymbolOps extends Core {
     def annots(implicit ctx: Context): List[Term]
 
     def isDefinedInCurrentRun(implicit ctx: Context): Boolean
+
+    def isType(implicit ctx: Context): Boolean
+
+    def isTerm(implicit ctx: Context): Boolean
   }
   implicit def SymbolDeco(symbol: Symbol): SymbolAPI
 

tests/pos/i2104b.decompiled

@@ -13,13 +13,13 @@ case class Pair[A, B](_1: A, _2: B) {
     scala.runtime.Statics.finalizeHash(acc, 2)
   }
   override def equals(x$0: scala.Any): scala.Boolean = Pair.this.eq(x$0.asInstanceOf[java.lang.Object]).||(x$0 match {
-    case x$0: Pair[A, B] @scala.unchecked =>
+    case x$0: Pair[Pair.this.A, Pair.this.B] @scala.unchecked =>
       Pair.this._1.==(x$0._1).&&(Pair.this._2.==(x$0._2))
     case _ =>
       false
   })
   override def toString(): java.lang.String = scala.runtime.ScalaRunTime._toString(Pair.this)
-  override def canEqual(that: scala.Any): scala.Boolean = that.isInstanceOf[Pair[A, B] @scala.unchecked]
+  override def canEqual(that: scala.Any): scala.Boolean = that.isInstanceOf[Pair[Pair.this.A, Pair.this.B] @scala.unchecked]
   override def productArity: scala.Int = 2
   override def productPrefix: java.lang.String = "Pair"
   override def productElement(n: scala.Int): scala.Any = n match {

tests/pos/simpleCaseClass-3.decompiled

@@ -6,13 +6,13 @@ case class A[T](x: T) {
     scala.runtime.Statics.finalizeHash(acc, 1)
   }
   override def equals(x$0: scala.Any): scala.Boolean = A.this.eq(x$0.asInstanceOf[java.lang.Object]).||(x$0 match {
-    case x$0: A[T] @scala.unchecked =>
+    case x$0: A[A.this.T] @scala.unchecked =>
       A.this.x.==(x$0.x)
     case _ =>
       false
   })
   override def toString(): java.lang.String = scala.runtime.ScalaRunTime._toString(A.this)
-  override def canEqual(that: scala.Any): scala.Boolean = that.isInstanceOf[A[T] @scala.unchecked]
+  override def canEqual(that: scala.Any): scala.Boolean = that.isInstanceOf[A[A.this.T] @scala.unchecked]
   override def productArity: scala.Int = 1
   override def productPrefix: java.lang.String = "A"
   override def productElement(n: scala.Int): scala.Any = n match {