Run all phases in last group at group end

Author: odersky

compiler/src/dotty/tools/backend/jvm/CollectSuperCalls.scala

@@ -22,6 +22,9 @@ class CollectSuperCalls extends MiniPhaseTransform {
 
   def phaseName: String = "collectSuperCalls"
 
+  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
+    groupEndPhase
+
   override def transformSelect(tree: Select)(implicit ctx: Context, info: TransformerInfo): Tree = {
     tree.qualifier match {
       case sup: Super =>

compiler/src/dotty/tools/backend/jvm/LabelDefs.scala

@@ -88,6 +88,9 @@ class LabelDefs extends MiniPhaseTransform {
   val beingAppended = new mutable.HashSet[Symbol]()
   var labelLevel = 0
 
+  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
+    groupEndPhase
+
   override def transformDefDef(tree: tpd.DefDef)(implicit ctx: Context, info: TransformerInfo): tpd.Tree = {
     if (tree.symbol is Flags.Label) tree
     else {

compiler/src/dotty/tools/dotc/transform/CollectEntryPoints.scala

@@ -24,6 +24,9 @@ import dotty.tools.dotc.config.JavaPlatform
 
 class CollectEntryPoints extends MiniPhaseTransform {
 
+  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
+    groupEndPhase
+
   /** perform context-dependant initialization */
   override def prepareForUnit(tree: tpd.Tree)(implicit ctx: Context) = {
     entryPoints = collection.immutable.TreeSet.empty[Symbol](new SymbolOrdering())

compiler/src/dotty/tools/dotc/transform/DropInlined.scala

@@ -10,6 +10,9 @@ class DropInlined extends MiniPhaseTransform {
   import ast.tpd._
   override def phaseName = "dropInlined"
 
+  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
+    groupEndPhase
+
   override def transformInlined(tree: Inlined)(implicit ctx: Context, info: TransformerInfo): Tree =
     Inliner.dropInlined(tree)
 }

compiler/src/dotty/tools/dotc/transform/ExpandPrivate.scala

@@ -25,7 +25,7 @@ import dotty.tools.dotc.core.Phases.Phase
 /** Make private term members that are accessed from another class
  *  non-private by resetting the Private flag and expanding their name.
  *
- *  Make private accessor in value class not-private. Ihis is necessary to unbox
+ *  Make private accessor in value class not-private. This is necessary to unbox
  *  the value class when accessing it from separate compilation units
  *
  *  Also, make non-private any private parameter forwarders that forward to an inherited
@@ -41,6 +41,9 @@ class ExpandPrivate extends MiniPhaseTransform with IdentityDenotTransformer { t
 
   override def phaseName: String = "expandPrivate"
 
+  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
+    groupEndPhase
+
   // This phase moves methods around (in infotransform) so it may need to make other methods public
   override def runsAfter: Set[Class[_ <: Phase]] = Set(classOf[MoveStatics])
 

compiler/src/dotty/tools/dotc/transform/MoveStatics.scala

@@ -21,6 +21,9 @@ class MoveStatics extends MiniPhaseTransform with SymTransformer { thisTransform
   import tpd._
   override def phaseName = "moveStatic"
 
+  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
+    groupEndPhase
+
   def transformSym(sym: SymDenotation)(implicit ctx: Context): SymDenotation = {
     if (sym.hasAnnotation(defn.ScalaStaticAnnot) && sym.owner.is(Flags.Module) && sym.owner.companionClass.exists) {
       sym.owner.asClass.delete(sym.symbol)

compiler/src/dotty/tools/dotc/transform/RenameLifted.scala

@@ -9,7 +9,7 @@ import dotty.tools.dotc.core.Names._
 import dotty.tools.dotc.core.Phases
 import dotty.tools.dotc.core.SymDenotations.SymDenotation
 import dotty.tools.dotc.core.Symbols._
-import dotty.tools.dotc.transform.TreeTransforms.MiniPhaseTransform
+import dotty.tools.dotc.transform.TreeTransforms.{MiniPhaseTransform, TransformerInfo}
 
 /** Renames lifted classes to local numbering scheme */
 class RenameLifted extends MiniPhaseTransform with SymTransformer { thisTransformer =>
@@ -18,6 +18,9 @@ class RenameLifted extends MiniPhaseTransform with SymTransformer { thisTransfor
 
   override def runsAfterGroupsOf: Set[Class[_ <: Phases.Phase]] = Set(classOf[RestoreScopes])
 
+  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
+    groupEndPhase
+
   def transformSym(ref: SymDenotation)(implicit ctx: Context): SymDenotation =
     if (needsRefresh(ref.symbol)) ref.copySymDenotation(name = refreshedName(ref.symbol))
     else ref

compiler/src/dotty/tools/dotc/transform/SelectStatic.scala

@@ -20,6 +20,9 @@ class SelectStatic extends MiniPhaseTransform with IdentityDenotTransformer { th
 
   override def phaseName: String = "selectStatic"
 
+  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
+    groupEndPhase
+
   override def transformSelect(tree: tpd.Select)(implicit ctx: Context, info: TransformerInfo): tpd.Tree = {
     val sym = tree.symbol
     def isStaticMember =

compiler/src/dotty/tools/dotc/transform/TransformWildcards.scala

@@ -16,6 +16,9 @@ class TransformWildcards extends MiniPhaseTransform with IdentityDenotTransforme
 
   override def phaseName = "transformWildcards"
 
+  override def treeTransformPhase(implicit ctx: Context, info: TransformerInfo) =
+    groupEndPhase
+
   override def checkPostCondition(tree: Tree)(implicit ctx: Context): Unit = {
     tree match {
       case vDef: ValDef => assert(!tpd.isWildcardArg(vDef.rhs))