Fix #9772: Normalize value definitions

* Restrict names for mutable values which lead to setter generation during desugaring

Author: tudorv91

compiler/src/dotty/tools/dotc/ast/Desugar.scala

@@ -165,6 +165,7 @@ object desugar {
       && ctx.owner.isClass
       && (!mods.is(Private) || ctx.owner.is(Trait) || ctx.owner.isPackageObject)
     if (setterNeeded) {
+      val valName = normalizeName(vdef, tpt).asTermName
       // TODO: copy of vdef as getter needed?
       // val getter = ValDef(mods, name, tpt, rhs) withPos vdef.pos?
       // right now vdef maps via expandedTree to a thicket which concerns itself.
@@ -173,7 +174,7 @@ object desugar {
       // The rhs gets filled in later, when field is generated and getter has parameters (see Memoize miniphase)
       val setterRhs = if (vdef.rhs.isEmpty) EmptyTree else unitLiteral
       val setter = cpy.DefDef(vdef)(
-        name     = name.setterName,
+        name     = valName.setterName,
         tparams  = Nil,
         vparamss = (setterParam :: Nil) :: Nil,
         tpt      = TypeTree(defn.UnitType),
@@ -933,8 +934,13 @@ object desugar {
       report.error(IllegalRedefinitionOfStandardKind(kind, name), errPos)
       name = name.errorName
     }
-    if name.isExtensionName && (!mdef.mods.is(ExtensionMethod) || name.dropExtension.isExtensionName) then
-      report.error(em"illegal method name: $name may not start with `extension_`", errPos)
+    mdef match {
+      case vdef: ValDef if name.isExtension && vdef.mods.is(Mutable) =>
+        report.error(em"illegal variable name: `extension`", errPos)
+      case memDef if name.isExtensionName && (!mdef.mods.is(ExtensionMethod) || name.dropExtension.isExtensionName) =>
+        report.error(em"illegal name: $name may not start with `extension_`", errPos)
+      case _ =>
+    }
     name
   }
 

tests/neg/illegal-extension.check

@@ -0,0 +1,8 @@
+-- Error: tests/neg/illegal-extension.scala:2:6 ------------------------------------------------------------------------
+2 |  def extension_n: String = "illegal method" // error: illegal method name: extension_n may not start with `extension_`
+  |      ^^^^^^^^^^^
+  |      illegal method name: extension_n may not start with `extension_`
+-- Error: tests/neg/illegal-extension.scala:4:6 ------------------------------------------------------------------------
+4 |  var extension_val = 23 // error: illegal value name: extension_val may not start with `extension_`
+  |      ^^^^^^^^^^^^^
+  |      illegal value name: extension_val may not start with `extension_`

tests/neg/illegal-extension.scala

@@ -1,5 +1,11 @@
 trait A {
   def extension_n: String = "illegal method" // error: illegal method name: extension_n may not start with `extension_`
+  type extension_type = Int
+  var extension_val = 23 // error: illegal value name: extension_val may not start with `extension_`
+  val extension_private = "good" // allowed because it's immutable
 }
 
 extension (x: Any) def extension_foo: String = "foo" // error: illegal method name: extension_foo may not start with `extension_`
+class B {
+  private var extension_private_var = "good" // allowed because the owner is a class
+}