list-view selection items is read only

Author: Sciss

src/main/scala/scala/swing/ListView.scala

@@ -12,6 +12,8 @@ import event._
 import javax.swing._
 import javax.swing.event._
 
+import scala.collection.JavaConverters.asScalaBufferConverter
+
 object ListView {
   /**
    * The supported modes of user selections.
@@ -185,27 +187,23 @@ class ListView[A] extends Component {
       def iterator: Iterator[B] = a.iterator
     }
 
-    def leadIndex: Int = peer.getSelectionModel.getLeadSelectionIndex
-    def anchorIndex: Int = peer.getSelectionModel.getAnchorSelectionIndex
+    def leadIndex   : Int = peer.getSelectionModel.getLeadSelectionIndex
+    def anchorIndex : Int = peer.getSelectionModel.getAnchorSelectionIndex
 
     /**
      * The indices of the currently selected items.
      */
     object indices extends Indices(peer.getSelectedIndices) {
-      override def subtractOne(n: Int): this.type = { peer.removeSelectionInterval(n,n); this }
       override def addOne     (n: Int): this.type = { peer.addSelectionInterval   (n,n); this }
+      override def subtractOne(n: Int): this.type = { peer.removeSelectionInterval(n,n); this }
 
       override def clear(): Unit = peer.clearSelection()
     }
 
-// XXX TODO
-//    /**
-//     * The currently selected items.
-//     */
-//    object items extends scala.collection.SeqProxy[A] {
-//      def self = peer.getSelectedValues.map(_.asInstanceOf[A])
-//    }
-    def items: Seq[A] = ???
+    /**
+     * The currently selected items.
+     */
+    def items: Seq[A] = peer.getSelectedValuesList.asScala
 
     def intervalMode: IntervalMode.Value = IntervalMode(peer.getSelectionModel.getSelectionMode)
     def intervalMode_=(m: IntervalMode.Value): Unit = peer.getSelectionModel.setSelectionMode(m.id)

src/main/scala/scala/swing/Swing.scala

@@ -19,10 +19,10 @@ import javax.swing.{BorderFactory, Icon, ImageIcon, JComponent, SwingUtilities}
  * Helpers for this package.
  */
 object Swing {
-  protected[swing] type PeerContainer = {def peer: awt.Container}
+  protected[swing] type PeerContainer = { def peer: awt.Container }
 
-  protected[swing] def toNoIcon(i: Icon): Icon = if(i == null) EmptyIcon else i
-  protected[swing] def toNullIcon(i: Icon): Icon = if(i == EmptyIcon) null else i
+  protected[swing] def toNoIcon   (i: Icon): Icon = if (i == null) EmptyIcon else i
+  protected[swing] def toNullIcon (i: Icon): Icon = if (i == EmptyIcon) null else i
   protected[swing] def nullPeer(c: PeerContainer): awt.Container = if (c != null) c.peer else null
 
   implicit def pair2Dimension(p: (Int, Int))          : Dimension = new Dimension (p._1, p._2)
@@ -76,7 +76,7 @@ object Swing {
   }
 
   def unwrapIcon(icon: Icon): Icon = if (icon == null) EmptyIcon else icon
-  def wrapIcon(icon: Icon): Icon = if (icon == EmptyIcon) null else icon
+  def wrapIcon  (icon: Icon): Icon = if (icon == EmptyIcon) null else icon
 
   def EmptyBorder: Border = BorderFactory.createEmptyBorder()
   def EmptyBorder(weight: Int): Border  =