Merge pull request #506 from SethTisue/enabled-unused-warnings

Author: SethTisue

build.sbt

@@ -1,13 +1,14 @@
 ThisBuild / licenses += (("Apache-2.0", url("https://www.apache.org/licenses/LICENSE-2.0")))
 ThisBuild / startYear := Some(2004)
 
-// I thought we could declare these in `ThisBuild` scope but no :-/
 val commonSettings = Seq(
   versionScheme := Some("early-semver"),
   // next version will bump minor (because we dropped Scala 2.11 and upgraded
   // Scala.js and Scala Native); we could go back to BinaryAndSourceCompatible
   // once that's done
   versionPolicyIntention := Compatibility.BinaryCompatible,
+  crossScalaVersions := Seq("2.13.10", "2.12.17", "3.2.2"),
+  scalaVersion := crossScalaVersions.value.head,
 )
 
 lazy val root = project.in(file("."))
@@ -25,9 +26,6 @@ lazy val parserCombinators = crossProject(JVMPlatform, JSPlatform, NativePlatfor
     name := "scala-parser-combinators",
     scalaModuleAutomaticModuleName := Some("scala.util.parsing"),
 
-    crossScalaVersions := Seq("2.13.10", "2.12.17", "3.2.2"),
-    scalaVersion := crossScalaVersions.value.head,
-
     libraryDependencies += "junit" % "junit" % "4.13.2" % Test,
     libraryDependencies += "com.github.sbt" % "junit-interface" % "0.13.3" % Test,
 
@@ -38,7 +36,7 @@ lazy val parserCombinators = crossProject(JVMPlatform, JSPlatform, NativePlatfor
 
     // go nearly warning-free, but only on 2.13, it's too hard across all versions
     Compile / scalacOptions ++= (CrossVersion.partialVersion(scalaVersion.value) match {
-      case Some((2, 13)) => Seq("-Werror",
+      case Some((2, 13)) => Seq("-Werror", "-Wunused",
         // ideally we'd do something about this. `^?` is the responsible method
         "-Wconf:site=scala.util.parsing.combinator.Parsers.*&cat=lint-multiarg-infix:i",
         // not sure what resolving this would look like? didn't think about it too hard

shared/src/main/scala/scala/util/parsing/combinator/PackratParsers.scala

@@ -208,14 +208,14 @@ to update each parser involved in the recursion.
 
   private def lrAnswer[T](p: Parser[T], in: PackratReader[Elem], growable: LR): ParseResult[T] = growable match {
     //growable will always be having a head, we can't enter lrAnswer otherwise
-    case LR(seed ,rule, Some(head)) =>
+    case LR(seed, _, Some(head)) =>
       if(head.getHead != p) /*not head rule, so not growing*/ seed.asInstanceOf[ParseResult[T]]
       else {
         in.updateCacheAndGet(p, MemoEntry(Right(seed.asInstanceOf[ParseResult[T]])))
         seed match {
           case f@Failure(_,_) => f
           case e@Error(_,_) => e
-          case s@Success(_,_) => /*growing*/ grow(p, in, head)
+          case Success(_,_) => /*growing*/ grow(p, in, head)
         }
       }
     case _=> throw new Exception("lrAnswer with no head !!")
@@ -256,7 +256,7 @@ to update each parser involved in the recursion.
                 /*simple result*/
                 inMem.updateCacheAndGet(p,MemoEntry(Right(tempRes)))
                 tempRes
-              case s@Some(_) =>
+              case Some(_) =>
                 /*non simple result*/
                 base.seed = tempRes
                 //the base variable has passed equality tests with the cache
@@ -303,7 +303,7 @@ to update each parser involved in the recursion.
             case _ => throw new Exception("impossible match")
           }
         }
-      case f =>
+      case _ =>
         rest.recursionHeads -= rest.pos
         /*rest.updateCacheAndGet(p, MemoEntry(Right(f)));*/oldRes
     }

shared/src/main/scala/scala/util/parsing/combinator/Parsers.scala

@@ -223,7 +223,7 @@ trait Parsers {
         case s @ Success(result, rest) =>
           val failure = selectLastFailure(Some(this), s.lastFailure)
           Success(result, rest, failure)
-        case ns: NoSuccess => if (alt.next.pos < next.pos) this else alt
+        case _: NoSuccess => if (alt.next.pos < next.pos) this else alt
       }
     }
   }
@@ -316,7 +316,7 @@ trait Parsers {
      * @return a `Parser` that -- on success -- returns the result of `q`.
      */
     def ~> [U](q: => Parser[U]): Parser[U] = { lazy val p = q // lazy argument
-      (for(a <- this; b <- p) yield b).named("~>")
+      (for(_ <- this; b <- p) yield b).named("~>")
     }
 
     /** A parser combinator for sequential composition which keeps only the left result.
@@ -330,7 +330,7 @@ trait Parsers {
      * @return a `Parser` that -- on success -- returns the result of `p`.
      */
     def <~ [U](q: => Parser[U]): Parser[T] = { lazy val p = q // lazy argument
-      (for(a <- this; b <- p) yield a).named("<~")
+      (for(a <- this; _ <- p) yield a).named("<~")
     }
 
     /**
@@ -372,7 +372,7 @@ trait Parsers {
      *         The resulting parser fails if either `p` or `q` fails, this failure is fatal.
      */
     def ~>! [U](q: => Parser[U]): Parser[U] = { lazy val p = q // lazy argument
-      OnceParser { (for(a <- this; b <- commit(p)) yield b).named("~>!") }
+      OnceParser { (for(_ <- this; b <- commit(p)) yield b).named("~>!") }
     }
 
     /** A parser combinator for non-back-tracking sequential composition which only keeps the left result.
@@ -385,7 +385,7 @@ trait Parsers {
      *         The resulting parser fails if either `p` or `q` fails, this failure is fatal.
      */
     def <~! [U](q: => Parser[U]): Parser[T] = { lazy val p = q // lazy argument
-      OnceParser { (for(a <- this; b <- commit(p)) yield a).named("<~!") }
+      OnceParser { (for(a <- this; _ <- commit(p)) yield a).named("<~!") }
     }
 
 
@@ -448,7 +448,7 @@ trait Parsers {
      */
     def ^^^ [U](v: => U): Parser[U] =  new Parser[U] {
       lazy val v0 = v // lazy argument
-      def apply(in: Input) = Parser.this(in) map (x => v0)
+      def apply(in: Input) = Parser.this(in) map (_ => v0)
     }.named(toString+"^^^")
 
     /** A parser combinator for partial function application.
@@ -601,7 +601,7 @@ trait Parsers {
     p(in) match{
       case s @ Success(_, _) => s
       case e @ Error(_, _) => e
-      case f @ Failure(msg, next) => Error(msg, next)
+      case Failure(msg, next) => Error(msg, next)
     }
   }
 
@@ -613,7 +613,7 @@ trait Parsers {
    *  @param  p      A predicate that determines which elements match.
    *  @return
    */
-  def elem(kind: String, p: Elem => Boolean) = acceptIf(p)(inEl => kind+" expected")
+  def elem(kind: String, p: Elem => Boolean) = acceptIf(p)(_ => kind + " expected")
 
   /** A parser that matches only the given element `e`.
    *
@@ -995,7 +995,7 @@ trait Parsers {
    */
   def phrase[T](p: Parser[T]) = new Parser[T] {
     def apply(in: Input) = p(in) match {
-      case s @ Success(out, in1) =>
+      case s @ Success(_, in1) =>
         if (in1.atEnd) s
         else s.lastFailure match {
           case Some(failure) => failure
@@ -1032,9 +1032,9 @@ trait Parsers {
       = OnceParser{ (for(a <- this; b <- commit(p)) yield new ~(a,b)).named("~") }
 
     override def ~> [U](p: => Parser[U]): Parser[U]
-      = OnceParser{ (for(a <- this; b <- commit(p)) yield b).named("~>") }
+      = OnceParser{ (for(_ <- this; b <- commit(p)) yield b).named("~>") }
 
     override def <~ [U](p: => Parser[U]): Parser[T]
-      = OnceParser{ (for(a <- this; b <- commit(p)) yield a).named("<~") }
+      = OnceParser{ (for(a <- this; _ <- commit(p)) yield a).named("<~") }
   }
 }

shared/src/main/scala/scala/util/parsing/combinator/lexical/StdLexical.scala

@@ -79,7 +79,7 @@ class StdLexical extends Lexical with StdTokens {
     // construct parser for delimiters by |'ing together the parsers for the individual delimiters,
     // starting with the longest one -- otherwise a delimiter D will never be matched if there is
     // another delimiter that is a prefix of D
-    def parseDelim(s: String): Parser[Token] = accept(s.toList) ^^ { x => Keyword(s) }
+    def parseDelim(s: String): Parser[Token] = accept(s.toList) ^^ { _ => Keyword(s) }
 
     val d = new Array[String](delimiters.size)
     delimiters.copyToArray(d, 0)

shared/src/test/scala/scala/util/parsing/combinator/JavaTokenParsersTest.scala

@@ -12,7 +12,6 @@
 
 package scala.util.parsing.combinator
 
-import scala.language.implicitConversions
 import scala.util.parsing.input.CharArrayReader
 
 import org.junit.Test
@@ -46,7 +45,7 @@ class JavaTokenParsersTest {
     def parseFailure(s: String, errorColPos: Int): Unit = {
       val parseResult = parseAll(ident, s)
       parseResult match {
-        case Failure(msg, next) =>
+        case Failure(_, next) =>
           val pos = next.pos
           assertEquals(1, pos.line)
           assertEquals(errorColPos, pos.column)
@@ -85,7 +84,7 @@ class JavaTokenParsersTest {
 
     val parseResult1 = parseAll(p, "start start")
     parseResult1 match {
-      case e @ Failure(message, next) =>
+      case Failure(message, next) =>
         assertEquals(next.pos.line, 1)
         assertEquals(next.pos.column, 7)
         assert(message.endsWith("string matching regex '(?i)AND' expected but 's' found"))

shared/src/test/scala/scala/util/parsing/combinator/PackratParsersTest.scala

@@ -16,7 +16,6 @@ import org.junit.Test
 import org.junit.Assert.assertEquals
 import org.junit.Assert.assertTrue
 
-import scala.language.implicitConversions
 import scala.util.parsing.combinator.syntactical.StandardTokenParsers
 
 class PackratParsersTest {

shared/src/test/scala/scala/util/parsing/combinator/RegexParsersTest.scala

@@ -12,8 +12,6 @@
 
 package scala.util.parsing.combinator
 
-import scala.language.implicitConversions
-
 import org.junit.Test
 import org.junit.Assert.{ assertEquals, assertTrue }
 
@@ -63,10 +61,10 @@ class RegexParsersTest {
       def halfQuoted = quote ~ string ^^ { case q ~ s => q + s }
     }
     import parser._
-    val failureLq = parseAll(p, "\"asdf").asInstanceOf[Failure]
-    val failureRq = parseAll(p, "asdf\"").asInstanceOf[Failure]
-    val failureQBacktrackL = parseAll(q | quote, "\"").asInstanceOf[Error]
-    val failureQBacktrackR = parseAll(q | halfQuoted, "\"asdf").asInstanceOf[Error]
+    assertTrue(parseAll(p, "\"asdf").isInstanceOf[Failure])
+    assertTrue(parseAll(p, "asdf\"").isInstanceOf[Failure])
+    assertTrue(parseAll(q | quote, "\"").isInstanceOf[Error])
+    assertTrue(parseAll(q | halfQuoted, "\"asdf").isInstanceOf[Error])
 
     val successP = parseAll(p, "\"asdf\"").get
     assertEquals(successP, "asdf")

shared/src/test/scala/scala/util/parsing/combinator/gh242.scala

@@ -13,7 +13,6 @@
 import org.junit.Assert.assertEquals
 import org.junit.Test
 
-import scala.language.implicitConversions
 import scala.util.parsing.combinator.Parsers
 import scala.util.parsing.input.CharSequenceReader
 

shared/src/test/scala/scala/util/parsing/combinator/gh29.scala

@@ -14,7 +14,6 @@ package scala.util.parsing.combinator
 
 import org.junit.Test
 import org.junit.Assert.assertEquals
-import scala.language.implicitConversions
 
 class gh29 {
   object Foo extends JavaTokenParsers {

shared/src/test/scala/scala/util/parsing/combinator/gh45.scala

@@ -12,7 +12,6 @@
 
 package scala.util.parsing.combinator
 
-import scala.language.implicitConversions
 import scala.util.parsing.input._
 
 import org.junit.Test

shared/src/test/scala/scala/util/parsing/combinator/gh72.scala

@@ -10,7 +10,6 @@
  * additional information regarding copyright ownership.
  */
 
-import scala.language.implicitConversions
 import scala.util.parsing.combinator.Parsers
 import scala.util.parsing.input.CharSequenceReader
 

shared/src/test/scala/scala/util/parsing/combinator/t0700.scala

@@ -10,9 +10,8 @@
  * additional information regarding copyright ownership.
  */
 
-import java.io.{File,StringReader}
+import java.io.StringReader
 
-import scala.language.implicitConversions
 import scala.util.parsing.combinator.Parsers
 import scala.util.parsing.input.{CharArrayReader, StreamReader}
 
@@ -38,4 +37,4 @@ class T0700 {
     assertEquals("[3.2] parsed: List(2, 2, 2)", tstParsers.p(r1).toString)
     assertEquals("[3.2] parsed: List(2, 2, 2)", tstParsers.p(r2).toString)
   }
-}
+}

shared/src/test/scala/scala/util/parsing/combinator/t1229.scala

@@ -14,7 +14,6 @@ import scala.util.parsing.combinator.RegexParsers
 
 import org.junit.Test
 import org.junit.Assert.assertEquals
-import scala.language.implicitConversions
 
 class t1229 extends RegexParsers {
   val number = """0|[1-9]\d*""".r ^^ { _.toInt }

shared/src/test/scala/scala/util/parsing/combinator/t3212.scala

@@ -14,7 +14,6 @@ package scala.util.parsing.combinator
 
 import org.junit.Test
 import org.junit.Assert.assertEquals
-import scala.language.implicitConversions
 
 class t3212 extends RegexParsers {
 

shared/src/test/scala/scala/util/parsing/combinator/t5514.scala

@@ -10,7 +10,6 @@
  * additional information regarding copyright ownership.
  */
 
-import scala.language.implicitConversions
 import scala.util.parsing.combinator.Parsers
 import scala.util.parsing.input.Reader
 import scala.util.parsing.input.Position

shared/src/test/scala/scala/util/parsing/combinator/t5669.scala

@@ -12,7 +12,6 @@
 
 package scala.util.parsing.combinator
 
-import scala.language.implicitConversions
 import scala.util.parsing.input.OffsetPosition
 
 import org.junit.Test

shared/src/test/scala/scala/util/parsing/combinator/t6067.scala

@@ -14,7 +14,6 @@ import scala.util.parsing.combinator._
 
 import org.junit.Test
 import org.junit.Assert.assertEquals
-import scala.language.implicitConversions
 
 class t6067 extends RegexParsers {
   object TestParser extends RegexParsers {

shared/src/test/scala/scala/util/parsing/combinator/t6464.scala

@@ -10,7 +10,6 @@
  * additional information regarding copyright ownership.
  */
 
-import scala.language.implicitConversions
 import scala.util.parsing.input.CharSequenceReader
 import scala.util.parsing.combinator.RegexParsers
 

shared/src/test/scala/scala/util/parsing/input/OffsetPositionTest.scala

@@ -14,7 +14,6 @@ package scala.util.parsing.input
 
 import org.junit.Test
 import org.junit.Assert.assertEquals
-import scala.language.implicitConversions
 
 class OffsetPositionTest {
   @Test

shared/src/test/scala/scala/util/parsing/input/gh178.scala

@@ -14,7 +14,6 @@ package scala.util.parsing.input
 
 import org.junit.Assert.assertEquals
 import org.junit.Test
-import scala.language.implicitConversions
 
 class gh178 {
 

shared/src/test/scala/scala/util/parsing/input/gh64.scala

@@ -14,7 +14,6 @@ package scala.util.parsing.input
 
 import org.junit.Assert._
 import org.junit.Test
-import scala.language.implicitConversions
 
 class gh64 {