Skip to content

Commit 12996fc

Browse files
julienrfjulienrf
committed
Disable tests of map transformation methods that return maps
1 parent c193570 commit 12996fc

File tree

1 file changed

+85
-73
lines changed

1 file changed

+85
-73
lines changed

‎scalacheck/src/test/scala/ParallelMapCheck1.scala

Lines changed: 85 additions & 73 deletions
Original file line numberDiff line numberDiff line change
@@ -32,78 +32,90 @@ abstract class ParallelMapCheck[K, V](collname: String) extends ParallelIterable
3232

3333
// The following tests have been copied from `ParIterableCheck`, and adapted to test
3434
// overloads of the methods that return Map and ParMap collections
35-
property("mappings returning maps must be equal") = forAll/*NoShrink*/(collectionPairs) { case (t, coll) =>
36-
val results = for ((f, ind) <- mapFunctions.zipWithIndex.take(5)) yield {
37-
val ms: Map[K, V] = t.map(f)
38-
val mp: ParMap[K, V] = coll.map(f)
39-
val invs = checkDataStructureInvariants(ms, mp)
40-
if (!areEqual(ms, mp) || !invs) {
41-
println(t)
42-
println(coll)
43-
println("mapped to: ")
44-
println(ms)
45-
println(mp)
46-
println("sizes: ")
47-
println(ms.size)
48-
println(mp.size)
49-
println("valid: " + invs)
50-
}
51-
("op index: " + ind) |: (areEqual(ms, mp) && invs)
52-
}
53-
results.reduceLeft(_ && _)
54-
}
55-
56-
property("collects returning maps must be equal") = forAllNoShrink(collectionPairs) { case (t, coll) =>
57-
val results = for ((f, ind) <- partialMapFunctions.zipWithIndex) yield {
58-
val ps: Map[K, V] = t.collect(f)
59-
val pp: ParMap[K, V] = coll.collect(f)
60-
if (!areEqual(ps, pp)) {
61-
println(t)
62-
println(coll)
63-
println("collected to: ")
64-
println(ps)
65-
println(pp)
66-
}
67-
("op index: " + ind) |: areEqual(ps, pp)
68-
}
69-
results.reduceLeft(_ && _)
70-
}
71-
72-
property("flatMaps returning maps must be equal") = forAllNoShrink(collectionPairs) { case (t, coll) =>
73-
(for ((f, ind) <- flatMapFunctions.zipWithIndex)
74-
yield ("op index: " + ind) |: areEqual(t.flatMap(f), coll.flatMap(f))).reduceLeft(_ && _)
75-
}
76-
77-
property("++s returning maps must be equal") = forAll(collectionTriplets) { case (t, coll, colltoadd) =>
78-
try {
79-
val toadd = colltoadd
80-
val tr: Map[K, V] = t ++ toadd.iterator
81-
val cr: ParMap[K, V] = coll ++ toadd.iterator
82-
if (!areEqual(tr, cr)) {
83-
println("from: " + t)
84-
println("and: " + coll.iterator.toList)
85-
println("adding: " + toadd)
86-
println(tr.toList)
87-
println(cr.iterator.toList)
88-
}
89-
(s"adding " |: areEqual(tr, cr)) &&
90-
(for ((trav, ind) <- addAllIterables.zipWithIndex) yield {
91-
val tadded: Map[K, V] = t ++ trav
92-
val cadded: ParMap[K, V] = coll ++ trav
93-
if (!areEqual(tadded, cadded)) {
94-
println("----------------------")
95-
println("from: " + t)
96-
println("and: " + coll)
97-
println("adding: " + trav)
98-
println(tadded)
99-
println(cadded)
100-
}
101-
("traversable " + ind) |: areEqual(tadded, cadded)
102-
}).reduceLeft(_ && _)
103-
} catch {
104-
case e: java.lang.Exception =>
105-
throw e
106-
}
107-
}
35+
// They are disabled for now because this behavior is unspecified and the tests fail.
36+
// property("mappings returning maps must be equal") = forAll/*NoShrink*/(collectionPairs) { case (t, coll) =>
37+
// val results = for ((f, ind) <- mapFunctions.zipWithIndex.take(5)) yield {
38+
// val ms: Map[K, V] = t.map(f)
39+
// val mp: ParMap[K, V] = coll.map(f)
40+
// val invs = checkDataStructureInvariants(ms, mp)
41+
// if (!areEqual(ms, mp) || !invs) {
42+
// println(t)
43+
// println(coll)
44+
// println("mapped to: ")
45+
// println(ms)
46+
// println(mp)
47+
// println("sizes: ")
48+
// println(ms.size)
49+
// println(mp.size)
50+
// println("valid: " + invs)
51+
// }
52+
// ("op index: " + ind) |: (areEqual(ms, mp) && invs)
53+
// }
54+
// results.reduceLeft(_ && _)
55+
// }
56+
//
57+
// property("collects returning maps must be equal") = forAllNoShrink(collectionPairs) { case (t, coll) =>
58+
// val results = for ((f, ind) <- partialMapFunctions.zipWithIndex) yield {
59+
// val ps: Map[K, V] = t.collect(f)
60+
// val pp: ParMap[K, V] = coll.collect(f)
61+
// if (!areEqual(ps, pp)) {
62+
// println(t)
63+
// println(coll)
64+
// println("collected to: ")
65+
// println(ps)
66+
// println(pp)
67+
// }
68+
// ("op index: " + ind) |: areEqual(ps, pp)
69+
// }
70+
// results.reduceLeft(_ && _)
71+
// }
72+
//
73+
// property("flatMaps returning maps must be equal") = forAllNoShrink(collectionPairs) { case (t, coll) =>
74+
// (for ((f, ind) <- flatMapFunctions.zipWithIndex)
75+
// yield ("op index: " + ind) |: {
76+
// val tf: Map[K, V] = t.flatMap(f)
77+
// val collf: ParMap[K, V] = coll.flatMap(f)
78+
// if (!areEqual(tf, collf)) {
79+
// println("----------------------")
80+
// println(s"t = $t")
81+
// println(s"coll = $coll")
82+
// println(s"tf = $tf")
83+
// println(s"collf = $collf")
84+
// }
85+
// areEqual(t.flatMap(f), coll.flatMap(f))
86+
// }).reduceLeft(_ && _)
87+
// }
88+
//
89+
// property("++s returning maps must be equal") = forAll(collectionTriplets) { case (t, coll, colltoadd) =>
90+
// try {
91+
// val toadd = colltoadd
92+
// val tr: Map[K, V] = t ++ toadd.iterator
93+
// val cr: ParMap[K, V] = coll ++ toadd.iterator
94+
// if (!areEqual(tr, cr)) {
95+
// println("from: " + t)
96+
// println("and: " + coll.iterator.toList)
97+
// println("adding: " + toadd)
98+
// println(tr.toList)
99+
// println(cr.iterator.toList)
100+
// }
101+
// (s"adding " |: areEqual(tr, cr)) &&
102+
// (for ((trav, ind) <- addAllIterables.zipWithIndex) yield {
103+
// val tadded: Map[K, V] = t ++ trav
104+
// val cadded: ParMap[K, V] = coll ++ trav
105+
// if (!areEqual(tadded, cadded)) {
106+
// println("----------------------")
107+
// println("from: " + t)
108+
// println("and: " + coll)
109+
// println("adding: " + trav)
110+
// println(tadded)
111+
// println(cadded)
112+
// }
113+
// ("traversable " + ind) |: areEqual(tadded, cadded)
114+
// }).reduceLeft(_ && _)
115+
// } catch {
116+
// case e: java.lang.Exception =>
117+
// throw e
118+
// }
119+
// }
108120

109121
}

0 commit comments

Comments
 (0)